From: Marc Zyngier <maz@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
Yang Guo <guoyang2@huawei.com>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Fix CNTPCT_LO and CNTVCT_LO value
Date: Mon, 26 Sep 2022 09:17:38 -0400 [thread overview]
Message-ID: <864jwu8ebx.wl-maz@kernel.org> (raw)
In-Reply-To: <9d24f923-f188-dfce-b0a3-6e6231bc3650@hisilicon.com>
On Mon, 26 Sep 2022 09:12:15 -0400,
Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
>
> Hi Marc,
>
> 在 2022/9/26 20:46, Marc Zyngier 写道:
> > On Mon, 26 Sep 2022 07:30:03 -0400,
> > Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
> >
> > Please Cc the clocksource maintainers (now added) so that they know
> > what is going on.
> >
>
> Oops，I only Cced Mark and you and will add the two in V2.
>
> >>
> >> From: Yang Guo <guoyang2@huawei.com>
> >>
> >> CNTPCT_LO and CNTVCT_LO are defined by mistake in commit '8b82c4f883a7',
> >> so fix them according to the Arm ARM as follows:
> >
> > Please quote the location of the information: DDi 0487I.a, Table I2-4
> > "CNTBaseN memory map"
> >
>
> Sure.
>
> >>
> >> Offset Register Type Description
> >> 0x000 CNTPCT[31:0] RO Physical Count register.
> >> 0x004 CNTPCT[63:32] RO
> >> 0x008 CNTVCT[31:0] RO Virtual Count register.
> >> 0x00C CNTVCT[63:32] RO
> >>
> >> Fixes: 8b82c4f883a7 ("clocksource/drivers/arm_arch_timer: Move MMIO timer programming over to CVAL")
> >
> > Cc: stable@vger.kernel.org
> >
>
> It's was introduced in Linux 5.16, Shall I Cc stable?
Yes, as this will need to be backported to 5.19 at the very least.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-26 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 11:30 [PATCH] clocksource/drivers/arm_arch_timer: Fix CNTPCT_LO and CNTVCT_LO value Shaokun Zhang
2022-09-26 12:46 ` Marc Zyngier
2022-09-26 13:12 ` Shaokun Zhang
2022-09-26 13:17 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jwu8ebx.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=guoyang2@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.