From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: [PATCH v4] drm/i915: Fix recursive calls to unmap Date: Tue, 24 Jan 2012 11:30:52 -0800 Message-ID: <864nvknbir.fsf@sumi.keithp.com> References: <1327360317-4885-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0805155934==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id E0FFEA02C5 for ; Tue, 24 Jan 2012 11:30:56 -0800 (PST) In-Reply-To: <1327360317-4885-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org --===============0805155934== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 23 Jan 2012 15:11:57 -0800, Ben Widawsky wrote: > v3: As Keith Packard pointed out, v2 changed retirement behavior. While > it was intentional, it wasn't related to the bugfix, and so has been > removed. To do this, changed i915_wait_request to be a macro to assure > old behavior is kept. Yuck. Using a macro and creating a new name which is nearly identical to the old name is asking for trouble. The function signature change will ensure that all callers are caught, and so the old callers can be updated to pass 'false'. Given that there are only half a dozen callers, it should be easy to just fix them. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTx8G7DYtFsjWk68qAQiUURAAla7n+bg88R/0prZ2uCLs8Etph9NsThfX UTOaAuk4K+iYJeMlPlhfMQR7MI2yx+34d6vHuiOrIL6J8ovsv6tV+AgpQmQ4rhlc +OdTO/n449VSnNG36VpXuB1HV0ESNPvPDQl8z6wLsbfd/vRfKTV9ckFa5rv1hSs0 k4v644LKvewpmQk+FtM2d5EkGtdjZYN5JFumtbPUB+vtNqJiNi6KhivGPXHG4X+B 2HcmayOOKCpiVp38ECPJv2YZ1pah30hk+EZo7LYAnZjjQRjn6P06MOMDLiM/KOvB GC2lqCPulbUGs4cdcmveWtRxSCo8BHQgLVIqUrlAkApInMV6s1awHtlOMJZwsXaL nhRHFJxg3ArFVsAc3N2QvtZnfP/yJYZXS94FMJ+BcqOe0e5kj58gHWxPZhOy5tKB GESr3yyPAcmYbh3l6ua+ARQu8XDUxp0aib40FbLDeBeXZyEJ52aAZKjq+vyadSz1 bh+I9nx0Y2MrD7NTCTeW92WMgaNXaimBh6m0neOo1a9A7Qc6KJFHJP5SL0ugDZLj zKQ/d9K3cYoRivyjcPPXNG9fXSHsrqRDecEm6k+ZyHNe3YrPTwnYkB0pSHpyG1WU eHlkQoOqUV8rZVtS3FzS1SFR/hHjFu2WxAE/7hktZw0KBLgqD+onyVMVPIxI4lyq tbt6/LVXjf4= =E89Q -----END PGP SIGNATURE----- --=-=-=-- --===============0805155934== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0805155934==--