From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH 1/3] drm/i915: relative_constants_mode race
	fix
Date: Wed, 23 Nov 2011 13:34:06 -0800
Message-ID: <864nxued69.fsf@sumi.keithp.com>
References: <1319337685-26195-1-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1778039064=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3DE269ED6A
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 23 Nov 2011 13:34:03 -0800 (PST)
In-Reply-To: <1319337685-26195-1-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

--===============1778039064==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Sat, 22 Oct 2011 19:41:23 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:

> +		    mode !=3D dev_priv->relative_constants_mode) {
> +			if (INTEL_INFO(dev)->gen < 4)
> +				return -EINVAL;
> +
> +			if (INTEL_INFO(dev)->gen > 5 &&
> +			    mode =3D=3D I915_EXEC_CONSTANTS_REL_SURFACE)
> +				return -EINVAL;

You need to clean up before returning; you've allocated cliprects and an
exec buffer and also locked the mutex.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIVAwUBTs1mzjYtFsjWk68qAQgRFQ/+NEwRuigk3bbgHQ9Yp+3KRBVueAE+Ff86
LVH2r8qxqgl7amSvtMKFT+IBM6K65qdrslT5G39SDS9h2wMHE/w3A22Fm2Ys7kmG
toAr2jgB0VqpIHRSDrY1uvM/Fr3TurDzSH+P8mry7UEq2eObuy5/jSMDQD8c5m0m
yi8NO1nx0Yu3U32oZyxz55MMiUiTpyXE3UP2RurABhP5CHD9TAy9uHCOxjBUQfmr
yqY/7pLR/gCoYChVsYKoCfYQ/OiN960PzLXkviK7x1bHSMTn2pvMC+8Wr62Soemv
ml3g+j0siDuNoQmJz+gp9yu9iwV+woHVU5HFtL03/KPr0Ww9D6w4zX7BIgbUyboa
Qt0ZsZhpLEk2p/s5dOvEMqCAfBaT3nK2OaH0mUKJlY19Iiy3Mox9+O03jgaL2Vcx
AhMsHPvTPu19J9afI44wYT1f/raSIk3yNchL8US3nJ1KbvgmJQi0dP3cT5zqFwUc
7lQ0VNFmcJwwptcqcAWFUj7JKLiddGiliNJkQmVFrbr4+ii7ikkep4PgZRJ7XwB+
T/gWtyfauF+M8rcDK1yE1QXg0Tb1LMv1gcqfdkoITSneGhSNsptkSrtR8t8E4XEL
NcZHRRa2pP5DNmwhYrylx8V2ToKs9SEmy3ddHQSwVLAneaTMrrl4ZkoLxlL53hB8
NXw96K8Wstg=
=jUrH
-----END PGP SIGNATURE-----
--=-=-=--

--===============1778039064==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1778039064==--