Re: [PATCH v8 00/19] imx: add i.MX95 support

[Marek Vasut <marex@denx.de>]

On 3/21/25 8:15 AM, Alice Guo (OSS) wrote:
> Changes for v7:
>   - separate i.MX Messaging Unit driver patch from this patch set
>   - add U_BOOT_SCMI_PROTO_DRIVER() to avoid putting i.MX related code in scmi_agent-uclass.c.
>   - update drivers/clk/clk_scmi.c according to comment
>   - dynamically allocate the size of struct scmi_base_discover_list_protocols_out
> 
> Changes for v8:
>   - add a comma to enum scmi_clock_message_id
>   - use readl_poll_timeout instead of while to avoid to silent hang in
>     disable_wdog()
>   - use the format "%pM" to print a MAC address
>   - use "%u" to match the data type u32
>   - add a comma enum imx8image_cmd, enum imx8image_core_type and so on
>   - add a line at end of container.cfg, imximage.cfg and imx95_19x19_evk.env
>   - update arch/arm/mach-imx/imx9/scmi/soc.c
I added a couple of comments , I'm sorry this took so long.

I think the SCMI part is starting to be pretty good.

It might make sense to split off the SCMI parts and get that in first, 
this way:

Separate patch:
[PATCH v8 01/19] firmware: scmi: smt: Interrupt communication enable

Separate patch:
[PATCH v8 09/19] scmi_protocols: update struct 
scmi_base_discover_list_protocols_out

Separate patchset:
[PATCH v8 03/19] firmware: scmi_agent: add SCMI pin control protocol support
...
[PATCH v8 08/19] sandbox: add SCMI clock control permissions to sandbox

And then the rest as a follow up series.

This will allow you to reduce the size of the series and get the pieces 
which are good in quickly, without having to resend them repeatedly as a 
part of larger series. (and yes, it also makes reviewing easier)