From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44283C79F82 for ; Tue, 8 Sep 2026 10:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r1A3HpbHQsHA2RB041odelGfeGNrgx5zShwsPKCjVJY=; b=hYZngMaLiKu7f/vzawAAyB5xnU A1om9hSFaWzLLaq5dVDalNAgpSXwWzMDY8f6Twaps6CQF/cBi0ENUNeglfW4rNomwVcEbgj2fx1dh tvlVkZ0g4uKSzui2EYkDzZ/txb52fI71tHrRRn5nXOZgXMSpX3fy6z7T69utMOYDBHy6pd46v6bLs 1MXrNm0+0MRfnIlLQcd+U9XYRPe2GBqmuLc5Tf/AT4Dev0P1ukfUvr7h+ihGlRQYcEr0qj5ffHcrK /dxGwyP4KFfGi4ehubF/jIcu/jOnVfvrn3nQbslEATycXdYvMb35TEBNBcDHO9qr7vkarcra3an3G ZZ/vrxKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3tLU-00000008oSL-2Nzh; Tue, 08 Sep 2026 10:46:33 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3tLS-00000008oRy-36Nm for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2026 10:46:30 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id F34D2601DB; Tue, 8 Sep 2026 10:46:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA57D1F00A3D; Tue, 8 Sep 2026 10:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788864389; bh=r1A3HpbHQsHA2RB041odelGfeGNrgx5zShwsPKCjVJY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=FXWsEextUfrPwGyY37UbyGVfVPDoLNSY+T6wYA+fUXEjFoSus+TRyhggXZkdKA6P4 Kosb4QbSEMtComqVYDUJGaLmX8W11/QckcB0vOvklC6s1c4A5pTxSLB0Ba8gVmZnOU j0k4GMbiYffA/sxT5WPOjTwlkvgIJ11SpxbMx4IjYmWA5Ukj5uzI2/Cjt0NAb6UqpJ lUi/jxAY9PDXi+xuo5eioM3/bqzPpJ+gYsxyMB5pjZka9sCAfFrdHO8TxVhpF7qT/P to8AHTuwG46xZkR15p7GQmm+Ybjr/DXRYfng0OzuZI8YRKqJ640RJaTgYERSvbfEfI CDgzw4qVC/ypg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x3tLP-00000006AAm-2Jaw; Tue, 08 Sep 2026 10:46:27 +0000 Date: Tue, 08 Sep 2026 11:46:27 +0100 Message-ID: <865x0g3trw.wl-maz@kernel.org> From: Marc Zyngier To: Raviteja Laggyshetty Cc: Abel Vesa , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Abel Vesa , Bjorn Andersson , Mostafa Saleh , Odelu Kukatla Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: Add opt-out parameter for QoS settings In-Reply-To: <17d7ebef-9ec7-4bf8-bf16-34e3bd3cd92e@oss.qualcomm.com> References: <20260907171729.1735641-1-maz@kernel.org> <87ld9c4vc2.wl-maz@kernel.org> <6iixty74opjqkegpdmtytffgrllcjvrmhlsv53xtackdqzvwge@6fh5onz27p6c> <17d7ebef-9ec7-4bf8-bf16-34e3bd3cd92e@oss.qualcomm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: raviteja.laggyshetty@oss.qualcomm.com, abel.vesa@oss.qualcomm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, konrad.dybcio@oss.qualcomm.com, abelvesa@kernel.org, andersson@kernel.org, smostafa@google.com, odelu.kukatla@oss.qualcomm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 08 Sep 2026 09:29:44 +0100, Raviteja Laggyshetty wrote: > > > > On 9/8/2026 1:04 PM, Abel Vesa wrote: > > On 26-09-07 22:15:09, Marc Zyngier wrote: > >> On Mon, 07 Sep 2026 21:21:44 +0100, > >> Abel Vesa wrote: > >>> > >>> On 26-09-07 18:17:29, Marc Zyngier wrote: > >>>> Recent addition of QoS configuration to the X1 variants resulted in > >>>> systems that spontaneously reset at boot time or under load. > >>>> > >>>> Given that this is both very unpleasant and hard to debug, give the > >>>> affected user the option to survive such event with a module parameter. > >>>> > >>>> Passing "icc_rpmh.enable_qos=0" to the kernel command-line will skip the > >>>> offending QoS setup. > >>>> > >>> > >>> Lets not start doing this, please. > >>> > >>> Can we figure out which platform deosn't work and then maybe we can > >>> add a quirk in DT per platform? > >> > >> We have at least 3 machines that are dysfunctional since [1] was > >> merged (mini-x, sp12 and devkit). Probably some more, but I'm not > >> going to be the one doing a survey. > >> > >> What really should happen is [1] to be reversed until QC figures out a > >> set of parameters that actually works, instead of making this platform > >> even more unreliable than it already is. > > > > I'd rather have the patch reverted than adding a module parameter which > > users might not know about and distros will probably never addopt. > > > >> > >> Just like [2] should have been reverted. > >> > >> Until then, we'll have to paper over this stuff. > > > > But a module parameter complicates things rather than just papering over. > > > > I suggest we get both reverted if they break existing platforms. > > I will share a patch to add interconnect support for Purwa. > Purwa is similar to Hamoa, but there are few port additions and deletions with > respect to PCIe, and trying to program QoS for them can result in crash. This is unfortunately not solely about Purwa, as repeatedly pointed out in this thread and the original one. Hamoa (at least the machine I use for a lot of my upstream work) has become completely unreliable since the QoS patch was merged, and randomly resets under IO load. Not applying the QoS configuration restores stability. My conclusion is that merging this stuff was premature and has evidently not seen enough testing and verification. M. -- Without deviation from the norm, progress is not possible.