From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35B29430790; Mon, 20 Jul 2026 14:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784559036; cv=none; b=KKCDhL/ZOZnePFFrsUgJ9jn1pL2DINvrCYgHIfv82x60vQ/lpQXss/chLRUSv2gcjYfiZKqQH8LDatPXbJ79DGbZpQSEJDGJh0lpjl6h2IeYWivq7R8lN7ROM7IkwJXIYyM3etyDuasax8LBs1427K35Rz0/JOwtNkoFz+Yg1MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784559036; c=relaxed/simple; bh=FRf04JDNyz7fVzp86tX1ALj/XTyrRfiWdXqch44wSac=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Ot2g7d/sYgvdVrTREd1BSiIKR7djOEG9Sv6DLMY+7RXDmZaIgUy99Sfz3FfaIsE0Qfw2GcAfMf+FdrJcQTty2GIlkbPHobn16Yk2syPsZHAaDEFT6PMIuim2tLoZDC+8uA2DzcX0bOOfzUH4IO7gNjXZr54WPZiZrE6iqq2toMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mxdvnPWc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mxdvnPWc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C5281F00A3D; Mon, 20 Jul 2026 14:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784559035; bh=KFNU8BJwlHvz1GcHJV+TRpXlJabaxtHRpK2Bxx9BGIw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=mxdvnPWcJth+tLYm10nrY7UUySj0VsCNnDSWxhUkN6WNFp8tXvwRbdyHtW3mcCO4H o2CY8CwPlj83WhUy9ytsKzdhRvlbFXNTy0XRd/xO3KRlXx9xURw6xuD5MLCtJ+0WuQ WVeQ7FFb1y/BYqhc/IUUaMrUD2Az8V8Hrn967veMf9Rh3SbtTPP1f8/dbGsqTTlPFI qenpli2z2T1uReQ+jz4apllaZbK8JDQJyTR6kx3O551qAtADxfJoOe4hISp9iT0cwH mp/gKdkIHM980cARsHuBMTFfI4enBJ8GSkHMymdaCdpGz3llcLIL81zyt1W0OgKduu 8Jw2tHMzCn7zA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wlpKD-00000006qkA-1qfZ; Mon, 20 Jul 2026 14:50:33 +0000 Date: Mon, 20 Jul 2026 15:50:33 +0100 Message-ID: <865x29g1fq.wl-maz@kernel.org> From: Marc Zyngier To: sashiko-reviews@lists.linux.dev Cc: "Oliver Upton" , kvmarm@lists.linux.dev Subject: Re: [PATCH 4/5] KVM: arm64: vgic-v3: Simplify initial GICv3 configuration sampling In-Reply-To: <20260720133827.2A32C1F000E9@smtp.kernel.org> References: <20260720132220.2143486-1-maz@kernel.org> <20260720132220.2143486-6-maz@kernel.org> <20260720133827.2A32C1F000E9@smtp.kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashiko-reviews@lists.linux.dev, oupton@kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 20 Jul 2026 14:38:26 +0100, sashiko-bot@kernel.org wrote: > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Medium] The `noinstr` function `kvm_patch_ich_vtr_el2()` calls a non-`noinstr` function (`vgic_v3_broken_seis()`), causing a `noinstr` section violation. > - [Medium] `WARN_ON` inside the `noinstr` alternative patching callback `kvm_patch_ich_vtr_el2()` violates instrumentation rules and risks deadlocks. [...] See response to patch #2. M. -- Without deviation from the norm, progress is not possible.