From: Marc Zyngier <maz@kernel.org>
To: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: Use int type to store negative error codes
Date: Fri, 29 Aug 2025 16:04:35 +0100 [thread overview]
Message-ID: <865xe6dv98.wl-maz@kernel.org> (raw)
In-Reply-To: <20250829132020.82077-1-rongqianfeng@vivo.com>
On Fri, 29 Aug 2025 14:20:19 +0100,
Qianfeng Rong <rongqianfeng@vivo.com> wrote:
>
> Change the 'ret' variable from unsigned int to int to store negative error
> codes or zero returned by other functions.
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but it's ugly. Additionally, assigning negative error codes to
> unsigned type may trigger a GCC warning when the -Wsign-conversion flag is
> enabled.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
For the GICv3 code:
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-08-30 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 13:20 [PATCH] irqchip: Use int type to store negative error codes Qianfeng Rong
2025-08-29 15:04 ` Marc Zyngier [this message]
2025-09-03 12:14 ` [tip: irq/drivers] " tip-bot2 for Qianfeng Rong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865xe6dv98.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.