All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	stable@vger.kernel.org, syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH v2] KVM: arm64: Get rid of userspace_irqchip_in_use
Date: Tue, 29 Oct 2024 18:47:29 +0000	[thread overview]
Message-ID: <865xpa3fwe.wl-maz@kernel.org> (raw)
In-Reply-To: <CAJHc60x3sGdi2_mg_9uxecPYwZMBR11m1oEKPEH4RTYaF8eHdQ@mail.gmail.com>

On Tue, 29 Oct 2024 17:06:09 +0000,
Raghavendra Rao Ananta <rananta@google.com> wrote:
> 
> On Tue, Oct 29, 2024 at 9:27 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > On Mon, 28 Oct 2024 23:45:33 +0000,
> > Raghavendra Rao Ananta <rananta@google.com> wrote:
> > >
> > Did you have a chance to check whether this had any negative impact on
> > actual workloads? Since the entry/exit code is a bit of a hot spot,
> > I'd like to make sure we're not penalising the common case (I only
> > wrote this patch while waiting in an airport, and didn't test it at
> > all).
> >
> I ran the kvm selftests, kvm-unit-tests and booted a linux guest to
> test the change and noticed no failures.
> Any specific test you want to try out?

My question is not about failures (I didn't expect any), but
specifically about *performance*, and whether checking the flag
without a static key can lead to any performance drop on the hot path.

Can you please run an exit-heavy workload (such as hackbench, for
example), and report any significant delta you could measure?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2024-10-29 18:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 23:45 [PATCH v2] KVM: arm64: Get rid of userspace_irqchip_in_use Raghavendra Rao Ananta
2024-10-29 16:27 ` Marc Zyngier
2024-10-29 17:06   ` Raghavendra Rao Ananta
2024-10-29 18:47     ` Marc Zyngier [this message]
2024-10-30  0:16       ` Raghavendra Rao Ananta
2024-10-30  8:22         ` Marc Zyngier
2024-10-30 16:36           ` Raghavendra Rao Ananta
2024-10-30 17:17             ` Marc Zyngier
2024-10-31 19:56 ` Oliver Upton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xpa3fwe.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=rananta@google.com \
    --cc=stable@vger.kernel.org \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.