From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A92C613AC3 for ; Mon, 23 Oct 2023 09:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OoIaj4I/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7600DC433CB; Mon, 23 Oct 2023 09:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698053795; bh=ZSUewbvKop79mqdPaUFTNzU9LflnLNCqSMJdNuxAnAc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OoIaj4I/kXvOZHyqbZnIBsbnrOilgLIaQYAaAoixeIg5ipmgPyjAid1C9+2FdLFGz W4HQP9habfbsZcXYlePziXzdw0wlMCStu6OE88ZzydM7IvKBnwkQFlt1kA6Uj4m5SK WZQKBIVh65Ye6jfP6BO5gCSCCNNCG05CNrUJwZci6iYhkDzCkVqKWLFNJyDJUUHpJL 3tIt28UQ0ahYAjMYTUYctjgL0ertzhS5JUx8QfYmVU1zn6f91qjTKHfNI9kep/Viqr JyTKQeLpgIK1+d84m6zhiQkPy2LwzwoPXrZs0RANoTHxRsOwQ+lfPB7DHC9w75J4zB ZEkecQ4MhcviQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qurMP-006n2q-1v; Mon, 23 Oct 2023 10:36:33 +0100 Date: Mon, 23 Oct 2023 10:36:32 +0100 Message-ID: <865y2x65pb.wl-maz@kernel.org> From: Marc Zyngier To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Oliver Upton , Suzuki K Poulose , James Morse , Zenghui Yu , Ard Biesheuvel , Anshuman Khandual , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 06/12] KVM: arm64: Use LPA2 page-tables for stage2 and hyp stage1 In-Reply-To: <9d4ac532-1642-411b-a826-ab90f0046a6c@arm.com> References: <20231009185008.3803879-1-ryan.roberts@arm.com> <20231009185008.3803879-7-ryan.roberts@arm.com> <86bkctmz6t.wl-maz@kernel.org> <9d4ac532-1642-411b-a826-ab90f0046a6c@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ryan.roberts@arm.com, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, james.morse@arm.com, yuzenghui@huawei.com, ardb@kernel.org, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 20 Oct 2023 16:06:50 +0100, Ryan Roberts wrote: > > On 20/10/2023 10:16, Marc Zyngier wrote: > > On Mon, 09 Oct 2023 19:50:02 +0100, > > Ryan Roberts wrote: > >> > >> diff --git a/arch/arm64/kvm/hyp/nvhe/tlb.c b/arch/arm64/kvm/hyp/nvhe/tlb.c > >> index d42b72f78a9b..c3cd16c6f95f 100644 > >> --- a/arch/arm64/kvm/hyp/nvhe/tlb.c > >> +++ b/arch/arm64/kvm/hyp/nvhe/tlb.c > >> @@ -198,7 +198,8 @@ void __kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu, > >> /* Switch to requested VMID */ > >> __tlb_switch_to_guest(mmu, &cxt, false); > >> > >> - __flush_s2_tlb_range_op(ipas2e1is, start, pages, stride, 0, false); > >> + __flush_s2_tlb_range_op(ipas2e1is, start, pages, stride, 0, > >> + system_supports_lpa2()); > > > > At this stage, I'd fully expect the flag to have been subsumed into > > the helper... > > ACK. I'm planning to have has_lpa2() always return false for now. Then once > Ard's changes are in, we can change it to report the system status. Then we can > move this inside __flush_s2_tlb_range_op(). Does that work for you? Sure, go for it and see what it looks like. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32DB4C001E0 for ; Mon, 23 Oct 2023 09:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+PJeLX2307eDhjmmd5oNmRuKNMhcG0Auvs58TPJQMxc=; b=Sh3fH4oi8RqLMk E/gIS7/CZs296fw5aNx8XiRfVxhClcFaQ32GrTp4YlF61z2w+Dc9evwm0CYikPZSqqLAi6ZNfiflk CnITCokvJaKgu0HwUdaEayITLBWwpMRrbQhZ6EgHno5Xy8NimlhZIJRNm+eaEDGF9ssDMBt0p15UD o25CLBuzP2dqNvUlRFarGDQG8jVF8YYSTyhEpOx5zdNBtKfIrib0DbVfmgDTxePqMUcicju12DNk+ xouSX1tEJNjTJQZDR/zkhLmGV3UFAMjymQGl34Hk7O6Ni2CLva9InrK2TOAuNyGlBNwo66RzTMlL0 BrcoJxPC8PzyLTOPBwFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qurMV-006tmL-11; Mon, 23 Oct 2023 09:36:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qurMS-006tld-1t for linux-arm-kernel@lists.infradead.org; Mon, 23 Oct 2023 09:36:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CB07F61B4A; Mon, 23 Oct 2023 09:36:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7600DC433CB; Mon, 23 Oct 2023 09:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698053795; bh=ZSUewbvKop79mqdPaUFTNzU9LflnLNCqSMJdNuxAnAc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OoIaj4I/kXvOZHyqbZnIBsbnrOilgLIaQYAaAoixeIg5ipmgPyjAid1C9+2FdLFGz W4HQP9habfbsZcXYlePziXzdw0wlMCStu6OE88ZzydM7IvKBnwkQFlt1kA6Uj4m5SK WZQKBIVh65Ye6jfP6BO5gCSCCNNCG05CNrUJwZci6iYhkDzCkVqKWLFNJyDJUUHpJL 3tIt28UQ0ahYAjMYTUYctjgL0ertzhS5JUx8QfYmVU1zn6f91qjTKHfNI9kep/Viqr JyTKQeLpgIK1+d84m6zhiQkPy2LwzwoPXrZs0RANoTHxRsOwQ+lfPB7DHC9w75J4zB ZEkecQ4MhcviQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qurMP-006n2q-1v; Mon, 23 Oct 2023 10:36:33 +0100 Date: Mon, 23 Oct 2023 10:36:32 +0100 Message-ID: <865y2x65pb.wl-maz@kernel.org> From: Marc Zyngier To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Oliver Upton , Suzuki K Poulose , James Morse , Zenghui Yu , Ard Biesheuvel , Anshuman Khandual , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 06/12] KVM: arm64: Use LPA2 page-tables for stage2 and hyp stage1 In-Reply-To: <9d4ac532-1642-411b-a826-ab90f0046a6c@arm.com> References: <20231009185008.3803879-1-ryan.roberts@arm.com> <20231009185008.3803879-7-ryan.roberts@arm.com> <86bkctmz6t.wl-maz@kernel.org> <9d4ac532-1642-411b-a826-ab90f0046a6c@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ryan.roberts@arm.com, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, james.morse@arm.com, yuzenghui@huawei.com, ardb@kernel.org, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_023636_668158_CB67050E X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 20 Oct 2023 16:06:50 +0100, Ryan Roberts wrote: > > On 20/10/2023 10:16, Marc Zyngier wrote: > > On Mon, 09 Oct 2023 19:50:02 +0100, > > Ryan Roberts wrote: > >> > >> diff --git a/arch/arm64/kvm/hyp/nvhe/tlb.c b/arch/arm64/kvm/hyp/nvhe/tlb.c > >> index d42b72f78a9b..c3cd16c6f95f 100644 > >> --- a/arch/arm64/kvm/hyp/nvhe/tlb.c > >> +++ b/arch/arm64/kvm/hyp/nvhe/tlb.c > >> @@ -198,7 +198,8 @@ void __kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu, > >> /* Switch to requested VMID */ > >> __tlb_switch_to_guest(mmu, &cxt, false); > >> > >> - __flush_s2_tlb_range_op(ipas2e1is, start, pages, stride, 0, false); > >> + __flush_s2_tlb_range_op(ipas2e1is, start, pages, stride, 0, > >> + system_supports_lpa2()); > > > > At this stage, I'd fully expect the flag to have been subsumed into > > the helper... > > ACK. I'm planning to have has_lpa2() always return false for now. Then once > Ard's changes are in, we can change it to report the system status. Then we can > move this inside __flush_s2_tlb_range_op(). Does that work for you? Sure, go for it and see what it looks like. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel