From: Marc Zyngier <maz@kernel.org>
To: Gavin Shan <gshan@redhat.com>
Cc: eric.auger@redhat.com, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, cohuck@redhat.com, zhenyzha@redhat.com,
richard.henderson@linaro.org, peter.maydell@linaro.org,
shan.gavin@gmail.com
Subject: Re: [PATCH v5 6/6] hw/arm/virt: Add 'compact-highmem' property
Date: Thu, 20 Oct 2022 10:44:25 +0100 [thread overview]
Message-ID: <865ygeg77q.wl-maz@kernel.org> (raw)
In-Reply-To: <6566e453-9b05-7092-f112-ea9e523be8b4@redhat.com>
On Thu, 20 Oct 2022 00:57:32 +0100,
Gavin Shan <gshan@redhat.com> wrote:
>
> For Marc's suggestion to add properties so that these high memory
> regions can be disabled by users. I can add one patch after this one
> to introduce the following 3 properties. Could you please confirm
> the property names are good enough? It's nice if Marc can help to
> confirm before I'm going to work on next revision.
>
> "highmem-ecam": "on"/"off" on vms->highmem_ecam
> "highmem-mmio": "on"/"off" on vms->highmem_mmio
> "highmem-redists": "on"/"off" on vms->highmem_redists
I think that'd be reasonable, and would give the user some actual
control over what gets exposed in the highmem region.
I guess that the annoying thing with these options is that they allow
the user to request conflicting settings (256 CPUs and
highmem-redists=off, for example). You'll need to make this fail more
or less gracefully.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-10-20 9:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 23:18 [PATCH v5 0/6] hw/arm/virt: Improve address assignment for high memory regions Gavin Shan
2022-10-11 23:18 ` [PATCH v5 1/6] hw/arm/virt: Introduce virt_set_high_memmap() helper Gavin Shan
2022-10-11 23:18 ` [PATCH v5 2/6] hw/arm/virt: Rename variable size to region_size in virt_set_high_memmap() Gavin Shan
2022-10-11 23:18 ` [PATCH v5 3/6] hw/arm/virt: Introduce variable region_base " Gavin Shan
2022-10-11 23:18 ` [PATCH v5 4/6] hw/arm/virt: Introduce virt_get_high_memmap_enabled() helper Gavin Shan
2022-10-19 13:50 ` Cornelia Huck
2022-10-20 4:57 ` Eric Auger
2022-10-11 23:18 ` [PATCH v5 5/6] hw/arm/virt: Improve high memory region address assignment Gavin Shan
2022-10-19 13:54 ` Cornelia Huck
2022-10-19 20:07 ` Eric Auger
2022-10-19 22:58 ` Gavin Shan
2022-10-11 23:18 ` [PATCH v5 6/6] hw/arm/virt: Add 'compact-highmem' property Gavin Shan
2022-10-19 14:00 ` Cornelia Huck
2022-10-19 23:08 ` Gavin Shan
2022-10-19 20:18 ` Eric Auger
2022-10-19 23:57 ` Gavin Shan
2022-10-20 9:44 ` Marc Zyngier [this message]
2022-10-20 11:13 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865ygeg77q.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.