From: Chris Ball <cjb@laptop.org>
To: Al Cooper <alcooperx@gmail.com>,
linux-mmc@vger.kernel.org, ulf.hansson@linaro.org
Subject: Re: [PATCH V2 1/7] mmc: lock: Use the kernel "KEYS" subsystem to get a card's password
Date: Sun, 01 Sep 2013 22:08:17 +0100 [thread overview]
Message-ID: <8661ukckse.fsf@void.printf.net> (raw)
In-Reply-To: <86li3gcr0x.fsf@void.printf.net> (Chris Ball's message of "Sun, 01 Sep 2013 19:53:34 +0100")
Hi,
On Sun, Sep 01 2013, Chris Ball wrote:
>> +config MMC_LOCK
>> + bool "MMC/SD password based card lock/unlock"
>> + select KEYS
>> + help
>> + This will add the ability to lock/unlock SD and MMC cards.
>> +
>> + If unsure, say N.
>
> Is there a good reason to have this behind a Kconfig entry, rather
> than just enabled for everyone? I'm happy to just enable it if we
> don't expect any downside.
Well, I guess it's the dependency on the KEYS subsystem. I can see
that some people would like to build embedded devices with MMC but
without KEYS. It's a shame to have this code go entirely untested
by most of our users, though..
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
next prev parent reply other threads:[~2013-09-01 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 20:14 [PATCH V2 0/7] Add password protected lock/unlock support for SD/MMC Al Cooper
2013-08-30 20:14 ` [PATCH V2 1/7] mmc: lock: Use the kernel "KEYS" subsystem to get a card's password Al Cooper
2013-09-01 18:53 ` Chris Ball
2013-09-01 21:08 ` Chris Ball [this message]
2013-08-30 20:14 ` [PATCH V2 2/7] mmc: lock: Add low level LOCK_UNLOCK command Al Cooper
2013-08-30 20:14 ` [PATCH V2 3/7] mmc: lock: Add function to unlock a password locked card Al Cooper
2013-08-30 20:14 ` [PATCH V2 4/7] mmc: lock: Add card lock/unlock maintenance commands Al Cooper
2013-08-30 20:14 ` [PATCH V2 5/7] mmc: lock: Change SD init functionality to handle locked SD cards Al Cooper
2013-08-30 20:14 ` [PATCH V2 6/7] mmc: lock: Prevent partition table read for locked cards Al Cooper
2013-08-30 20:14 ` [PATCH V2 7/7] mmc: lock: Change MMC init to handle " Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8661ukckse.fsf@void.printf.net \
--to=cjb@laptop.org \
--cc=alcooperx@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.