From: Juan Quintela <quintela@mandrakesoft.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] sc-ip22.c cleanup
Date: Thu, 08 May 2003 00:17:18 +0200 [thread overview]
Message-ID: <8665oml7v5.fsf@trasno.mitica> (raw)
In-Reply-To: <20030507202229.GA627@kopretinka> (Ladislav Michl's message of "Wed, 7 May 2003 22:22:29 +0200")
>>>>> "ladis" == Ladislav Michl <ladis@linux-mips.org> writes:
Hi
ladis> + unsigned long size = ip22_eeprom_read(&sgimc->eeprom, 17);
Defining somewhere what 17 mean could be a good idea :)
Except for that looks like a good gain, you remove a lot fo code :)
Later, Juan.
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
prev parent reply other threads:[~2003-05-07 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-07 20:22 [PATCH] sc-ip22.c cleanup Ladislav Michl
2003-05-07 22:17 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8665oml7v5.fsf@trasno.mitica \
--to=quintela@mandrakesoft.com \
--cc=ladis@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.