From: Paolo Bonzini <pbonzini@redhat.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 0/3 v3] KVM: nSVM: Check MBZ bits in CR3 and CR4 on vmrun of nested guests
Date: Tue, 7 Jul 2020 12:32:33 +0200 [thread overview]
Message-ID: <866d6456-314b-efbb-e46a-56e660c1c211@redhat.com> (raw)
In-Reply-To: <4b0fd4e7-465a-428f-c906-ddf0ad367cbb@oracle.com>
On 07/07/20 02:34, Krish Sadhukhan wrote:
>>
>
> Sorry, Paolo, I got bit lost here :-). IIRC, you had two comments on
> this set:
>
> 1. kvm_valid_cr4() should be used for checking the reserved bits in
> guest CR4
>
> 2. LMA shouldn't be checked via guest state
>
> v3 has addressd your first suggestion by caching CR4 reserved bits in
> kvm_update_cpuid() and then using kvm_valid_cr4() in nested_vmcb_checks().
>
> As for your second suggestion, v3 uses is_long_mode() which uses
> vcpu->arch.efer for checking long mode.
>
> I will send out a rebased version.
>
> Is there anything I missed ?
Maybe Sean's comment here: https://patchwork.kernel.org/patch/11550707/
Paolo
prev parent reply other threads:[~2020-07-07 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 5:36 [PATCH 0/3 v3] KVM: nSVM: Check MBZ bits in CR3 and CR4 on vmrun of nested guests Krish Sadhukhan
2020-05-15 5:36 ` [PATCH 1/3 v3] KVM: x86: Create mask for guest CR4 reserved bits in kvm_update_cpuid() Krish Sadhukhan
2020-05-15 14:29 ` Sean Christopherson
2020-05-15 5:36 ` [PATCH 2/3 v3] KVM: nSVM: Check that MBZ bits in CR3 and CR4 are not set on vmrun of nested guests Krish Sadhukhan
2020-05-15 5:36 ` [PATCH 3/3 v3] KVM: nSVM: Test " Krish Sadhukhan
2020-07-02 22:33 ` [PATCH 0/3 v3] KVM: nSVM: Check MBZ bits in CR3 and CR4 " Krish Sadhukhan
2020-07-03 17:09 ` Paolo Bonzini
2020-07-03 17:11 ` Paolo Bonzini
2020-07-07 0:34 ` Krish Sadhukhan
2020-07-07 10:32 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=866d6456-314b-efbb-e46a-56e660c1c211@redhat.com \
--to=pbonzini@redhat.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.