All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] Armada100: Ethernet support for Marvell gplugD
Date: Fri, 8 Jul 2011 15:53:17 +0530 (IST)	[thread overview]
Message-ID: <867041231.46865.1310120597114.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <1773826644.46838.1310120108778.JavaMail.root@ahm.einfochips.com>

Dear Wolfgang,

Thanks for info, I have seen that. But i am not adding support for GPIO commands.

In reference to 

>> +#define GPLR(x)         GPIO_REG(BANK_OFF((x) >> 5) + 0x00)
>> +#define GPDR(x)         GPIO_REG(BANK_OFF((x) >> 5) + 0x0c)
>> +#define GPSR(x)         GPIO_REG(BANK_OFF((x) >> 5) + 0x18)
>> +#define GPCR(x)         GPIO_REG(BANK_OFF((x) >> 5) + 0x24)
>> +#define GSDR(x)         GPIO_REG(BANK_OFF((x) >> 5) + 0x54)
>> +#define GCDR(x)         GPIO_REG(BANK_OFF((x) >> 5) + 0x60)

> Please use a C struct to dsescribe the register layout.

I have followed similar way of using GPIO as used by "drivers/gpio/kw_gpio.c" and defined in "include/asm/arch-kirkwood/gpio.h",
so actually i am not adding GPIO support rather i wrote functions that are required by the Ethernet and other drivers.

Regards,
Ajay Bhargav

       reply	other threads:[~2011-07-08 10:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1773826644.46838.1310120108778.JavaMail.root@ahm.einfochips.com>
2011-07-08 10:23 ` Ajay Bhargav [this message]
2011-07-08 11:29   ` [U-Boot] [PATCH 1/4] Armada100: Ethernet support for Marvell gplugD Wolfgang Denk
     [not found] <422945680.47818.1310129034861.JavaMail.root@ahm.einfochips.com>
2011-07-08 12:48 ` Ajay Bhargav
2011-07-08 14:59   ` Prafulla Wadaskar
     [not found] <751999513.47571.1310126396909.JavaMail.root@ahm.einfochips.com>
2011-07-08 12:03 ` Ajay Bhargav
2011-07-08 12:39   ` Wolfgang Denk
     [not found] <1707892633.46126.1310116683428.JavaMail.root@ahm.einfochips.com>
2011-07-08  9:32 ` Ajay Bhargav
2011-07-08 10:17   ` Wolfgang Denk
2011-07-08 15:06     ` Prafulla Wadaskar
     [not found] <1361369926.45813.1310113039881.JavaMail.root@ahm.einfochips.com>
2011-07-08  8:17 ` Ajay Bhargav
2011-07-08  6:22 Ajay Bhargav
2011-07-08  7:47 ` Wolfgang Denk
2011-07-08 15:19 ` Prafulla Wadaskar
2011-07-11  4:42   ` Ajay Bhargav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867041231.46865.1310120597114.JavaMail.root@ahm.einfochips.com \
    --to=ajay.bhargav@einfochips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.