From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60A902E36ED; Wed, 6 Aug 2025 18:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754504270; cv=none; b=f40VD/TJT8yNqZVQ/QmaCU4Z94rurVne0Nsp78P1np0Dhw6YZ5IhI+Gz7TSup1f7+NI/2fGxL5WeTGw/2q+yRJd+wuIt1z/mzcBkBHKIiq3nrE9r76DQbgkfjK++sHElNTrEaqf0LuZErzKnGUbdjQoEpvcF+OrMhlQ8YtZfPgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754504270; c=relaxed/simple; bh=tVIrd2LQ/c5yfLuLbK0Jf7K+0CkcqrpV21ilXh3nK5k=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Qbh0yL8I0G/Xw3OOtjhQbsXcK6qrx4IhwL85/5XyU1RgQb32p8STomSt6IKRk6pfkSN/jRHFGS9IAMJKQO6ZQIs8jbmE+uKf9x2F8Zy2PgcucxZAHcPOrqilpUYn2bgTt81/xPuTg3GXedOEqGOxtixQWjyycjZHPypQdaZihQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rZfFaFrw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rZfFaFrw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCE12C4CEE7; Wed, 6 Aug 2025 18:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754504269; bh=tVIrd2LQ/c5yfLuLbK0Jf7K+0CkcqrpV21ilXh3nK5k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rZfFaFrwU6qL+9ZE0ASZ5cNSr6koitnX281KevotnTPKlJE233FzggbjHqabqwmzg 5NLhs5hKzeArAkmK/7swlRbw3dK4PZkemlJSZiqn3LQy870E/EJNjWrZ6gVE+Hp6c/ lBK8n57cR0dC2bu0geA4+XXbK9N6iiNGGiatGJz+N9uU9QLUYQxurXNo1z7YlL/Oxa Ee2qlKpw280FaqWBnqKOX0T4G4KrVEdVnc6keWFE9EsEzhcPFIm1WHm9R28DlcSQ3d L3CoTg+q0OAavRIy9f+KT2LgnEpDScREfHMGjerwd2DMJEdrJRzvNx6W1dqaX8gFYq y+oOJn3Fbwvhg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ujihv-004bCc-Ka; Wed, 06 Aug 2025 19:17:47 +0100 Date: Wed, 06 Aug 2025 19:17:47 +0100 Message-ID: <867bzg9uwk.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: Volodymyr Babchuk , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon Subject: Re: [PATCH v1 1/2] KVM: arm64: nv: fix S2 translation for nVHE guests In-Reply-To: References: <20250806141707.3479194-1-volodymyr_babchuk@epam.com> <20250806141707.3479194-2-volodymyr_babchuk@epam.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, Volodymyr_Babchuk@epam.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 06 Aug 2025 18:37:34 +0100, Oliver Upton wrote: > > Hi Volodymyr, > > Thanks for catching this. > > On Wed, Aug 06, 2025 at 02:17:55PM +0000, Volodymyr Babchuk wrote: > > According to ARM architecture specification (ARM DDI 0487 L.a, section > > C5.4.3), Stage 2 translation should be skipped when VHE is active, or, > > in other words, E2H bit is set. Fix the code by inverting both check > > and comment. > > > > Signed-off-by: Volodymyr Babchuk > > --- > > arch/arm64/kvm/at.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c > > index a25be111cd8f8..5e7c3fb01273c 100644 > > --- a/arch/arm64/kvm/at.c > > +++ b/arch/arm64/kvm/at.c > > @@ -1412,10 +1412,10 @@ void __kvm_at_s12(struct kvm_vcpu *vcpu, u32 op, u64 vaddr) > > return; > > > > /* > > - * If we only have a single stage of translation (E2H=0 or > > + * If we only have a single stage of translation (E2H=1 or > > * TGE=1), exit early. Same thing if {VM,DC}=={0,0}. > > */ > > - if (!vcpu_el2_e2h_is_set(vcpu) || vcpu_el2_tge_is_set(vcpu) || > > + if (vcpu_el2_e2h_is_set(vcpu) || vcpu_el2_tge_is_set(vcpu) || > > The check should be HCR_EL2. == '11'. Maybe instead: > > /* > * Exit early if we only have a single stage of translation > * either because we're in the EL2&0 translation regime or > * stage-2 translation is disabled (i.e. HCR_EL2.{VM,DC}=={0,0}). > */ > if (compute_translation_regime(vcpu, op) == TR_EL20 || > !(vcpu_read_sys_reg(vcpu, HCR_EL2) & (HCR_VM | HCR_DC))) > return; Ah, same solution, just way better written! Thanks, M. -- Without deviation from the norm, progress is not possible.