From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78DE5139CE2 for ; Tue, 22 Oct 2024 16:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729614472; cv=none; b=OJR7LiGCE+Vb4IUJFNMitHEm/6CvhfyXuklpDO9DaXquSYU6hnUDshbDayXq0ybjx3iU1hBQ7k5fcYigHL0pKMBG4qGOBIM+b16Xl/mIcHAa96F2L+6EXPJcKGqnW38WFWxstdwhkFDHS+wp7Uu+uLYO1AiB7nBHfqBgseyw204= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729614472; c=relaxed/simple; bh=aiaLk0/pYxMe+hy33ylobQlryXbKMQZQZGyeJfR0iyg=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=rFJgOREB06rfhp+NzhJMfXn2Nqbn5QlYrQs7vtn4wMld/1Qi/mwiGxHtErrGGuESyoSyBxd1CpJXNlb0RU7Rkc4/d5l8rvb4rr7NWBmOOys3DIIIsLmE/JuN71VgvJ2elDhiggq1VV0cknpURl77nOsc2mkDoPHry4J7AHtT0vA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oZRCNFU7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oZRCNFU7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 210A6C4CEC3; Tue, 22 Oct 2024 16:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729614472; bh=aiaLk0/pYxMe+hy33ylobQlryXbKMQZQZGyeJfR0iyg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oZRCNFU76ZfwpBQkEwWhaDAzfYg5xnxZ2uAx/TSukrfUHZhzhW3/hT+59kHqJVEUj ZunuepgyT2OUz8GaJLMTNByIpY7kcqA1RQtTl6Fzq9vgk45d2DHpmvgYV/NshkZFt6 hSeakjF9lf9RsxIOPK7lIXIKC5n520OtNdVk+uDMFqZS3Lk2fxMwp4MJucuEi0l0yE Y0E/qWnGtrvDRZbVOhpiyFm1Dp8uxVHJw8RzoYXWQ5EGGcNdw1yvlsTu//YNPkg/VB 4jWaJ8UvtyjiwexBeIifK3xbBihhef3n3hUmRXUlGDvaAGXj3iPRgoK7rw7cWLC+6W /Ba3XvjNQY5Vg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t3Hja-005qFN-3F; Tue, 22 Oct 2024 17:27:50 +0100 Date: Tue, 22 Oct 2024 17:27:48 +0100 Message-ID: <867ca03xx7.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, Oliver Upton , Joey Gouly , Fuad Tabba , kvmarm@lists.linux.dev Subject: Re: [PATCH 1/2] KVM: arm64: Just advertise SEIS as 0 when emulating ICC_CTLR_EL1 In-Reply-To: <20241022144016.27350-2-will@kernel.org> References: <20241022144016.27350-1-will@kernel.org> <20241022144016.27350-2-will@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, joey.gouly@arm.com, tabba@google.com, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 22 Oct 2024 15:40:15 +0100, Will Deacon wrote: > > ICC_CTLR_EL1 accesses from a guest are trapped and emulated on systems > with broken SEIS support and without FEAT_GICv3_TDIR. On such systems, > we mask SEIS support in 'kvm_vgic_global_state.ich_vtr_el2' and so the > value of ICC_CTLR_EL1.SEIS visible to the guest is always zero. > > Simplify the ICC_CTLR_EL1 read emulation to return 0 for the SEIS field, > rather than reading an always-zero value from the global state. > > Cc: Marc Zyngier > Cc: Oliver Upton > Signed-off-by: Will Deacon > --- > arch/arm64/kvm/hyp/vgic-v3-sr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/vgic-v3-sr.c b/arch/arm64/kvm/hyp/vgic-v3-sr.c > index 18d4677002b1..3f9741e51d41 100644 > --- a/arch/arm64/kvm/hyp/vgic-v3-sr.c > +++ b/arch/arm64/kvm/hyp/vgic-v3-sr.c > @@ -1012,9 +1012,6 @@ static void __vgic_v3_read_ctlr(struct kvm_vcpu *vcpu, u32 vmcr, int rt) > val = ((vtr >> 29) & 7) << ICC_CTLR_EL1_PRI_BITS_SHIFT; > /* IDbits */ > val |= ((vtr >> 23) & 7) << ICC_CTLR_EL1_ID_BITS_SHIFT; > - /* SEIS */ > - if (kvm_vgic_global_state.ich_vtr_el2 & ICH_VTR_SEIS_MASK) > - val |= BIT(ICC_CTLR_EL1_SEIS_SHIFT); > /* A3V */ > val |= ((vtr >> 21) & 1) << ICC_CTLR_EL1_A3V_SHIFT; > /* EOImode */ Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.