From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC67A14C59D for ; Tue, 27 Feb 2024 18:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709057920; cv=none; b=fINIucDbcPiFtOxtYp6iUTaZb4++nd6qRebBlkzYPSDAr+99HnjPPXIb+cYPmp14WxpM7Y6P5qDPfjJ6y3LDLrwHT8o5otM0hDzSYS5D4RsDDDJkO8J+EYGv1H8Xaz4WT/MDtcWC/1pD7hFoE0+P7owqURVRr7XNERF6BlWZroM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709057920; c=relaxed/simple; bh=qiEAxKzaK2EgDJCLqIEaZ/cT639kfZizVAJden8p1NQ=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=od11nGV7kjsDjiPj8mHiIyF993if1pfBFOH3OivUFNxCBSoC4R051bxZ1OAHHL/uhlXuEGCNjG+NNBxtE8If3nPVguZJWxoussJZYIRCewREZMoxHOdktbxUCPeUQdET9Rdh06x3PqSvFmUA5Rm8BKAYPXp6VRxXZeHkZKU31m8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SQ2EMDKw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SQ2EMDKw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27761C433F1; Tue, 27 Feb 2024 18:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709057920; bh=qiEAxKzaK2EgDJCLqIEaZ/cT639kfZizVAJden8p1NQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SQ2EMDKwaD86JqZAvycQxO60q6j7Dn4hQW8IWIeiIkvVInfFbfQ/JujsqJ9QP+moT 1FxxuwU7fjqLTaGi43sGQZGZIkmxSZKNd/bHb5rxPwDIUJaQohoVBPJWzf99lCg1Bi wcH4Q9jnhnbhIBwzrGRv+UpqPK6IRjq+8qKUjTUilIVNzPCseNl7HcBJDb1e1Q57iy cBfvSZdEiR62Xul/laK/OuKZhaiq8wsR/sWyTGx1ZD+8Ej9OcTDFXGB/vmlmG9enus BbdobUtSl20zjqP+s+aIpvVotP3h6HuDmqvdFtAbwO+0W8hCN5GiKCGHuHJvQbrfkg sIRNVyQKnHLQw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rf22H-007MCD-KA; Tue, 27 Feb 2024 18:18:37 +0000 Date: Tue, 27 Feb 2024 18:18:37 +0000 Message-ID: <867cip3h4y.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 0/2] KVM: arm64: Fix splat relating to idregs debugfs In-Reply-To: <20240227094115.1723330-1-oliver.upton@linux.dev> References: <20240227094115.1723330-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 27 Feb 2024 09:41:13 +0000, Oliver Upton wrote: > > Looks like we're calling in to debugfs w/ preemption disabled, which > explodes when trying to take the parent inode's rwsem. > > This is easy enough to work around, and we can just initialize at the > time of VM creation. No idreg values yet? Too bad, just kick an error > back at the user. All two of them. > > Applies to kvmarm/next. > > Oliver Upton (2): > KVM: arm64: Fail the idreg iterator if idregs aren't initialized > KVM: arm64: Don't initialize idreg debugfs w/ preemption disabled Thanks for tackling this! Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.