From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9E34C77B75 for ; Tue, 18 Apr 2023 08:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3AW7/SDCHEcTXhmPN/wMOPTNFwCKfe30SB2qbeiyr3s=; b=h1GB0SEZDGucmZ iK60NexT5COaA6TWYH2cGkeNpeEQ07jfD47BXehZ8yzwRXiyKQTTXSQb91IIcsVgzSQ4g0NXaMAaa yUFVfYbxNneH/9j/8HBGcGctLvjxgOCBTzckW9TD3aNYlckEfUVKnWa74X5aRdoYR70lNDN0Yen7P BcgqjFXksqUPByYt7XfKNn0pLVXMdgT9q18AYy7aQsRvk5nXLW7Rq3PyHAFZjKLBv7+/8sOXcFNlG eyDJvkPs+DQ0qj7s9r6umoHi6JWwfQ0o6/DMezqWw91MV21V89cil4K4UkRK8ZGUCzHsolIu8OKuw v4popaxx5YJLT98/PMnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poh53-001Nl6-20; Tue, 18 Apr 2023 08:52:53 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poh51-001Nk8-0S for linux-rockchip@lists.infradead.org; Tue, 18 Apr 2023 08:52:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 73552618EC; Tue, 18 Apr 2023 08:52:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1DD8C433EF; Tue, 18 Apr 2023 08:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681807969; bh=70xPBbsh44oN1k6erbly3OaVLsKVZbbBoVAm3vD2DdI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b8ll9dxckioE9A0c1+ZgHz+sHWGOxwF/CQfkqv1VmqjNAmoCZDkuWKmwqUVedQ+v0 a7dX0RBxjSeQ9/9nb24+CEmtwK2/4z9qHxJ63a5OAvLZhn9kc4LH9WghBgeSsBgW/V Ne2MD40ZYo0g/KsoVsVrBB8dwaHddXfpqhuCCYv6M7kLLxlZ1najAIcUl94MglNQq9 fDhroZE4J1O7KcGp5S7estYGZIwgHMmrXHKgDSGxFxViWWdu8Q2FLWYJJGIfzMXtS+ I9OH4KOoycgqvu23rmYmV2eLp9tGyUUr5yAKX8JyF8f2DBFOQrnm0LTtrda370YOPo qk3YHeQ+tRHhw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1poh4x-009FZV-Fa; Tue, 18 Apr 2023 09:52:47 +0100 Date: Tue, 18 Apr 2023 09:52:47 +0100 Message-ID: <867cu9lggw.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Reichel Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Thomas Gleixner , Peng Fan , Robin Murphy , Peter Geis , XiaoDong Huang , Kever Yang , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v3 1/2] irqchip/gic-v3: Add Rockchip 3588001 errata workaround In-Reply-To: <20230417214035.101190-2-sebastian.reichel@collabora.com> References: <20230417214035.101190-1-sebastian.reichel@collabora.com> <20230417214035.101190-2-sebastian.reichel@collabora.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebastian.reichel@collabora.com, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de, peng.fan@nxp.com, robin.murphy@arm.com, pgwipeout@gmail.com, derrick.huang@rock-chips.com, kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_015251_255020_53F67E5B X-CRM114-Status: GOOD ( 27.35 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, 17 Apr 2023 22:40:34 +0100, Sebastian Reichel wrote: > > Rockchip RK3588/RK3588s GIC600 integration does not support the > sharability feature. Rockchip assigned Errata ID #3588001 for this > issue. s/Errata/Erratum/ (here and in the subject). > > Note, that the 0x0201743b ID is not Rockchip specific and thus > there is an extra of_machine_is_compatible() check. > > The flag are named BROKEN_SHAREABILITY to be vendor agnostic, Either "the flag is" or "the flags are". > since apparently similar integration design errors exist in other > platforms and they can reuse the same flag. > > Co-developed-by: XiaoDong Huang > Signed-off-by: XiaoDong Huang > Co-developed-by: Kever Yang > Signed-off-by: Kever Yang > Co-developed-by: Lucas Tanure > Signed-off-by: Lucas Tanure > Signed-off-by: Sebastian Reichel > --- > Documentation/arm64/silicon-errata.rst | 3 +++ > arch/arm64/Kconfig | 10 ++++++++ > drivers/irqchip/irq-gic-v3-its.c | 35 ++++++++++++++++++++++++++ > 3 files changed, 48 insertions(+) > > diff --git a/Documentation/arm64/silicon-errata.rst b/Documentation/arm64/silicon-errata.rst > index ec5f889d7681..46d06ed3e4f4 100644 > --- a/Documentation/arm64/silicon-errata.rst > +++ b/Documentation/arm64/silicon-errata.rst > @@ -205,6 +205,9 @@ stable kernels. > +----------------+-----------------+-----------------+-----------------------------+ > | Qualcomm Tech. | Kryo4xx Gold | N/A | ARM64_ERRATUM_1286807 | > +----------------+-----------------+-----------------+-----------------------------+ > ++----------------+-----------------+-----------------+-----------------------------+ > +| Rockchip | RK3588 | #3588001 | ROCKCHIP_ERRATUM_3588001 | > ++----------------+-----------------+-----------------+-----------------------------+ > > +----------------+-----------------+-----------------+-----------------------------+ > | Fujitsu | A64FX | E#010001 | FUJITSU_ERRATUM_010001 | > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1023e896d46b..1bc43faef10a 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1150,6 +1150,16 @@ config NVIDIA_CARMEL_CNP_ERRATUM > > If unsure, say Y. > > +config ROCKCHIP_ERRATUM_3588001 > + bool "Rockchip 3588001: GIC600 can not support shareability attributes" > + default y > + help > + The Rockchip RK3588 GIC600 SoC integration does not support ACE/ACE-lite. > + This means, that the GIC600 may not use the GIC600 sharability feature This sentence makes little sense. It is the GIC driver that cannot make use of the shareability attributes. > + even though it is supported by the IP itself. > + > + If unsure, say Y. > + > config SOCIONEXT_SYNQUACER_PREITS > bool "Socionext Synquacer: Workaround for GICv3 pre-ITS" > default y > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 586271b8aa39..5b7aa48dde25 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -42,9 +42,11 @@ > #define ITS_FLAGS_CMDQ_NEEDS_FLUSHING (1ULL << 0) > #define ITS_FLAGS_WORKAROUND_CAVIUM_22375 (1ULL << 1) > #define ITS_FLAGS_WORKAROUND_CAVIUM_23144 (1ULL << 2) > +#define ITS_FLAGS_BROKEN_SHAREABILITY (1ULL << 3) Having slept on it, I'd rather this is renamed as "FORCE_NON_SHAREABLE", as it better describes what we are doing. The brokenness is an attribute of the platform, not of the flag. > > #define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) > #define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) > +#define RDIST_FLAGS_BROKEN_SHAREABILITY (1 << 2) Same thing here. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D4DC77B71 for ; Tue, 18 Apr 2023 08:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbjDRIww (ORCPT ); Tue, 18 Apr 2023 04:52:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbjDRIww (ORCPT ); Tue, 18 Apr 2023 04:52:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E083E1AD; Tue, 18 Apr 2023 01:52:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C7CA623D6; Tue, 18 Apr 2023 08:52:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1DD8C433EF; Tue, 18 Apr 2023 08:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681807969; bh=70xPBbsh44oN1k6erbly3OaVLsKVZbbBoVAm3vD2DdI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b8ll9dxckioE9A0c1+ZgHz+sHWGOxwF/CQfkqv1VmqjNAmoCZDkuWKmwqUVedQ+v0 a7dX0RBxjSeQ9/9nb24+CEmtwK2/4z9qHxJ63a5OAvLZhn9kc4LH9WghBgeSsBgW/V Ne2MD40ZYo0g/KsoVsVrBB8dwaHddXfpqhuCCYv6M7kLLxlZ1najAIcUl94MglNQq9 fDhroZE4J1O7KcGp5S7estYGZIwgHMmrXHKgDSGxFxViWWdu8Q2FLWYJJGIfzMXtS+ I9OH4KOoycgqvu23rmYmV2eLp9tGyUUr5yAKX8JyF8f2DBFOQrnm0LTtrda370YOPo qk3YHeQ+tRHhw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1poh4x-009FZV-Fa; Tue, 18 Apr 2023 09:52:47 +0100 Date: Tue, 18 Apr 2023 09:52:47 +0100 Message-ID: <867cu9lggw.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Reichel Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Thomas Gleixner , Peng Fan , Robin Murphy , Peter Geis , XiaoDong Huang , Kever Yang , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v3 1/2] irqchip/gic-v3: Add Rockchip 3588001 errata workaround In-Reply-To: <20230417214035.101190-2-sebastian.reichel@collabora.com> References: <20230417214035.101190-1-sebastian.reichel@collabora.com> <20230417214035.101190-2-sebastian.reichel@collabora.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebastian.reichel@collabora.com, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de, peng.fan@nxp.com, robin.murphy@arm.com, pgwipeout@gmail.com, derrick.huang@rock-chips.com, kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 17 Apr 2023 22:40:34 +0100, Sebastian Reichel wrote: > > Rockchip RK3588/RK3588s GIC600 integration does not support the > sharability feature. Rockchip assigned Errata ID #3588001 for this > issue. s/Errata/Erratum/ (here and in the subject). > > Note, that the 0x0201743b ID is not Rockchip specific and thus > there is an extra of_machine_is_compatible() check. > > The flag are named BROKEN_SHAREABILITY to be vendor agnostic, Either "the flag is" or "the flags are". > since apparently similar integration design errors exist in other > platforms and they can reuse the same flag. > > Co-developed-by: XiaoDong Huang > Signed-off-by: XiaoDong Huang > Co-developed-by: Kever Yang > Signed-off-by: Kever Yang > Co-developed-by: Lucas Tanure > Signed-off-by: Lucas Tanure > Signed-off-by: Sebastian Reichel > --- > Documentation/arm64/silicon-errata.rst | 3 +++ > arch/arm64/Kconfig | 10 ++++++++ > drivers/irqchip/irq-gic-v3-its.c | 35 ++++++++++++++++++++++++++ > 3 files changed, 48 insertions(+) > > diff --git a/Documentation/arm64/silicon-errata.rst b/Documentation/arm64/silicon-errata.rst > index ec5f889d7681..46d06ed3e4f4 100644 > --- a/Documentation/arm64/silicon-errata.rst > +++ b/Documentation/arm64/silicon-errata.rst > @@ -205,6 +205,9 @@ stable kernels. > +----------------+-----------------+-----------------+-----------------------------+ > | Qualcomm Tech. | Kryo4xx Gold | N/A | ARM64_ERRATUM_1286807 | > +----------------+-----------------+-----------------+-----------------------------+ > ++----------------+-----------------+-----------------+-----------------------------+ > +| Rockchip | RK3588 | #3588001 | ROCKCHIP_ERRATUM_3588001 | > ++----------------+-----------------+-----------------+-----------------------------+ > > +----------------+-----------------+-----------------+-----------------------------+ > | Fujitsu | A64FX | E#010001 | FUJITSU_ERRATUM_010001 | > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1023e896d46b..1bc43faef10a 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1150,6 +1150,16 @@ config NVIDIA_CARMEL_CNP_ERRATUM > > If unsure, say Y. > > +config ROCKCHIP_ERRATUM_3588001 > + bool "Rockchip 3588001: GIC600 can not support shareability attributes" > + default y > + help > + The Rockchip RK3588 GIC600 SoC integration does not support ACE/ACE-lite. > + This means, that the GIC600 may not use the GIC600 sharability feature This sentence makes little sense. It is the GIC driver that cannot make use of the shareability attributes. > + even though it is supported by the IP itself. > + > + If unsure, say Y. > + > config SOCIONEXT_SYNQUACER_PREITS > bool "Socionext Synquacer: Workaround for GICv3 pre-ITS" > default y > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 586271b8aa39..5b7aa48dde25 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -42,9 +42,11 @@ > #define ITS_FLAGS_CMDQ_NEEDS_FLUSHING (1ULL << 0) > #define ITS_FLAGS_WORKAROUND_CAVIUM_22375 (1ULL << 1) > #define ITS_FLAGS_WORKAROUND_CAVIUM_23144 (1ULL << 2) > +#define ITS_FLAGS_BROKEN_SHAREABILITY (1ULL << 3) Having slept on it, I'd rather this is renamed as "FORCE_NON_SHAREABLE", as it better describes what we are doing. The brokenness is an attribute of the platform, not of the flag. > > #define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) > #define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) > +#define RDIST_FLAGS_BROKEN_SHAREABILITY (1 << 2) Same thing here. Thanks, M. -- Without deviation from the norm, progress is not possible.