All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] efidebug: Introduce bootmgr command
Date: Wed, 10 Feb 2021 17:10:16 +0100	[thread overview]
Message-ID: <86821.1612973416@gemini.denx.de> (raw)
In-Reply-To: <YCPVvmnF7TKxreE2@apalos.home>

Dear Ilias,

In message <YCPVvmnF7TKxreE2@apalos.home> you wrote:
>
> > In this case, "debug" would just be a sub-command of the "efi"
> > command, with more sub-commands under efi (like bootmgr or such)
> > following, same as we did for example with "env" (where many
> > commands maintain backward compatibility, but here this was
> > necessary because these have been in use forever):
> > 
> > 	env print 	-> printenv
> > 	env save	-> saveenv
> > 	env set		-> setenv
> > 
>
> Yes, but it would still look a bit strange, because the efidebug command was
> overloaded in our case. So you could test capsules, set EFI bootmgr variables,
> dump EFI tables amongst other things. The saveenv & friends had a tightly
> defined scope already. 
> So that would require a lot of code to keep the convention running, but since 
> it's rarely used, I don't think it's worth the effort or the additional
> complexity (once again unless someone has a valid reason), hence my suggestion
> to define it properly while we still have time.

Indeed - if it was rarely used before, it makes a lot of sense to
break combined functionality into separate subcommands (probably
also with separate Kconfig options so you can select what you really
need only).

Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The biggest difference between time and space is that you can't reuse
time.                                                 - Merrick Furst

  reply	other threads:[~2021-02-10 16:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 10:54 [PATCH] efidebug: Introduce bootmgr command Ilias Apalodimas
2021-02-10 11:23 ` Wolfgang Denk
2021-02-10 11:53   ` Ilias Apalodimas
2021-02-10 12:26     ` Wolfgang Denk
2021-02-10 12:46       ` Ilias Apalodimas
2021-02-10 16:10         ` Wolfgang Denk [this message]
2021-02-10 12:50     ` AKASHI Takahiro
2021-02-10 14:59       ` Ilias Apalodimas
2021-02-10 12:53   ` Heinrich Schuchardt
2021-02-10 16:17     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86821.1612973416@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.