From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754743AbYIKAKM (ORCPT ); Wed, 10 Sep 2008 20:10:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752560AbYIKAJ5 (ORCPT ); Wed, 10 Sep 2008 20:09:57 -0400 Received: from mail.ocs.com.au ([202.134.241.204]:14631 "EHLO mail.ocs.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbYIKAJ4 (ORCPT ); Wed, 10 Sep 2008 20:09:56 -0400 X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-12) with nmh-1.2 From: Keith Owens To: David Miller cc: kaber@trash.net, linux-kernel@vger.kernel.org Subject: Re: Recent copy of libpcap from CVS In-reply-to: Your message of "Wed, 10 Sep 2008 16:59:31 MST." <20080910.165931.187028031.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 11 Sep 2008 10:09:55 +1000 Message-ID: <8686.1221091795@ocs10w> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller (on Wed, 10 Sep 2008 16:59:31 -0700 (PDT)) wrote: >From: Keith Owens >Date: Thu, 11 Sep 2008 09:57:08 +1000 > >> Comparing git://git.kernel.org/pub/scm/linux/kernel/git/davem/libpcap.git >> against Patrick's tarball. git is missing some mode and some rcsid >> lines like this example below, I assume that the removal of these lines >> in git was deliberate. > >Yes, look at the changesets in the tree, I did it. Removing the #ifndef lines also accidentally removed a copyright notice. diff -urp libpcap-0.9-PRE-CVS/filtertest.c libpcap/filtertest.c --- libpcap-0.9-PRE-CVS/filtertest.c 2007-10-11 16:56:22.000000000 +1000 +++ libpcap/filtertest.c 2008-09-11 09:45:20.148341971 +1000 @@ -19,14 +19,6 @@ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. */ -#ifndef lint -static const char copyright[] _U_ = - "@(#) Copyright (c) 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 2000\n\ -The Regents of the University of California. All rights reserved.\n"; -static const char rcsid[] _U_ = - "@(#) $Header: /tcpdump/master/libpcap/filtertest.c,v 1.2 2005/08/08 17:50:13 guy Exp $ (LBL)"; -#endif - #ifdef HAVE_CONFIG_H #include "config.h" #endif