From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274CA191F94; Wed, 30 Apr 2025 11:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746013003; cv=none; b=kRuGLnVOj/NNaq7JmxG68F9C8VsXlPLfkiGhAV6OEcC31K2aqyZyMBmcITulPkFGJAMn2YR9n0giPXjrGxteAysJE89mM1VXqPrIdEYRudZR4n4sZQFA+rTbUwcAZpz31TSnbVHKZUtqFJzH0oVVefifohOSV2clO1YC8ARF0Sg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746013003; c=relaxed/simple; bh=4h8cRpkZDTjCUV3PlrFF9/xj2YdTvuqBv2OPM3jesrE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=DUs4czFfZiZxzcp4EgQF5TtY2ZAeNYs3ypCZoSbWlOhB6abjNBW06vuIdocL9MSKlTF+NTZEPKoVAI11BStgVypLA4MjOpaFiCa9jrwpNyHVDxdXFGrFdvINznN8ap21WnfdBRrt9rtEQiWNJ4ItlluW/gcaALFFVAdTGNqt9qk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HfwWNZob; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HfwWNZob" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F46FC4CEE9; Wed, 30 Apr 2025 11:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746013002; bh=4h8cRpkZDTjCUV3PlrFF9/xj2YdTvuqBv2OPM3jesrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HfwWNZob8r29rO82ImMRt26pqXWwFB8Ro7yjJW2DsXaX68e7b14dflIAuhvIUI9D0 52gswgZVasMA2HTrjBKTfMdfF9RqPaf+GHmUjfuhQLVMWjwOOjuA5FNZ9KfvEQZ3+n 9V3D4Rp94FbMXUidpa61NnZfEXz5c7QFrt1wPwHeDp7YQpr4C0mzmiLI/MpsQDxfXb xPjWa1SPBMPdOnsEnDvM4pYRODDcQtrwRmgasc/2vPw7UcUqRbH66aTWc2w45W7iiZ vzUtTec1qxLW8sL+L6vjtsEHWFW7qbmdyIHqI/aPQj1YxSX79bizwooNhr7BWzVIHg OQftMQB/5WNgA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uA5k0-00AFy2-IX; Wed, 30 Apr 2025 12:36:40 +0100 Date: Wed, 30 Apr 2025 12:36:40 +0100 Message-ID: <868qnhj2yf.wl-maz@kernel.org> From: Marc Zyngier To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, dan.carpenter@linaro.org, johan@kernel.org, Johan Hovold Subject: Re: [PATCH v3 2/3] firmware: arm_scmi: Add Quirks framework In-Reply-To: References: <20250429141108.406045-1-cristian.marussi@arm.com> <20250429141108.406045-3-cristian.marussi@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: arm-scmi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: cristian.marussi@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, dan.carpenter@linaro.org, johan@kernel.org, johan+linaro@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 30 Apr 2025 08:54:06 +0100, Cristian Marussi wrote: > > On Tue, Apr 29, 2025 at 03:11:07PM +0100, Cristian Marussi wrote: > > Add a common framework to describe SCMI quirks and associate them with a > > specific platform or a specific set of SCMI firmware versions. > > > > All the matching SCMI quirks will be enabled when the SCMI core stack > > probes and after all the needed SCMI firmware versioning information was > > retrieved using Base protocol. > > > > Tested-by: Johan Hovold > > Signed-off-by: Cristian Marussi > > Hi > > just a quick remarks that a bot spotted the usage of __VA_OPT__ which is > only available since GCC >= 8.0 :< ... so I will probably revert to use the > previous, less clean, mechanism to build the NULL terminated array in > which the compats array WILL HAVE to be explicitly NULL terminated when > provided (even the empty ones...) See 20250407094116.1339199-1-arnd@kernel.org, which is slated for 6.16. The TL;DR is that GCC 8.1 and binutils 2.30 should be the minimal versions from 6.16 onwards. So it's probably not worth using ugly hacks that will eventually be reverted. Thanks, M. -- Without deviation from the norm, progress is not possible.