From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB52CC25B75 for ; Wed, 29 May 2024 12:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kkqAxbnJD/ktaDZX5muC7LiQeeZyOsBc6Q+kXipvH/Y=; b=Kzb0H2/aRhhVVm GtXKgRhJx8lAThVS3PGF3g3m1gL0tR/AcPgGY4Gf+rZjRHshuoTc0M0EgqiSFpo9kLos2y7T6b1uA AnHqDeFpSMVxF+8kF49aIDzplSIfjl1Uu4RzYdGnNUh8dIwrYxWNZQgzQ4DwpzqYP7ljv5o//y6HL KFUbELnZXC40ORCYWEOstFamlMLpdpx1zzc8sIWcugNw9sHQ/NS5Rf3Ed7Nxo+QJw8t+pzYM7NgOy G77/P5ufCUYx6j5YjJfi4PUtAxWDhyERCk6gJYXbkXJfpiKocGwfSGdd7FT6WJ03QmcUY76yTqfKS x67pi1/gAyNm+K60R8ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCHye-000000040nG-2muH; Wed, 29 May 2024 12:00:20 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCHyW-000000040ll-3h7l; Wed, 29 May 2024 12:00:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BE794CE16D9; Wed, 29 May 2024 12:00:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBB17C2BD10; Wed, 29 May 2024 12:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716984010; bh=EyHJZAlfUfFoMwS+HARXOClHpzjK5ZAZYlLEYoiymFk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cnZFyk7uPXr2aqnzVtroY/pLKTx3ypTWfEylu/mGo0tQjUQmsH2LAuO29OaSuXtIX 6WhMpEkhlKthfAFtB/jABhkLhnTSOTn+ieSJVl90cxc98rHLsMOQX10lOanqGBKLEQ 850Esq+iT6VyJtORv6DhLgZAjkFHqdv+xUplxWT9IPZp3/NwTJZVR0LycqnCnUKi7F I6pHgqTpRERwuzYZUULiAcBpQQxfLvjuZaY3SLoSS850Ro30QzdX+hmsJo9dyrAuu2 dJEplNbXC68N9oRSo3JCBzhQ/jaNfeRz186Xb7KV5pa4H6p1s3h0mc7zBy6kqAyfTF HfR04iCXvo8Zg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCHyR-00GbT6-Aq; Wed, 29 May 2024 13:00:07 +0100 Date: Wed, 29 May 2024 13:00:07 +0100 Message-ID: <868qzsn7zs.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> <86bk4pm8j1.wl-maz@kernel.org> <86a5k8nbh1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_050013_328729_DC4FCA64 X-CRM114-Status: GOOD ( 54.44 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBNYXkgMjAyNCAxMjoyODozNCArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIFdlZCwgTWF5IDI5LCAyMDI0IGF0IDQ6MTXi gK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBPbiBXZWQs IDI5IE1heSAyMDI0IDExOjE2OjMwICswMTAwLAo+ID4gQW51cCBQYXRlbCA8YXBhdGVsQHZlbnRh bmFtaWNyby5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBXZWQsIE1heSAyOSwgMjAyNCBhdCAx MjowM+KAr1BNIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+Cj4g PiA+ID4gT24gV2VkLCAyOSBNYXkgMjAyNCAwNjoxNTo1MiArMDEwMCwKPiA+ID4gPiBBbnVwIFBh dGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4g T24gVHVlLCBNYXkgMjgsIDIwMjQgYXQgMTA6MTHigK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJu ZWwub3JnPiB3cm90ZToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gQ29tbWl0IGQ5NzZjNmY0YjMy YyAoIm9mOiBwcm9wZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IKPiA+ID4gPiA+ID4g aW50ZXJydXB0LW1hcCBwcm9wZXJ0eSIpIHRyaWVkIHRvIGRvIHdoYXQgaXQgc2F5cyBvbiB0aGUg dGluLAo+ID4gPiA+ID4gPiBidXQgZmFpbGVkIG9uIGEgY291cGxlIG9mIHBvaW50czoKPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gLSBpdCBjb25mdXNlcyBieXRlcyBhbmQgY2VsbHMuIE5vdCBhIGh1 Z2UgZGVhbCwgZXhjZXB0IHdoZW4gaXQKPiA+ID4gPiA+ID4gICBjb21lcyB0byBwb2ludGVyIGFy aXRobWV0aWMKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gLSBpdCBkb2Vzbid0IHJlYWxseSBoYW5k bGUgYW55dGhpbmcgYnV0IGludGVycnVwdC1tYXBzIHRoYXQgaGF2ZQo+ID4gPiA+ID4gPiAgIHRo ZWlyIHBhcmVudCAjYWRkcmVzcy1jZWxscyBzZXQgdG8gMAo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiBUaGUgY29tYmluYXRpb25zIG9mIHRoZSB0d28gbGVhZHMgdG8gc29tZSBzZXJpb3VzIGZ1biBv biBteSBNMQo+ID4gPiA+ID4gPiBib3gsIHdpdGggcGxlbnR5IG9mIFdBUk4tT04oKSBmaXJpbmcg YWxsIG92ZXIgdGhlIHNob3AsIGFuZAo+ID4gPiA+ID4gPiBhbXVzaW5nIHZhbHVlcyBiZWluZyBn ZW5lcmF0ZWQgZm9yIGludGVycnVwdCBzcGVjaWZpZXJzLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiBBZGRyZXNzIGJvdGggaXNzdWVzIHNvIHRoYXQgSSBjYW4gYm9vdCBteSBtYWNoaW5lcyBhZ2Fp bi4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gRml4ZXM6IGQ5NzZjNmY0YjMyYyAoIm9mOiBwcm9w ZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IgaW50ZXJydXB0LW1hcCBwcm9wZXJ0eSIp Cj4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+ Cj4gPiA+ID4gPiA+IENjOiBBbnVwIFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4KPiA+ ID4gPiA+ID4gQ2M6IFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2dsZS5jb20+Cj4gPiA+ ID4gPiA+IENjOiBSb2IgSGVycmluZyAoQXJtKSA8cm9iaEBrZXJuZWwub3JnPgo+ID4gPiA+ID4K PiA+ID4gPiA+IFRoYW5rcyBmb3IgdGhlIGZpeCBwYXRjaCBidXQgdW5mb3J0dW5hdGVseSBpdCBi cmVha3MgZm9yIFJJU0MtVi4KPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiAg ZHJpdmVycy9vZi9wcm9wZXJ0eS5jIHwgMTYgKysrKysrKysrKysrKystLQo+ID4gPiA+ID4gPiAg MSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+ID4g PiA+Cj4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29mL3Byb3BlcnR5LmMgYi9kcml2 ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4gPiA+ID4gaW5kZXggMWM4M2U2OGY4MDViLi45YWRlYmM2 M2JlYTkgMTAwNjQ0Cj4gPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvb2YvcHJvcGVydHkuYwo+ID4g PiA+ID4gPiArKysgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4gPiA+ID4gQEAgLTEzMjIs NyArMTMyMiwxMyBAQCBzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlICpwYXJzZV9pbnRlcnJ1cHRf bWFwKHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsCj4gPiA+ID4gPiA+ICAgICAgICAgYWRkcmNlbGxz ID0gb2ZfYnVzX25fYWRkcl9jZWxscyhucCk7Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ICAgICAg ICAgaW1hcCA9IG9mX2dldF9wcm9wZXJ0eShucCwgImludGVycnVwdC1tYXAiLCAmaW1hcGxlbik7 Cj4gPiA+ID4gPiA+IC0gICAgICAgaWYgKCFpbWFwIHx8IGltYXBsZW4gPD0gKGFkZHJjZWxscyAr IGludGNlbGxzKSkKPiA+ID4gPiA+ID4gKyAgICAgICBpbWFwbGVuIC89IHNpemVvZigqaW1hcCk7 Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKyAgICAgICAvKgo+ID4gPiA+ID4gPiArICAgICAg ICAqIENoZWNrIHRoYXQgd2UgaGF2ZSBlbm91Z2ggcnVud2F5IGZvciB0aGUgY2hpbGQgdW5pdCBp bnRlcnJ1cHQKPiA+ID4gPiA+ID4gKyAgICAgICAgKiBzcGVjaWZpZXIgYW5kIGEgcGhhbmRsZS4g VGhhdCdzIHRoZSBiYXJlIG1pbmltdW0gd2UgY2FuIGV4cGVjdC4KPiA+ID4gPiA+ID4gKyAgICAg ICAgKi8KPiA+ID4gPiA+ID4gKyAgICAgICBpZiAoIWltYXAgfHwgaW1hcGxlbiA8PSAoYWRkcmNl bGxzICsgaW50Y2VsbHMgKyAxKSkKPiA+ID4gPiA+ID4gICAgICAgICAgICAgICAgIHJldHVybiBO VUxMOwo+ID4gPiA+ID4gPiAgICAgICAgIGltYXBfZW5kID0gaW1hcCArIGltYXBsZW47Cj4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+IEBAIC0xMzQ2LDggKzEzNTIsMTQgQEAgc3RhdGljIHN0cnVjdCBk ZXZpY2Vfbm9kZSAqcGFyc2VfaW50ZXJydXB0X21hcChzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wLAo+ ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgaWYgKCFpbmRleCkKPiA+ID4gPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgcmV0dXJuIHN1cF9hcmdzLm5wOwo+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiAtICAgICAgICAgICAgICAgb2Zfbm9kZV9wdXQoc3VwX2FyZ3MubnApOwo+ID4gPiA+ID4g PiArICAgICAgICAgICAgICAgLyoKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAqIEFjY291 bnQgZm9yIHRoZSBmdWxsIHBhcmVudCB1bml0IGludGVycnVwdCBzcGVjaWZpZXIKPiA+ID4gPiA+ ID4gKyAgICAgICAgICAgICAgICAqIChhZGRyZXNzIGNlbGxzLCBpbnRlcnJ1cHQgY2VsbHMsIGFu ZCBwaGFuZGxlKS4KPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAqLwo+ID4gPiA+ID4gPiAr ICAgICAgICAgICAgICAgaW1hcCArPSBvZl9idXNfbl9hZGRyX2NlbGxzKHN1cF9hcmdzLm5wKTsK PiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGlzIGJyZWFrcyBmb3IgUklTQy1WIGJlY2F1c2Ugd2UgZG9u J3QgaGF2ZSAiI2FkZHJlc3MtY2VsbHMiCj4gPiA+ID4gPiBwcm9wZXJ0eSBpbiBpbnRlcnJ1cHQg Y29udHJvbGxlciBEVCBub2RlIGFuZCBvZl9idXNfbl9hZGRyX2NlbGxzKCkKPiA+ID4gPiA+IHJl dHJpZXZlcyAiI2FkZHJlc3MtY2VsbHMiIGZyb20gdGhlIHBhcmVudCBvZiBpbnRlcnJ1cHQgY29u dHJvbGxlci4KPiA+ID4gPgo+ID4gPiA+IFRoYXQncyBhIGZlYXR1cmUsIG5vdCBhIGJ1Zy4gI2Fk ZHJlc3MtY2VsbHMsIEFGQUlDVCwgYXBwbGllcyB0byBhbGwKPiA+ID4gPiBjaGlsZCBub2RlcyB1 bnRpbCB5b3Ugc2V0IGl0IG90aGVyd2lzZS4KPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+IFRo ZSBvZl9pcnFfcGFyc2VfcmF3KCkgbG9va3MgZm9yICIjYWRkcmVzcy1jZWxscyIgcHJvcGVydHkK PiA+ID4gPiA+IGluIHRoZSBpbnRlcnJ1cHQgY29udHJvbGxlciBEVCBub2RlIG9ubHkgc28gd2Ug c2hvdWxkIGRvIGEKPiA+ID4gPiA+IHNpbWlsYXIgdGhpbmcgaGVyZSBhcyB3ZWxsLgo+ID4gPiA+ Cj4gPiA+ID4gVGhpcyBsb29rcyBtb3JlIGxpa2UgYSBvZl9pcnFfcGFyc2VfcmF3KCkgYnVnIHRo YW4gYW55dGhpbmcgZWxzZS4KPiA+ID4KPiA+ID4gSWYgd2UgY2hhbmdlIG9mX2lycV9wYXJzZV9y YXcoKSB0byB1c2Ugb2ZfYnVzX25fYWRkcl9jZWxscygpCj4gPiA+IHRoZW4gaXQgd291bGQgc3Rp bGwgYnJlYWsgZm9yIFJJU0MtVi4KPiA+Cj4gPiBJJ20gbm90IHRyeWluZyB0byAiZml4IiByaXNj di4gSSdtIG1lcmVseSBvdXRsaW5pbmcgdGhhdCB5b3UgYXJlCj4gPiByZWx5aW5nIG9uIGJvdGgg YnJva2VuIERUcyBhbmQgYSBidWdneSBPUy4KPiA+Cj4gPiA+Cj4gPiA+IFVzaW5nIG9mX2J1c19u X2FkZHJfY2VsbHMoKSBvdmVyIGhlcmUgZm9yY2VzIGludGVycnVwdCBjb250cm9sbGVyCj4gPiA+ IERUIG5vZGVzIHRvIGhhdmUgYSAiI2FkZHJlc3MtY2VsbHMiIERUIHByb3BlcnR5LiBUaGVyZSBh cmUgbWFueQo+ID4gPiBpbnRlcnJ1cHQgY29udHJvbGxlciAoZS5nLiBSSVNDLVYgUExJQyBvciBS SVNDLVYgQVBMSUMpIHdoZXJlIHRoZQo+ID4gPiBEVCBiaW5kaW5ncyBkb24ndCByZXF1aXJlICIj YWRkcmVzcy1jZWxscyIgRFQgcHJvcGVydHkgYW5kIGV4aXN0aW5nCj4gPiA+IERUUyBmaWxlcyB3 aXRoIHN1Y2ggaW50ZXJydXB0IGNvbnRyb2xsZXJzIGRvbid0IGhhdmUgaXQgZWl0aGVyLgo+ID4K PiA+IEl0IGZvcmNlcyB5b3UgdG8gc2V0ICNhZGRyZXNzLWNlbGxzICppZiB5b3UgcmVseSBvbiBh IGRpZmZlcmVudAo+ID4gdmFsdWUgaW4gYSBjaGlsZCBub2RlKi4gSXQncyBub3QgbGlrZSB0aGUg c2VtYW50aWNzIGFyZSBuZXcuCj4gCj4gV2UgZG9uJ3QgaGF2ZSBjaGlsZCBub2RlcyB1bmRlciB0 aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgRFQgbm9kZQo+IChmb3IgYm90aCBSSVNDLVYgUExJQyBh bmQgQVBMSUMpIHNvIHdlIGNlcnRhaW5seSBkb24ndCByZXF1aXJlIHRoZQo+ICIjYWRkcmVzcy1j ZWxscyIgcHJvcGVydHkgaW4gdGhlIGludGVycnVwdCBjb250cm9sbGVyIERUIG5vZGUuCgpZb3Ug a2VlcCBtaXNzaW5nIHRoZSBwb2ludC4KCllvdSAqZG8qIHJlcXVpcmUgaXQgaWYgdGhlIHBhcmVu dCBub2RlIGhhcyBhbiAjYWRkcmVzcy1jZWxscyB2YWx1ZQp0aGF0IGRvZXNuJ3QgYXBwbHkgdG8g aXRzIGNoaWxkcmVuIG5vZGVzLiBCYXNpYyBwcm9wZXJ0eSBpbmhlcml0YW5jZS4KSW50ZXJydXB0 IGNvbnRyb2xsZXIgbm9kZXMgYXJlIG5vdCBzcGVjaWFsIGluIHRoaXMgcmVnYXJkIChhbmQgcGxl YXNlCmFsbG93IG1lIHRvIHRoaW5rIHRoYXQgSSBrbm93IGEgdGhpbmcgb3IgdHdvIGFib3V0IHRo b3NlKS4KClNvIGl0J3Mgbm90IHRoYXQgInlvdSBkb24ndCBuZWVkIGl0Ii4gSXQncyB0aGF0ICJ5 b3UncmUgcmVseWluZyBvbgpzb21ldGhpbmcgdGhhdCBpcyBicm9rZW4iLgoKQnV0IGluIHlvdXIg ZGVmZW5jZSwgdGhlIERUIHNwZWMgaXMgYW11c2luZ2x5IHNlbGYtY29udHJhZGljdG9yeToKCjxx dW90ZT4KMi4zLjUuICNhZGRyZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscwoKVGhlICNhZGRyZXNz LWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBwcm9wZXJ0aWVzIG1heSBiZSB1c2VkIGluIGFueQpkZXZp Y2Ugbm9kZSB0aGF0IGhhcyBjaGlsZHJlbiBpbiB0aGUgZGV2aWNldHJlZSBoaWVyYXJjaHkgYW5k CmRlc2NyaWJlcyBob3cgY2hpbGQgZGV2aWNlIG5vZGVzIHNob3VsZCBiZSBhZGRyZXNzZWQuIFRo ZQojYWRkcmVzcy1jZWxscyBwcm9wZXJ0eSBkZWZpbmVzIHRoZSBudW1iZXIgb2YgPHUzMj4gY2Vs bHMgdXNlZCB0bwplbmNvZGUgdGhlIGFkZHJlc3MgZmllbGQgaW4gYSBjaGlsZCBub2Rl4oCZcyBy ZWcgcHJvcGVydHkuIFRoZQojc2l6ZS1jZWxscyBwcm9wZXJ0eSBkZWZpbmVzIHRoZSBudW1iZXIg b2YgPHUzMj4gY2VsbHMgdXNlZCB0byBlbmNvZGUKdGhlIHNpemUgZmllbGQgaW4gYSBjaGlsZCBu b2Rl4oCZcyByZWcgcHJvcGVydHkuCgpUaGUgI2FkZHJlc3MtY2VsbHMgYW5kICNzaXplLWNlbGxz IHByb3BlcnRpZXMgYXJlIG5vdCBpbmhlcml0ZWQgZnJvbQphbmNlc3RvcnMgaW4gdGhlIGRldmlj ZXRyZWUuIFRoZXkgc2hhbGwgYmUgZXhwbGljaXRseSBkZWZpbmVkLgo8L3F1b3RlPgoKRm9sbG93 ZWQgYnk6Cgo8cXVvdGU+CjIuNC4zLjEuIGludGVycnVwdC1tYXAKCk5vdGUKCkJvdGggdGhlIGNo aWxkIG5vZGUgYW5kIHRoZSBpbnRlcnJ1cHQgcGFyZW50IG5vZGUgYXJlIHJlcXVpcmVkIHRvIGhh dmUKI2FkZHJlc3MtY2VsbHMgYW5kICNpbnRlcnJ1cHQtY2VsbHMgcHJvcGVydGllcyBkZWZpbmVk LiBJZiBhIHVuaXQKYWRkcmVzcyBjb21wb25lbnQgaXMgbm90IHJlcXVpcmVkLCAjYWRkcmVzcy1j ZWxscyBzaGFsbCBiZSBleHBsaWNpdGx5CmRlZmluZWQgdG8gYmUgemVyby4KPC9xdW90ZT4KCndo aWNoIHNheXMgb25lIHRoaW5nIGFuZCB0aGVuIHRoZSBvdGhlciBhYm91dCBwcm9wZXJ0eSBpbmhl cml0YW5jZSwKYnV0IHRoZW4gYXNzZXJ0cyB0aGF0ICNhZGRyZXNzLWNlbGxzIGlzbid0IG9wdGlv bmFsLgoKPiA+Cj4gPiA+Cj4gPiA+IEluIHRoZSBSSVNDLVYgd29ybGQsIHRoZXJlIGhhdmUgYmVl biBxdWl0ZSBhIGZldyBRRU1VIHJlbGVhc2VzCj4gPiA+IHdoZXJlIHRoZSBnZW5lcmF0ZWQgRFQg bm9kZSBvZiB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgZG9lcyBub3QKPiA+ID4gaGF2ZSB0aGUg IiNhZGRyZXNzLWNlbGxzIiBwcm9wZXJ0eS4gVGhpcyBwYXRjaCBicmVha3MgdGhlIGtlcm5lbAo+ ID4gPiBmb3IgYWxsIHN1Y2ggUUVNVSByZWxlYXNlcy4KPiA+Cj4gPiBDb25ncmF0dWxhdGlvbnMs IHlvdSd2ZSBmb3JrZWQgRFQuIE5ld3MgYXQgMTEuCj4gCj4gQ2FuIHlvdSBlbGFib3JhdGUgaG93 ID8KCllvdSd2ZSBzdGF0ZWQgaXQgeW91cnNlbGYuIFlvdSBhcmUgcmVseWluZyBvbiBhIGJlaGF2 aW91ciB0aGF0CmRldmlhdGVzIGZyb20gdGhlIHN0YW5kYXJkIGJ5IGhhdmluZyBEVHMgd2l0aCBt aXNzaW5nIHByb3BlcnRpZXMKCkFuZCBzaW5jZSB3ZSBjYW4ndCB0cmF2ZWwgYmFjayBpdCB0aW1l IHRvIGZpeCB0aGlzLCB0aGUgb25seSBzb2x1dGlvbgpJIGNhbiBzZWUgaXMgdG8gc3VwcG9ydCBi b3RoIGJlaGF2aW91cnMgYnkgcXVpcmtpbmcgaXQuCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlv biBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxp c3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA25EC27C43 for ; Wed, 29 May 2024 12:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qQnzqrwUYA3psE6uU4THPzMJzdVHxS2HhD8rHbRB7w8=; b=g/0DMks4qn6/4J mWdW6cSp9FllD5DRPn7yR8WtTiUEE6WyoNtMaOs751u69C6ZLp0OS6IeToqSeR0X0TPBmiDNtWecJ tITeJ9Kd6uIMITGSrFcsAYM3FhBDTpGzjDWrq7qgPtMVtYki/biWr1hg2aDsUkJ4Z4pNCy7zps9Q+ JRVRemSG0BdFuFaSGWnszjxpFH81hIvdKgEAdR1QtEhEJPnWGYCIRNRzkxs4kRgLXwIhRXqtDAOVG E5aXJXLQEcTavRCDPCWPxDgyMD6VppxD2uBj1qDNUPBuENLOLJDXCjAc/Edum+tDlQXhnLsydRKv0 Rn1c2MmpEHPSQTt+16Bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCHye-000000040n9-0Fif; Wed, 29 May 2024 12:00:20 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCHyW-000000040ll-3h7l; Wed, 29 May 2024 12:00:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BE794CE16D9; Wed, 29 May 2024 12:00:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBB17C2BD10; Wed, 29 May 2024 12:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716984010; bh=EyHJZAlfUfFoMwS+HARXOClHpzjK5ZAZYlLEYoiymFk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cnZFyk7uPXr2aqnzVtroY/pLKTx3ypTWfEylu/mGo0tQjUQmsH2LAuO29OaSuXtIX 6WhMpEkhlKthfAFtB/jABhkLhnTSOTn+ieSJVl90cxc98rHLsMOQX10lOanqGBKLEQ 850Esq+iT6VyJtORv6DhLgZAjkFHqdv+xUplxWT9IPZp3/NwTJZVR0LycqnCnUKi7F I6pHgqTpRERwuzYZUULiAcBpQQxfLvjuZaY3SLoSS850Ro30QzdX+hmsJo9dyrAuu2 dJEplNbXC68N9oRSo3JCBzhQ/jaNfeRz186Xb7KV5pa4H6p1s3h0mc7zBy6kqAyfTF HfR04iCXvo8Zg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCHyR-00GbT6-Aq; Wed, 29 May 2024 13:00:07 +0100 Date: Wed, 29 May 2024 13:00:07 +0100 Message-ID: <868qzsn7zs.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> <86bk4pm8j1.wl-maz@kernel.org> <86a5k8nbh1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_050013_328729_DC4FCA64 X-CRM114-Status: GOOD ( 54.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBNYXkgMjAyNCAxMjoyODozNCArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIFdlZCwgTWF5IDI5LCAyMDI0IGF0IDQ6MTXi gK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBPbiBXZWQs IDI5IE1heSAyMDI0IDExOjE2OjMwICswMTAwLAo+ID4gQW51cCBQYXRlbCA8YXBhdGVsQHZlbnRh bmFtaWNyby5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBXZWQsIE1heSAyOSwgMjAyNCBhdCAx MjowM+KAr1BNIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+Cj4g PiA+ID4gT24gV2VkLCAyOSBNYXkgMjAyNCAwNjoxNTo1MiArMDEwMCwKPiA+ID4gPiBBbnVwIFBh dGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4g T24gVHVlLCBNYXkgMjgsIDIwMjQgYXQgMTA6MTHigK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJu ZWwub3JnPiB3cm90ZToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gQ29tbWl0IGQ5NzZjNmY0YjMy YyAoIm9mOiBwcm9wZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IKPiA+ID4gPiA+ID4g aW50ZXJydXB0LW1hcCBwcm9wZXJ0eSIpIHRyaWVkIHRvIGRvIHdoYXQgaXQgc2F5cyBvbiB0aGUg dGluLAo+ID4gPiA+ID4gPiBidXQgZmFpbGVkIG9uIGEgY291cGxlIG9mIHBvaW50czoKPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gLSBpdCBjb25mdXNlcyBieXRlcyBhbmQgY2VsbHMuIE5vdCBhIGh1 Z2UgZGVhbCwgZXhjZXB0IHdoZW4gaXQKPiA+ID4gPiA+ID4gICBjb21lcyB0byBwb2ludGVyIGFy aXRobWV0aWMKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gLSBpdCBkb2Vzbid0IHJlYWxseSBoYW5k bGUgYW55dGhpbmcgYnV0IGludGVycnVwdC1tYXBzIHRoYXQgaGF2ZQo+ID4gPiA+ID4gPiAgIHRo ZWlyIHBhcmVudCAjYWRkcmVzcy1jZWxscyBzZXQgdG8gMAo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiBUaGUgY29tYmluYXRpb25zIG9mIHRoZSB0d28gbGVhZHMgdG8gc29tZSBzZXJpb3VzIGZ1biBv biBteSBNMQo+ID4gPiA+ID4gPiBib3gsIHdpdGggcGxlbnR5IG9mIFdBUk4tT04oKSBmaXJpbmcg YWxsIG92ZXIgdGhlIHNob3AsIGFuZAo+ID4gPiA+ID4gPiBhbXVzaW5nIHZhbHVlcyBiZWluZyBn ZW5lcmF0ZWQgZm9yIGludGVycnVwdCBzcGVjaWZpZXJzLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiBBZGRyZXNzIGJvdGggaXNzdWVzIHNvIHRoYXQgSSBjYW4gYm9vdCBteSBtYWNoaW5lcyBhZ2Fp bi4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gRml4ZXM6IGQ5NzZjNmY0YjMyYyAoIm9mOiBwcm9w ZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IgaW50ZXJydXB0LW1hcCBwcm9wZXJ0eSIp Cj4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+ Cj4gPiA+ID4gPiA+IENjOiBBbnVwIFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4KPiA+ ID4gPiA+ID4gQ2M6IFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2dsZS5jb20+Cj4gPiA+ ID4gPiA+IENjOiBSb2IgSGVycmluZyAoQXJtKSA8cm9iaEBrZXJuZWwub3JnPgo+ID4gPiA+ID4K PiA+ID4gPiA+IFRoYW5rcyBmb3IgdGhlIGZpeCBwYXRjaCBidXQgdW5mb3J0dW5hdGVseSBpdCBi cmVha3MgZm9yIFJJU0MtVi4KPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiAg ZHJpdmVycy9vZi9wcm9wZXJ0eS5jIHwgMTYgKysrKysrKysrKysrKystLQo+ID4gPiA+ID4gPiAg MSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+ID4g PiA+Cj4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29mL3Byb3BlcnR5LmMgYi9kcml2 ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4gPiA+ID4gaW5kZXggMWM4M2U2OGY4MDViLi45YWRlYmM2 M2JlYTkgMTAwNjQ0Cj4gPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvb2YvcHJvcGVydHkuYwo+ID4g PiA+ID4gPiArKysgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4gPiA+ID4gQEAgLTEzMjIs NyArMTMyMiwxMyBAQCBzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlICpwYXJzZV9pbnRlcnJ1cHRf bWFwKHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsCj4gPiA+ID4gPiA+ICAgICAgICAgYWRkcmNlbGxz ID0gb2ZfYnVzX25fYWRkcl9jZWxscyhucCk7Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ICAgICAg ICAgaW1hcCA9IG9mX2dldF9wcm9wZXJ0eShucCwgImludGVycnVwdC1tYXAiLCAmaW1hcGxlbik7 Cj4gPiA+ID4gPiA+IC0gICAgICAgaWYgKCFpbWFwIHx8IGltYXBsZW4gPD0gKGFkZHJjZWxscyAr IGludGNlbGxzKSkKPiA+ID4gPiA+ID4gKyAgICAgICBpbWFwbGVuIC89IHNpemVvZigqaW1hcCk7 Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKyAgICAgICAvKgo+ID4gPiA+ID4gPiArICAgICAg ICAqIENoZWNrIHRoYXQgd2UgaGF2ZSBlbm91Z2ggcnVud2F5IGZvciB0aGUgY2hpbGQgdW5pdCBp bnRlcnJ1cHQKPiA+ID4gPiA+ID4gKyAgICAgICAgKiBzcGVjaWZpZXIgYW5kIGEgcGhhbmRsZS4g VGhhdCdzIHRoZSBiYXJlIG1pbmltdW0gd2UgY2FuIGV4cGVjdC4KPiA+ID4gPiA+ID4gKyAgICAg ICAgKi8KPiA+ID4gPiA+ID4gKyAgICAgICBpZiAoIWltYXAgfHwgaW1hcGxlbiA8PSAoYWRkcmNl bGxzICsgaW50Y2VsbHMgKyAxKSkKPiA+ID4gPiA+ID4gICAgICAgICAgICAgICAgIHJldHVybiBO VUxMOwo+ID4gPiA+ID4gPiAgICAgICAgIGltYXBfZW5kID0gaW1hcCArIGltYXBsZW47Cj4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+IEBAIC0xMzQ2LDggKzEzNTIsMTQgQEAgc3RhdGljIHN0cnVjdCBk ZXZpY2Vfbm9kZSAqcGFyc2VfaW50ZXJydXB0X21hcChzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wLAo+ ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgaWYgKCFpbmRleCkKPiA+ID4gPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgcmV0dXJuIHN1cF9hcmdzLm5wOwo+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiAtICAgICAgICAgICAgICAgb2Zfbm9kZV9wdXQoc3VwX2FyZ3MubnApOwo+ID4gPiA+ID4g PiArICAgICAgICAgICAgICAgLyoKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAqIEFjY291 bnQgZm9yIHRoZSBmdWxsIHBhcmVudCB1bml0IGludGVycnVwdCBzcGVjaWZpZXIKPiA+ID4gPiA+ ID4gKyAgICAgICAgICAgICAgICAqIChhZGRyZXNzIGNlbGxzLCBpbnRlcnJ1cHQgY2VsbHMsIGFu ZCBwaGFuZGxlKS4KPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAqLwo+ID4gPiA+ID4gPiAr ICAgICAgICAgICAgICAgaW1hcCArPSBvZl9idXNfbl9hZGRyX2NlbGxzKHN1cF9hcmdzLm5wKTsK PiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGlzIGJyZWFrcyBmb3IgUklTQy1WIGJlY2F1c2Ugd2UgZG9u J3QgaGF2ZSAiI2FkZHJlc3MtY2VsbHMiCj4gPiA+ID4gPiBwcm9wZXJ0eSBpbiBpbnRlcnJ1cHQg Y29udHJvbGxlciBEVCBub2RlIGFuZCBvZl9idXNfbl9hZGRyX2NlbGxzKCkKPiA+ID4gPiA+IHJl dHJpZXZlcyAiI2FkZHJlc3MtY2VsbHMiIGZyb20gdGhlIHBhcmVudCBvZiBpbnRlcnJ1cHQgY29u dHJvbGxlci4KPiA+ID4gPgo+ID4gPiA+IFRoYXQncyBhIGZlYXR1cmUsIG5vdCBhIGJ1Zy4gI2Fk ZHJlc3MtY2VsbHMsIEFGQUlDVCwgYXBwbGllcyB0byBhbGwKPiA+ID4gPiBjaGlsZCBub2RlcyB1 bnRpbCB5b3Ugc2V0IGl0IG90aGVyd2lzZS4KPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+IFRo ZSBvZl9pcnFfcGFyc2VfcmF3KCkgbG9va3MgZm9yICIjYWRkcmVzcy1jZWxscyIgcHJvcGVydHkK PiA+ID4gPiA+IGluIHRoZSBpbnRlcnJ1cHQgY29udHJvbGxlciBEVCBub2RlIG9ubHkgc28gd2Ug c2hvdWxkIGRvIGEKPiA+ID4gPiA+IHNpbWlsYXIgdGhpbmcgaGVyZSBhcyB3ZWxsLgo+ID4gPiA+ Cj4gPiA+ID4gVGhpcyBsb29rcyBtb3JlIGxpa2UgYSBvZl9pcnFfcGFyc2VfcmF3KCkgYnVnIHRo YW4gYW55dGhpbmcgZWxzZS4KPiA+ID4KPiA+ID4gSWYgd2UgY2hhbmdlIG9mX2lycV9wYXJzZV9y YXcoKSB0byB1c2Ugb2ZfYnVzX25fYWRkcl9jZWxscygpCj4gPiA+IHRoZW4gaXQgd291bGQgc3Rp bGwgYnJlYWsgZm9yIFJJU0MtVi4KPiA+Cj4gPiBJJ20gbm90IHRyeWluZyB0byAiZml4IiByaXNj di4gSSdtIG1lcmVseSBvdXRsaW5pbmcgdGhhdCB5b3UgYXJlCj4gPiByZWx5aW5nIG9uIGJvdGgg YnJva2VuIERUcyBhbmQgYSBidWdneSBPUy4KPiA+Cj4gPiA+Cj4gPiA+IFVzaW5nIG9mX2J1c19u X2FkZHJfY2VsbHMoKSBvdmVyIGhlcmUgZm9yY2VzIGludGVycnVwdCBjb250cm9sbGVyCj4gPiA+ IERUIG5vZGVzIHRvIGhhdmUgYSAiI2FkZHJlc3MtY2VsbHMiIERUIHByb3BlcnR5LiBUaGVyZSBh cmUgbWFueQo+ID4gPiBpbnRlcnJ1cHQgY29udHJvbGxlciAoZS5nLiBSSVNDLVYgUExJQyBvciBS SVNDLVYgQVBMSUMpIHdoZXJlIHRoZQo+ID4gPiBEVCBiaW5kaW5ncyBkb24ndCByZXF1aXJlICIj YWRkcmVzcy1jZWxscyIgRFQgcHJvcGVydHkgYW5kIGV4aXN0aW5nCj4gPiA+IERUUyBmaWxlcyB3 aXRoIHN1Y2ggaW50ZXJydXB0IGNvbnRyb2xsZXJzIGRvbid0IGhhdmUgaXQgZWl0aGVyLgo+ID4K PiA+IEl0IGZvcmNlcyB5b3UgdG8gc2V0ICNhZGRyZXNzLWNlbGxzICppZiB5b3UgcmVseSBvbiBh IGRpZmZlcmVudAo+ID4gdmFsdWUgaW4gYSBjaGlsZCBub2RlKi4gSXQncyBub3QgbGlrZSB0aGUg c2VtYW50aWNzIGFyZSBuZXcuCj4gCj4gV2UgZG9uJ3QgaGF2ZSBjaGlsZCBub2RlcyB1bmRlciB0 aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgRFQgbm9kZQo+IChmb3IgYm90aCBSSVNDLVYgUExJQyBh bmQgQVBMSUMpIHNvIHdlIGNlcnRhaW5seSBkb24ndCByZXF1aXJlIHRoZQo+ICIjYWRkcmVzcy1j ZWxscyIgcHJvcGVydHkgaW4gdGhlIGludGVycnVwdCBjb250cm9sbGVyIERUIG5vZGUuCgpZb3Ug a2VlcCBtaXNzaW5nIHRoZSBwb2ludC4KCllvdSAqZG8qIHJlcXVpcmUgaXQgaWYgdGhlIHBhcmVu dCBub2RlIGhhcyBhbiAjYWRkcmVzcy1jZWxscyB2YWx1ZQp0aGF0IGRvZXNuJ3QgYXBwbHkgdG8g aXRzIGNoaWxkcmVuIG5vZGVzLiBCYXNpYyBwcm9wZXJ0eSBpbmhlcml0YW5jZS4KSW50ZXJydXB0 IGNvbnRyb2xsZXIgbm9kZXMgYXJlIG5vdCBzcGVjaWFsIGluIHRoaXMgcmVnYXJkIChhbmQgcGxl YXNlCmFsbG93IG1lIHRvIHRoaW5rIHRoYXQgSSBrbm93IGEgdGhpbmcgb3IgdHdvIGFib3V0IHRo b3NlKS4KClNvIGl0J3Mgbm90IHRoYXQgInlvdSBkb24ndCBuZWVkIGl0Ii4gSXQncyB0aGF0ICJ5 b3UncmUgcmVseWluZyBvbgpzb21ldGhpbmcgdGhhdCBpcyBicm9rZW4iLgoKQnV0IGluIHlvdXIg ZGVmZW5jZSwgdGhlIERUIHNwZWMgaXMgYW11c2luZ2x5IHNlbGYtY29udHJhZGljdG9yeToKCjxx dW90ZT4KMi4zLjUuICNhZGRyZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscwoKVGhlICNhZGRyZXNz LWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBwcm9wZXJ0aWVzIG1heSBiZSB1c2VkIGluIGFueQpkZXZp Y2Ugbm9kZSB0aGF0IGhhcyBjaGlsZHJlbiBpbiB0aGUgZGV2aWNldHJlZSBoaWVyYXJjaHkgYW5k CmRlc2NyaWJlcyBob3cgY2hpbGQgZGV2aWNlIG5vZGVzIHNob3VsZCBiZSBhZGRyZXNzZWQuIFRo ZQojYWRkcmVzcy1jZWxscyBwcm9wZXJ0eSBkZWZpbmVzIHRoZSBudW1iZXIgb2YgPHUzMj4gY2Vs bHMgdXNlZCB0bwplbmNvZGUgdGhlIGFkZHJlc3MgZmllbGQgaW4gYSBjaGlsZCBub2Rl4oCZcyBy ZWcgcHJvcGVydHkuIFRoZQojc2l6ZS1jZWxscyBwcm9wZXJ0eSBkZWZpbmVzIHRoZSBudW1iZXIg b2YgPHUzMj4gY2VsbHMgdXNlZCB0byBlbmNvZGUKdGhlIHNpemUgZmllbGQgaW4gYSBjaGlsZCBu b2Rl4oCZcyByZWcgcHJvcGVydHkuCgpUaGUgI2FkZHJlc3MtY2VsbHMgYW5kICNzaXplLWNlbGxz IHByb3BlcnRpZXMgYXJlIG5vdCBpbmhlcml0ZWQgZnJvbQphbmNlc3RvcnMgaW4gdGhlIGRldmlj ZXRyZWUuIFRoZXkgc2hhbGwgYmUgZXhwbGljaXRseSBkZWZpbmVkLgo8L3F1b3RlPgoKRm9sbG93 ZWQgYnk6Cgo8cXVvdGU+CjIuNC4zLjEuIGludGVycnVwdC1tYXAKCk5vdGUKCkJvdGggdGhlIGNo aWxkIG5vZGUgYW5kIHRoZSBpbnRlcnJ1cHQgcGFyZW50IG5vZGUgYXJlIHJlcXVpcmVkIHRvIGhh dmUKI2FkZHJlc3MtY2VsbHMgYW5kICNpbnRlcnJ1cHQtY2VsbHMgcHJvcGVydGllcyBkZWZpbmVk LiBJZiBhIHVuaXQKYWRkcmVzcyBjb21wb25lbnQgaXMgbm90IHJlcXVpcmVkLCAjYWRkcmVzcy1j ZWxscyBzaGFsbCBiZSBleHBsaWNpdGx5CmRlZmluZWQgdG8gYmUgemVyby4KPC9xdW90ZT4KCndo aWNoIHNheXMgb25lIHRoaW5nIGFuZCB0aGVuIHRoZSBvdGhlciBhYm91dCBwcm9wZXJ0eSBpbmhl cml0YW5jZSwKYnV0IHRoZW4gYXNzZXJ0cyB0aGF0ICNhZGRyZXNzLWNlbGxzIGlzbid0IG9wdGlv bmFsLgoKPiA+Cj4gPiA+Cj4gPiA+IEluIHRoZSBSSVNDLVYgd29ybGQsIHRoZXJlIGhhdmUgYmVl biBxdWl0ZSBhIGZldyBRRU1VIHJlbGVhc2VzCj4gPiA+IHdoZXJlIHRoZSBnZW5lcmF0ZWQgRFQg bm9kZSBvZiB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgZG9lcyBub3QKPiA+ID4gaGF2ZSB0aGUg IiNhZGRyZXNzLWNlbGxzIiBwcm9wZXJ0eS4gVGhpcyBwYXRjaCBicmVha3MgdGhlIGtlcm5lbAo+ ID4gPiBmb3IgYWxsIHN1Y2ggUUVNVSByZWxlYXNlcy4KPiA+Cj4gPiBDb25ncmF0dWxhdGlvbnMs IHlvdSd2ZSBmb3JrZWQgRFQuIE5ld3MgYXQgMTEuCj4gCj4gQ2FuIHlvdSBlbGFib3JhdGUgaG93 ID8KCllvdSd2ZSBzdGF0ZWQgaXQgeW91cnNlbGYuIFlvdSBhcmUgcmVseWluZyBvbiBhIGJlaGF2 aW91ciB0aGF0CmRldmlhdGVzIGZyb20gdGhlIHN0YW5kYXJkIGJ5IGhhdmluZyBEVHMgd2l0aCBt aXNzaW5nIHByb3BlcnRpZXMKCkFuZCBzaW5jZSB3ZSBjYW4ndCB0cmF2ZWwgYmFjayBpdCB0aW1l IHRvIGZpeCB0aGlzLCB0aGUgb25seSBzb2x1dGlvbgpJIGNhbiBzZWUgaXMgdG8gc3VwcG9ydCBi b3RoIGJlaGF2aW91cnMgYnkgcXVpcmtpbmcgaXQuCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlv biBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5FF13F43E; Wed, 29 May 2024 12:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716984010; cv=none; b=dRn50aK2zmSW3lUcqhtthp8vJJzsf4VQIpHIbt3LJ1tAyHka+0z5o24P6HPTmYnCBZKDPiDNEN1sFdWjL/AkKsJAjapdVhKzJkMTWYtvdYsp+yDGYA+L3Yg/lSufdeGemACcPntw/n4RPTEYsm8Q0zbjtAHxpRSSH0B/GHo/zB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716984010; c=relaxed/simple; bh=EyHJZAlfUfFoMwS+HARXOClHpzjK5ZAZYlLEYoiymFk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=IS/WZ8F1r5Ms9Zc3HstO6IXfurU2IhV2nv9Epl5bVwX3nWQEXqNGFrrTZJAnUSqZ9zhUFjXyOX+rNgdXRLvlA6uiXauGP5v2TVIStuSKTr47cXb+UHpS+wiM55h5Hld/73itfftJZ8XZa2PbaRA4NEWg972tQMG4vBANcAuutpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cnZFyk7u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cnZFyk7u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBB17C2BD10; Wed, 29 May 2024 12:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716984010; bh=EyHJZAlfUfFoMwS+HARXOClHpzjK5ZAZYlLEYoiymFk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cnZFyk7uPXr2aqnzVtroY/pLKTx3ypTWfEylu/mGo0tQjUQmsH2LAuO29OaSuXtIX 6WhMpEkhlKthfAFtB/jABhkLhnTSOTn+ieSJVl90cxc98rHLsMOQX10lOanqGBKLEQ 850Esq+iT6VyJtORv6DhLgZAjkFHqdv+xUplxWT9IPZp3/NwTJZVR0LycqnCnUKi7F I6pHgqTpRERwuzYZUULiAcBpQQxfLvjuZaY3SLoSS850Ro30QzdX+hmsJo9dyrAuu2 dJEplNbXC68N9oRSo3JCBzhQ/jaNfeRz186Xb7KV5pa4H6p1s3h0mc7zBy6kqAyfTF HfR04iCXvo8Zg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCHyR-00GbT6-Aq; Wed, 29 May 2024 13:00:07 +0100 Date: Wed, 29 May 2024 13:00:07 +0100 Message-ID: <868qzsn7zs.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> <86bk4pm8j1.wl-maz@kernel.org> <86a5k8nbh1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 29 May 2024 12:28:34 +0100, Anup Patel wrote: >=20 > On Wed, May 29, 2024 at 4:15=E2=80=AFPM Marc Zyngier wro= te: > > > > On Wed, 29 May 2024 11:16:30 +0100, > > Anup Patel wrote: > > > > > > On Wed, May 29, 2024 at 12:03=E2=80=AFPM Marc Zyngier wrote: > > > > > > > > On Wed, 29 May 2024 06:15:52 +0100, > > > > Anup Patel wrote: > > > > > > > > > > On Tue, May 28, 2024 at 10:11=E2=80=AFPM Marc Zyngier wrote: > > > > > > > > > > > > Commit d976c6f4b32c ("of: property: Add fw_devlink support for > > > > > > interrupt-map property") tried to do what it says on the tin, > > > > > > but failed on a couple of points: > > > > > > > > > > > > - it confuses bytes and cells. Not a huge deal, except when it > > > > > > comes to pointer arithmetic > > > > > > > > > > > > - it doesn't really handle anything but interrupt-maps that have > > > > > > their parent #address-cells set to 0 > > > > > > > > > > > > The combinations of the two leads to some serious fun on my M1 > > > > > > box, with plenty of WARN-ON() firing all over the shop, and > > > > > > amusing values being generated for interrupt specifiers. > > > > > > > > > > > > Address both issues so that I can boot my machines again. > > > > > > > > > > > > Fixes: d976c6f4b32c ("of: property: Add fw_devlink support for = interrupt-map property") > > > > > > Signed-off-by: Marc Zyngier > > > > > > Cc: Anup Patel > > > > > > Cc: Saravana Kannan > > > > > > Cc: Rob Herring (Arm) > > > > > > > > > > Thanks for the fix patch but unfortunately it breaks for RISC-V. > > > > > > > > > > > --- > > > > > > drivers/of/property.c | 16 ++++++++++++++-- > > > > > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > > > > index 1c83e68f805b..9adebc63bea9 100644 > > > > > > --- a/drivers/of/property.c > > > > > > +++ b/drivers/of/property.c > > > > > > @@ -1322,7 +1322,13 @@ static struct device_node *parse_interru= pt_map(struct device_node *np, > > > > > > addrcells =3D of_bus_n_addr_cells(np); > > > > > > > > > > > > imap =3D of_get_property(np, "interrupt-map", &imaplen); > > > > > > - if (!imap || imaplen <=3D (addrcells + intcells)) > > > > > > + imaplen /=3D sizeof(*imap); > > > > > > + > > > > > > + /* > > > > > > + * Check that we have enough runway for the child unit = interrupt > > > > > > + * specifier and a phandle. That's the bare minimum we = can expect. > > > > > > + */ > > > > > > + if (!imap || imaplen <=3D (addrcells + intcells + 1)) > > > > > > return NULL; > > > > > > imap_end =3D imap + imaplen; > > > > > > > > > > > > @@ -1346,8 +1352,14 @@ static struct device_node *parse_interru= pt_map(struct device_node *np, > > > > > > if (!index) > > > > > > return sup_args.np; > > > > > > > > > > > > - of_node_put(sup_args.np); > > > > > > + /* > > > > > > + * Account for the full parent unit interrupt s= pecifier > > > > > > + * (address cells, interrupt cells, and phandle= ). > > > > > > + */ > > > > > > + imap +=3D of_bus_n_addr_cells(sup_args.np); > > > > > > > > > > This breaks for RISC-V because we don't have "#address-cells" > > > > > property in interrupt controller DT node and of_bus_n_addr_cells() > > > > > retrieves "#address-cells" from the parent of interrupt controlle= r. > > > > > > > > That's a feature, not a bug. #address-cells, AFAICT, applies to all > > > > child nodes until you set it otherwise. > > > > > > > > > > > > > > The of_irq_parse_raw() looks for "#address-cells" property > > > > > in the interrupt controller DT node only so we should do a > > > > > similar thing here as well. > > > > > > > > This looks more like a of_irq_parse_raw() bug than anything else. > > > > > > If we change of_irq_parse_raw() to use of_bus_n_addr_cells() > > > then it would still break for RISC-V. > > > > I'm not trying to "fix" riscv. I'm merely outlining that you are > > relying on both broken DTs and a buggy OS. > > > > > > > > Using of_bus_n_addr_cells() over here forces interrupt controller > > > DT nodes to have a "#address-cells" DT property. There are many > > > interrupt controller (e.g. RISC-V PLIC or RISC-V APLIC) where the > > > DT bindings don't require "#address-cells" DT property and existing > > > DTS files with such interrupt controllers don't have it either. > > > > It forces you to set #address-cells *if you rely on a different > > value in a child node*. It's not like the semantics are new. >=20 > We don't have child nodes under the interrupt controller DT node > (for both RISC-V PLIC and APLIC) so we certainly don't require the > "#address-cells" property in the interrupt controller DT node. You keep missing the point. You *do* require it if the parent node has an #address-cells value that doesn't apply to its children nodes. Basic property inheritance. Interrupt controller nodes are not special in this regard (and please allow me to think that I know a thing or two about those). So it's not that "you don't need it". It's that "you're relying on something that is broken". But in your defence, the DT spec is amusingly self-contradictory: 2.3.5. #address-cells and #size-cells The #address-cells and #size-cells properties may be used in any device node that has children in the devicetree hierarchy and describes how child device nodes should be addressed. The #address-cells property defines the number of cells used to encode the address field in a child node=E2=80=99s reg property. The #size-cells property defines the number of cells used to encode the size field in a child node=E2=80=99s reg property. The #address-cells and #size-cells properties are not inherited from ancestors in the devicetree. They shall be explicitly defined. Followed by: 2.4.3.1. interrupt-map Note Both the child node and the interrupt parent node are required to have #address-cells and #interrupt-cells properties defined. If a unit address component is not required, #address-cells shall be explicitly defined to be zero. which says one thing and then the other about property inheritance, but then asserts that #address-cells isn't optional. > > > > > > > > In the RISC-V world, there have been quite a few QEMU releases > > > where the generated DT node of the interrupt controller does not > > > have the "#address-cells" property. This patch breaks the kernel > > > for all such QEMU releases. > > > > Congratulations, you've forked DT. News at 11. >=20 > Can you elaborate how ? You've stated it yourself. You are relying on a behaviour that deviates from the standard by having DTs with missing properties And since we can't travel back it time to fix this, the only solution I can see is to support both behaviours by quirking it. M. --=20 Without deviation from the norm, progress is not possible.