From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 215A5C001B0 for ; Mon, 17 Jul 2023 08:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SY2NWnhPuJ45nx9QCbi+ImBipKL5Hp3QFPnIzWasjic=; b=YO5t4IJyAd4Tvd hzPR+soIZbsGbQWuWKZ9txlr4dajT6ow8Xg8cViO++1kflXO8dXFVZhC1b2J6dgTqqRnctEoAvkgO h8Byf5F+PuVblNH6VEViUMh9gYYT+88d1CqC05X7Kiw6xISqjT0H0wZlupj4oA2mX74Q0TZCrwuNN 4TO4IHGLu1KZjX++KOka5oQscjkFj4ZSrIvBY0mLF0NLCiQPuA4ymEG1MNYbCdhtGcWmpQ0iaT55H y7B0O0Orqgs1wEkjm5V9oDWyYqKDKcwW6Iomw+5wGG1C1KH0Qkxf8hYmWtvYUmWXmUbPvPU4ENWzT yBBe55z1gprSl4KecdNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qLJFK-003PEi-2L; Mon, 17 Jul 2023 08:06:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLJEl-003P55-22 for linux-riscv@lists.infradead.org; Mon, 17 Jul 2023 08:06:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A0F9660FB5; Mon, 17 Jul 2023 08:05:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7566C433C7; Mon, 17 Jul 2023 08:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689581142; bh=46YRuhlRY7c+LYecTNMxpUt1Pqhr6LxrNXXMX9FblS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YJ9ZPNl69moiTL72CtguPknDitu9OYCgTsJ1oohTyF1xD9D7scok/HBn6g558ydmr w4J9kIB46QEYnPH7PTmfVhWc8q1e9RJEM0Np66ZpYP2TDUP31ncREtXa1DjX4N26q0 YNN48134XAQBpEo2sP2oJ/JF8P7Ng8qH8/NfV46yHBna/6mt0UTf7Lo9EpzK/7M71f 8lw1cZ+h/x1jPmSy9kaPPSw2CUwHDsCggyT/MavGe1bpqhyJQwmV8Iic3ZBvwqctyX rRLK0naXMu4oKGp5TwUws64y3gKY+xyaxZstv5By2W2eXn4geCQd9R/JmE/OytHXz5 akddHBScOHDWA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qLJEf-00Df2M-Oo; Mon, 17 Jul 2023 09:05:39 +0100 Date: Mon, 17 Jul 2023 09:05:37 +0100 Message-ID: <868rbfufn2.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Subject: Re: [PATCH v5 7/9] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230710094321.1378351-1-apatel@ventanamicro.com> <20230710094321.1378351-8-apatel@ventanamicro.com> <86jzv2vpdb.wl-maz@kernel.org> <86cz0uvcof.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anup@brainfault.org, apatel@ventanamicro.com, saravanak@google.com, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, atishp@atishpatra.org, ajones@ventanamicro.com, sunilvl@ventanamicro.com, conor@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230717_010543_766801_C9F34EE9 X-CRM114-Status: GOOD ( 62.33 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , devicetree@vger.kernel.org, Saravana Kannan , Atish Patra , linux-kernel@vger.kernel.org, Conor Dooley , Rob Herring , Palmer Dabbelt , Krzysztof Kozlowski , Paul Walmsley , Thomas Gleixner , linux-riscv@lists.infradead.org, Andrew Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxNCBKdWwgMjAyMyAxNTowNTowNyArMDEwMCwKQW51cCBQYXRlbCA8YW51cEBicmFp bmZhdWx0Lm9yZz4gd3JvdGU6Cj4gCj4gT24gRnJpLCBKdWwgMTQsIDIwMjMgYXQgNzowNeKAr1BN IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgMTQg SnVsIDIwMjMgMTA6MzU6MzQgKzAxMDAsCj4gPiBBbnVwIFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1p Y3JvLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIEZyaSwgSnVsIDE0LCAyMDIzIGF0IDI6MzHi gK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+ IEFudXAsCj4gPiA+ID4KPiA+ID4gPiBPbiBGcmksIDE0IEp1bCAyMDIzIDAwOjU2OjIyICswMTAw LAo+ID4gPiA+IFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2dsZS5jb20+IHdyb3RlOgo+ ID4gPiA+ID4KPiA+ID4gPiA+IE9uIE1vbiwgSnVsIDEwLCAyMDIzIGF0IDI6NDTigK9BTSBBbnVw IFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+IFRoZSBSSVNDLVYgYWR2YW5jZWQgaW50ZXJydXB0IGFyY2hpdGVjdHVyZSAoQUlBKSBz cGVjaWZpY2F0aW9uIGRlZmluZXMKPiA+ID4gPiA+ID4gYSBuZXcgaW50ZXJydXB0IGNvbnRyb2xs ZXIgZm9yIG1hbmFnaW5nIHdpcmVkIGludGVycnVwdHMgb24gYSBSSVNDLVYKPiA+ID4gPiA+ID4g cGxhdGZvcm0uIFRoaXMgbmV3IGludGVycnVwdCBjb250cm9sbGVyIGlzIHJlZmVycmVkIHRvIGFz IGFkdmFuY2VkCj4gPiA+ID4gPiA+IHBsYXRmb3JtLWxldmVsIGludGVycnVwdCBjb250cm9sbGVy IChBUExJQykgd2hpY2ggY2FuIGZvcndhcmQgd2lyZWQKPiA+ID4gPiA+ID4gaW50ZXJydXB0cyB0 byBDUFVzIChvciBIQVJUcykgYXMgbG9jYWwgaW50ZXJydXB0cyBPUiBhcyBtZXNzYWdlCj4gPiA+ ID4gPiA+IHNpZ25hbGVkIGludGVycnVwdHMuCj4gPiA+ID4gPiA+IChGb3IgbW9yZSBkZXRhaWxz IHJlZmVyIGh0dHBzOi8vZ2l0aHViLmNvbS9yaXNjdi9yaXNjdi1haWEpCj4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+IFRoaXMgcGF0Y2ggYWRkcyBhbiBpcnFjaGlwIGRyaXZlciBmb3IgUklTQy1WIEFQ TElDIGZvdW5kIG9uIFJJU0MtVgo+ID4gPiA+ID4gPiBwbGF0Zm9ybXMuCj4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEFudXAgUGF0ZWwgPGFwYXRlbEB2ZW50YW5hbWljcm8u Y29tPgo+ID4gPiA+Cj4gPiA+ID4gWy4uLl0KPiA+ID4gPgo+ID4gPiA+ID4gPiArc3RhdGljIGlu dCBfX2luaXQgYXBsaWNfZHRfaW5pdChzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUsCj4gPiA+ID4g PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRldmljZV9ub2RlICpw YXJlbnQpCj4gPiA+ID4gPiA+ICt7Cj4gPiA+ID4gPiA+ICsgICAgICAgLyoKPiA+ID4gPiA+ID4g KyAgICAgICAgKiBUaGUgQVBMSUMgcGxhdGZvcm0gZHJpdmVyIG5lZWRzIHRvIGJlIHByb2JlZCBl YXJseQo+ID4gPiA+ID4gPiArICAgICAgICAqIHNvIGZvciBkZXZpY2UgdHJlZToKPiA+ID4gPiA+ ID4gKyAgICAgICAgKgo+ID4gPiA+ID4gPiArICAgICAgICAqIDEpIFNldCB0aGUgRldOT0RFX0ZM QUdfQkVTVF9FRkZPUlQgZmxhZyBpbiBmd25vZGUgd2hpY2gKPiA+ID4gPiA+ID4gKyAgICAgICAg KiAgICBwcm92aWRlcyBhIGhpbnQgdG8gdGhlIGRldmljZSBkcml2ZXIgY29yZSB0byBwcm9iZSB0 aGUKPiA+ID4gPiA+ID4gKyAgICAgICAgKiAgICBwbGF0Zm9ybSBkcml2ZXIgZWFybHkuCj4gPiA+ ID4gPiA+ICsgICAgICAgICogMikgQ2xlYXIgdGhlIE9GX1BPUFVMQVRFRCBmbGFnIGluIGRldmlj ZV9ub2RlIGJlY2F1c2UKPiA+ID4gPiA+ID4gKyAgICAgICAgKiAgICBvZl9pcnFfaW5pdCgpIHNl dHMgaXQgd2hpY2ggcHJldmVudHMgY3JlYXRpb24gb2YKPiA+ID4gPiA+ID4gKyAgICAgICAgKiAg ICBwbGF0Zm9ybSBkZXZpY2UuCj4gPiA+ID4gPiA+ICsgICAgICAgICovCj4gPiA+ID4gPiA+ICsg ICAgICAgbm9kZS0+Zndub2RlLmZsYWdzIHw9IEZXTk9ERV9GTEFHX0JFU1RfRUZGT1JUOwo+ID4g PiA+ID4KPiA+ID4gPiA+IFBsZWFzZSBzdG9wIHNwYW1taW5nIHVzIHdpdGggYnJva2VuIHBhdGNo ZXMuIEFscmVhZHkgdG9sZCB5b3UgdGhpcyBpcwo+ID4gPiA+ID4gbm90IGFuIG9wdGlvbi4KPiA+ ID4gPiA+Cj4gPiA+ID4gPiBOYWNrLgo+ID4gPiA+Cj4gPiA+ID4gV2hhdCBwdXp6bGVzIG1lIGhl cmUgaXMgdGhhdCAqbm8gb3RoZXIgYXJjaCogcmVxdWlyZXMgdGhpcyBzb3J0IG9mCj4gPiA+ID4g aGFjay4gV2hhdCBpcyBzbyBzcGVjaWFsIGFib3V0IHRoZSBBUExJQyB0aGF0IGl0IHJlcXVpcmVz IGl0PyBJIHNlZQo+ID4gPiA+IG5vdGhpbmcgaW4gdGhpcyBwYXRjaCB0aGF0IGV2ZW4gaGludHMg YXQgaXQsIGRlc3BpdGUgdGhlICJkaXNjdXNzaW9uIgo+ID4gPiA+IGluIHRoZSBsYXN0IHJvdW5k Lgo+ID4gPiA+Cj4gPiA+ID4gVGhlIHJ1bGVzIGFyZSBzaW1wbGU6Cj4gPiA+ID4KPiA+ID4gPiAt IGVpdGhlciB0aGUgQVBMSUMgaXMgc28gZnVuZGFtZW50YWwgdG8gdGhlIHN5c3RlbSB0aGF0IGl0 IGhhcyB0byBiZQo+ID4gPiA+ICAgaW5pdGlhbGlzZWQgc3VwZXIgZWFybHksIG11Y2ggbGlrZSB0 aGUgR0lDIG9uIGFybTY0LCBhdCB3aGljaCBwb2ludAo+ID4gPiA+ICAgaXQgY2Fubm90IGJlIGEg cGxhdGZvcm0gZGV2aWNlLCBhbmQgdGhlIHN0b3J5IGlzIHByZXR0eSBzaW1wbGUuCj4gPiA+ID4K PiA+ID4gPiAtIG9yIGl0IGlzbid0IHRoYXQgZnVuZGFtZW50YWwsIGFuZCBpdCBjYW4gYmUgcHJv YmVkIGFzIGEgcGxhdGZvcm0KPiA+ID4gPiAgIGRldmljZSB1c2luZyB0aGUgZGVwZW5kZW5jeSBp bmZyYXN0cnVjdHVyZSB0aGF0IGlzIGFscmVhZHkgdXNlZCBieQo+ID4gPiA+ICAgbXVsdGlwbGUg b3RoZXIgaW50ZXJydXB0IGNvbnRyb2xsZXIgZHJpdmVycywgd2l0aG91dCBhbnkgbmVlZCB0bwo+ ID4gPiA+ICAgbWVzcyB3aXRoIGludGVybmFsIGZsYWdzLiBBZ2FpbiwgdGhpcyBzaG91bGQgYmUg c2ltcGxlIGVub3VnaC4KPiA+ID4KPiA+ID4gQVBMSUMgbWFuYWdlcyBhbGwgd2lyZWQgaW50ZXJy dXB0cyB3aGVyZWFzIElNU0lDIG1hbmFnZXMgYWxsCj4gPiA+IE1TSXMuIEJvdGggQVBMSUMgYW5k IElNU0lDIGFyZSBmdW5kYW1lbnRhbCBkZXZpY2VzIHdoaWNoIG5lZWQKPiA+ID4gdG8gYmUgcHJv YmVkIHN1cGVyIGVhcmx5Lgo+ID4gPgo+ID4gPiBOb3cgQVBMSUMgaGFzIHR3byBtb2RlcyBvZiBv cGVyYXRpb25zOgo+ID4gPiAxKSBEaXJlY3QgbW9kZSB3aGVyZSB0aGVyZSBpcyBubyBJTVNJQyBp biB0aGUgc3lzdGVtIGFuZCBBUExJQwo+ID4gPiAgICAgZGlyZWN0bHkgaW5qZWN0cyBpbnRlcnJ1 cHQgdG8gQ1BVcwo+ID4gPiAyKSBNU0kgbW9kZSB3aGVyZSBJTVNJQyBpcyBwcmVzZW50IGluIHRo ZSBzeXN0ZW0gYW5kIEFQTElDCj4gPiA+ICAgICBjb252ZXJ0cyB3aXJlZCBpbnRlcnJ1cHRzIGlu dG8gTVNJcwo+ID4gPgo+ID4gPiBUaGUgQVBMSUMgZHJpdmVyIGFkZGVkIGJ5IHRoaXMgcGF0Y2gg aXMgYSBjb21tb24gZHJpdmVyIGZvcgo+ID4gPiBib3RoIGFib3ZlIG1vZGVzLgo+ID4KPiA+IFdo aWNoIGl0IGRvZXNuJ3QgbmVlZCB0byBiZS4gWW91IGFyZSBwb2ludGxlc3NseSBtYWtpbmcgbGlm ZSBkaWZmaWN1bHQKPiA+IGZvciB5b3Vyc2VsZiwgYW5kIGV2ZXJ5b25lIGVsc2UuIFRoZSBNU0kg YnJpZGdlIGJlaGF2aW91ciBoYXMgKnplcm8qCj4gPiByZWFzb24gdG8gYmUgdGhlIHNhbWUgZHJp dmVyIGFzIHRoZSBtYWluICJJIG5lZWQgaXQgc3VwZXIgZWFybHkiCj4gPiBkcml2ZXIuIFRoZXkg bWF5IGJlIGNhbGxlZCB0aGUgc2FtZSwgYnV0IHRoZXkgKmFyZSogZGlmZmVyZW50IHRoaW5ncwo+ ID4gaW4gdGhlIHN5c3RlbS4KPiA+Cj4gPiBUaGV5IGNhbiBzaGFyZSBjb2RlLCBidXQgdGhleSBh cmUgZnVuZGFtZW50YWxseSBhIGRpZmZlcmVudCB0aGluZyBpbgo+ID4gdGhlIHN5c3RlbS4gQW5k IEkgZ3Vlc3MgdGhpcyBzaWxseSBhcHByb2FjaCBoYXMgb3RoZXIgcmFtaWZpY2F0aW9uczoKPiA+ IHRoZSBJTVNJQyBpcyBhbHNvIHNvbWUgZWFybHkgZHJpdmVyIHdoZW4gaXQgcmVhbGx5IGRvZXNu J3QgbmVlZCB0byBiZS4KPiA+IFdobyBuZWVkcyBNU0lzIHRoYXQgZWFybHkgaW4gdGhlIGxpZmUg b2YgdGhlIHN5c3RlbT8gSSBkb24ndCBidXkgdGhpcwo+ID4gZm9yIGV2ZW4gYSBzZWNvbmQuCj4g Cj4gSU1TSUMgYWxzbyBwcm92aWRlcyBJUElzIHdoaWNoIGFyZSByZXF1aXJlZCBzdXBlciBlYXJs eSBzbyBJIHRoaW5rCj4gd2UgY2FuJ3QgbWFrZSBJTVNJQyBhcyBhIHBsYXRmb3JtIGRyaXZlci4K ClRoZW4gc3BsaXQgdGhpcyBwYXJ0IGZ1cnRoZXIuIEp1c3QgYmVjYXVzZSB0aGUgYXJjaGl0ZWN0 dXJlIGx1bXBzIHR3bwpjb21wbGV0ZWx5IHVucmVsYXRlZCBjb25jZXB0cyB0b2dldGhlciBkb2Vz bid0IG1lYW4gd2UgbmVlZCB0byBmb2xsb3cKdGhlIHNhbWUgb3JnYW5pc2F0aW9uLgoKPiAKPiA+ Cj4gPiBGcmFua2x5LCB0aGlzIHdob2xlIHRoaW5nIG5lZWRzIHRvIGJlIHRha2VuIGFwYXJ0IGFu ZCByZWJ1aWx0IGZyb20gdGhlCj4gPiBncm91bmQgdXAuCj4gPgo+ID4gPiBGb3IgIzIsIEFQTElD IG5lZWRzIHRvIGJlIGEgcGxhdGZvcm0gZGV2aWNlIHRvIGNyZWF0ZSBhIGRldmljZQo+ID4gPiBN U0kgZG9tYWluIHVzaW5nIHBsYXRmb3JtX21zaV9jcmVhdGVfZGV2aWNlX2RvbWFpbigpIHdoaWNo Cj4gPiA+IGlzIHdoeSB0aGUgQVBMSUMgZHJpdmVyIGlzIGEgcGxhdGZvcm0gZHJpdmVyLgo+ID4K PiA+IFlvdSBjYW4ndCBoYXZlIHlvdXIgY2FrZSBhbmQgZWF0IGl0LiBJZiBuZWVkZWQgc3VwZXIg ZWFybHksIGFuZCBpdAo+ID4gY2Fubm90IGJlIGEgcGxhdGZvcm0gZHJpdmVyLiBFbmQgb2YgdGhl IHN0b3J5Lgo+ID4KPiA+IEFuZCB0byBteSBlYXJsaWVyIHBvaW50OiBJTVNJQyBhbmQgQVBMSUMt YXMtTVNJLWJyaWRnZSBoYXZlIG5vIHB1cnBvc2UKPiA+IGJlaW5nIGVhcmx5IGRyaXZlcnMuIFRo ZXkgbXVzdCBiZSBwbGF0Zm9ybSBkcml2ZXJzLCBhbmQgb25seSB0aGF0Lgo+IAo+IFdlIGNhbiBo YXZlIElNU0lDIGFuZCBBUExJQy1EaXJlY3QtTW9kZSBhcyBub24tcGxhdGZvcm0gZHJpdmVyCj4g d2hlcmVhcyBBUExJQy1hcy1NU0ktYnJpZGdlIHdpbGwgYmUgYSBwbGF0Zm9ybSBkcml2ZXIuCj4g Cj4gQm90aCBBUExJQy1EaXJlY3QtTW9kZSBhbmQgQVBMSUMtYXMtTVNJLWJyaWRnZSBjYW4gc2hh cmUgYSBsYXJnZQo+IHBhcnQgb2YgdGhlIGN1cnJlbnQgZHJpdmVyLgo+IAo+ID4KPiA+ID4gPiBJ ZiB0aGVzZSBydWxlcyBkb24ndCBhcHBseSB0byB5b3VyIHN0dWZmLCBwbGVhc2UgZXhwbGFpbiB3 aGF0IGlzIHNvCj4gPiA+ID4gZGlmZmVyZW50LiBBbmQgSSBtZWFuIGFjdHVhbGx5IGV4cGxhaW4g dGhlIGlzc3VlLiBXaGljaCBpc24ndCB0ZWxsaW5nCj4gPiA+ID4gdXMgIml0IGRvZXNuJ3Qgd29y ayB3aXRob3V0IGl0Ii4gQmVjYXVzZSBhcyB0aGluZ3Mgc3RhbmQsIHRoZXJlIGlzIG5vCj4gPiA+ ID4gd2F5IEkgd2lsbCBldmVuIGNvbnNpZGVyIHRha2luZyB0aGlzIHVnbHkgbWl4IG9mIHByb2Jp bmcgbWV0aG9kcy4KPiA+ID4KPiA+ID4gWWVzLCBJIGRvbid0IHdhbnQgdGhpcyB1Z2x5IEZXTk9E RV9GTEFHX0JFU1RfRUZGT1JUIGhhY2sKPiA+ID4gaW4gdGhpcyBkcml2ZXIuCj4gPgo+ID4gQW5k IHlldCB5b3UgYXJlIGhhbW1lcmluZyBpdCBldmVuIHdoZW4gdG9sZCB0aGlzIGlzIHdyb25nLgo+ ID4KPiA+ID4gSSB0cmllZCBzZXZlcmFsIHRoaW5ncyBidXQgc2V0dGluZyB0aGUgRldOT0RFX0ZM QUdfQkVTVF9FRkZPUlQKPiA+ID4gZmxhZyBpcyB0aGUgb25seSB0aGluZyB3aGljaCB3b3JrcyBy aWdodCBub3cuCj4gPgo+ID4gSG93IGFib3V0IHlvdSB0YWtlIGEgc3RlcCBiYWNrIGFuZCByZWFs aXNlIHRoYXQgdGhlIHdheSB5b3UndmUKPiA+IGFyY2hpdGVjdGVkIHlvdXIgZHJpdmVycyBtYWtl cyBsaXR0bGUgc2Vuc2U/IEkgZG9uJ3QgdGhpbmsgeW91IGhhdmUKPiA+IHRyaWVkICp0aGF0Ki4K PiAKPiBCb3RoIEFQTElDIGFuZCBJTVNJQyBhcmUgc2VwYXJhdGUgZGV2aWNlcyBhcyBkZWZpbmVk IGJ5IHRoZSBBSUEgc3BlYy4KPiAKPiBUaGVyZSBhcmUgdGhyZWUgcG9zc2libGUgc3lzdGVtczoK PiAxKSBTeXN0ZW1zIHdpdGggb25seSBBUExJQyAoaS5lLiBvbmx5IHdpcmVkIGludGVycnVwdHMp Cj4gMikgU3lzdGVtcyB3aXRoIG9ubHkgSU1TSUMgKGkuZS4gb25seSBNU0lzKQoKSG93IGlzIHRo YXQgcG9zc2libGU/IEFyZSB5b3Ugc2F5aW5nIHRoYXQgZXZlbiB0aGluZ3MgbGlrZSB0aW1lcnMg YXJlCmZpcmluZyBhcyBNU0lzPwoKPiAzKSBTeXN0ZW1zIHdpdGggYm90aCBBUExJQyBhbmQgSU1T SUMgKGkuZS4gYm90aCB3aXJlZCBpbnRlcnJ1cHRzIGFuZCBNU0lzKQo+IAo+IFRvIGFkZHJlc3Mg dGhlIGFib3ZlLCBBUExJQyBhbmQgSU1TSUMgYXJlIHNlcGFyYXRlIGRyaXZlcnMuIEkgYW0gb2th eQo+IHdpdGggc3BsaXR0aW5nIHRoZSBBUExJQyBkcml2ZXIgaW50byB0d28gc2VwYXJhdGUgZHJp dmVycyAuCgpBZ2Fpbiwgd2UgZG9uJ3QgaGF2ZSB0byBmb2xsb3cgdGhlIHNwbGl0IGVzdGFibGlz aGVkIGJ5IHRoZQphcmNoaXRlY3R1cmUuIEluc3RlYWQsIHdlIHNob3VsZCBmb2xsb3cgd2hhdCBp cyAqZnVuY3Rpb25hbGx5IGNvcnJlY3QqCmZvciB0aGUga2VybmVsLiBJZiB3ZSB3ZXJlIHRvIHdy aXRlIFJpc2MtVi1PUywgdGhhdCdkIGJlIGFuIGFjY2VwdGFibGUKc29sdXRpb24uIEJ1dCB0aGlz IGlzIExpbnV4LCBhbmQgdGhlIGNvbnN0cmFpbnRzIGFyZSBkaWZmZXJlbnQuCgpNeSB0YWtlIG9u IHRoaXMgZGlzY3Vzc2lvbiBpcyB0aGF0IHdlIHNob3VsZCBoYXZlOgoKLSBEaXJlY3QtbW9kZSBB UExJQyArIElQSSBzdXBwb3J0IGFzIGEgYW4gZWFybHkgaXJxY2hpcCBkcml2ZXIKCi0gTVNJLWJy aWRnZSBBUExJQyArIE1TSSBzdXBwb3J0IGFzIHBsYXRmb3JtIGRyaXZlcgoKWWVzLCB0aGVzZSB3 aWxsIGxpa2VseSBzaGFyZSBtb3N0IG9mIHRoZWlyIGNvZGUuIEJ1dCBhdCBsZWFzdCB0aGUKc3Bs aXQgd2lsbCBiZSBtYW5hZ2VhYmxlLCBhbmQgd2lsbCBhdm9pZCB1Z2x5IGhhY2tzLgoKCU0uCgot LSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3Np YmxlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688B7C001DE for ; Mon, 17 Jul 2023 08:06:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjGQIGW (ORCPT ); Mon, 17 Jul 2023 04:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbjGQIGV (ORCPT ); Mon, 17 Jul 2023 04:06:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 128301B6; Mon, 17 Jul 2023 01:05:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A528C60FC3; Mon, 17 Jul 2023 08:05:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7566C433C7; Mon, 17 Jul 2023 08:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689581142; bh=46YRuhlRY7c+LYecTNMxpUt1Pqhr6LxrNXXMX9FblS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YJ9ZPNl69moiTL72CtguPknDitu9OYCgTsJ1oohTyF1xD9D7scok/HBn6g558ydmr w4J9kIB46QEYnPH7PTmfVhWc8q1e9RJEM0Np66ZpYP2TDUP31ncREtXa1DjX4N26q0 YNN48134XAQBpEo2sP2oJ/JF8P7Ng8qH8/NfV46yHBna/6mt0UTf7Lo9EpzK/7M71f 8lw1cZ+h/x1jPmSy9kaPPSw2CUwHDsCggyT/MavGe1bpqhyJQwmV8Iic3ZBvwqctyX rRLK0naXMu4oKGp5TwUws64y3gKY+xyaxZstv5By2W2eXn4geCQd9R/JmE/OytHXz5 akddHBScOHDWA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qLJEf-00Df2M-Oo; Mon, 17 Jul 2023 09:05:39 +0100 Date: Mon, 17 Jul 2023 09:05:37 +0100 Message-ID: <868rbfufn2.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Anup Patel , Saravana Kannan , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Atish Patra , Andrew Jones , Sunil V L , Conor Dooley , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 7/9] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230710094321.1378351-1-apatel@ventanamicro.com> <20230710094321.1378351-8-apatel@ventanamicro.com> <86jzv2vpdb.wl-maz@kernel.org> <86cz0uvcof.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anup@brainfault.org, apatel@ventanamicro.com, saravanak@google.com, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, atishp@atishpatra.org, ajones@ventanamicro.com, sunilvl@ventanamicro.com, conor@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 14 Jul 2023 15:05:07 +0100, Anup Patel wrote: >=20 > On Fri, Jul 14, 2023 at 7:05=E2=80=AFPM Marc Zyngier wro= te: > > > > On Fri, 14 Jul 2023 10:35:34 +0100, > > Anup Patel wrote: > > > > > > On Fri, Jul 14, 2023 at 2:31=E2=80=AFPM Marc Zyngier = wrote: > > > > > > > > Anup, > > > > > > > > On Fri, 14 Jul 2023 00:56:22 +0100, > > > > Saravana Kannan wrote: > > > > > > > > > > On Mon, Jul 10, 2023 at 2:44=E2=80=AFAM Anup Patel wrote: > > > > > > > > > > > > The RISC-V advanced interrupt architecture (AIA) specification = defines > > > > > > a new interrupt controller for managing wired interrupts on a R= ISC-V > > > > > > platform. This new interrupt controller is referred to as advan= ced > > > > > > platform-level interrupt controller (APLIC) which can forward w= ired > > > > > > interrupts to CPUs (or HARTs) as local interrupts OR as message > > > > > > signaled interrupts. > > > > > > (For more details refer https://github.com/riscv/riscv-aia) > > > > > > > > > > > > This patch adds an irqchip driver for RISC-V APLIC found on RIS= C-V > > > > > > platforms. > > > > > > > > > > > > Signed-off-by: Anup Patel > > > > > > > > [...] > > > > > > > > > > +static int __init aplic_dt_init(struct device_node *node, > > > > > > + struct device_node *parent) > > > > > > +{ > > > > > > + /* > > > > > > + * The APLIC platform driver needs to be probed early > > > > > > + * so for device tree: > > > > > > + * > > > > > > + * 1) Set the FWNODE_FLAG_BEST_EFFORT flag in fwnode wh= ich > > > > > > + * provides a hint to the device driver core to prob= e the > > > > > > + * platform driver early. > > > > > > + * 2) Clear the OF_POPULATED flag in device_node because > > > > > > + * of_irq_init() sets it which prevents creation of > > > > > > + * platform device. > > > > > > + */ > > > > > > + node->fwnode.flags |=3D FWNODE_FLAG_BEST_EFFORT; > > > > > > > > > > Please stop spamming us with broken patches. Already told you thi= s is > > > > > not an option. > > > > > > > > > > Nack. > > > > > > > > What puzzles me here is that *no other arch* requires this sort of > > > > hack. What is so special about the APLIC that it requires it? I see > > > > nothing in this patch that even hints at it, despite the "discussio= n" > > > > in the last round. > > > > > > > > The rules are simple: > > > > > > > > - either the APLIC is so fundamental to the system that it has to be > > > > initialised super early, much like the GIC on arm64, at which poi= nt > > > > it cannot be a platform device, and the story is pretty simple. > > > > > > > > - or it isn't that fundamental, and it can be probed as a platform > > > > device using the dependency infrastructure that is already used by > > > > multiple other interrupt controller drivers, without any need to > > > > mess with internal flags. Again, this should be simple enough. > > > > > > APLIC manages all wired interrupts whereas IMSIC manages all > > > MSIs. Both APLIC and IMSIC are fundamental devices which need > > > to be probed super early. > > > > > > Now APLIC has two modes of operations: > > > 1) Direct mode where there is no IMSIC in the system and APLIC > > > directly injects interrupt to CPUs > > > 2) MSI mode where IMSIC is present in the system and APLIC > > > converts wired interrupts into MSIs > > > > > > The APLIC driver added by this patch is a common driver for > > > both above modes. > > > > Which it doesn't need to be. You are pointlessly making life difficult > > for yourself, and everyone else. The MSI bridge behaviour has *zero* > > reason to be the same driver as the main "I need it super early" > > driver. They may be called the same, but they *are* different things > > in the system. > > > > They can share code, but they are fundamentally a different thing in > > the system. And I guess this silly approach has other ramifications: > > the IMSIC is also some early driver when it really doesn't need to be. > > Who needs MSIs that early in the life of the system? I don't buy this > > for even a second. >=20 > IMSIC also provides IPIs which are required super early so I think > we can't make IMSIC as a platform driver. Then split this part further. Just because the architecture lumps two completely unrelated concepts together doesn't mean we need to follow the same organisation. >=20 > > > > Frankly, this whole thing needs to be taken apart and rebuilt from the > > ground up. > > > > > For #2, APLIC needs to be a platform device to create a device > > > MSI domain using platform_msi_create_device_domain() which > > > is why the APLIC driver is a platform driver. > > > > You can't have your cake and eat it. If needed super early, and it > > cannot be a platform driver. End of the story. > > > > And to my earlier point: IMSIC and APLIC-as-MSI-bridge have no purpose > > being early drivers. They must be platform drivers, and only that. >=20 > We can have IMSIC and APLIC-Direct-Mode as non-platform driver > whereas APLIC-as-MSI-bridge will be a platform driver. >=20 > Both APLIC-Direct-Mode and APLIC-as-MSI-bridge can share a large > part of the current driver. >=20 > > > > > > If these rules don't apply to your stuff, please explain what is so > > > > different. And I mean actually explain the issue. Which isn't telli= ng > > > > us "it doesn't work without it". Because as things stand, there is = no > > > > way I will even consider taking this ugly mix of probing methods. > > > > > > Yes, I don't want this ugly FWNODE_FLAG_BEST_EFFORT hack > > > in this driver. > > > > And yet you are hammering it even when told this is wrong. > > > > > I tried several things but setting the FWNODE_FLAG_BEST_EFFORT > > > flag is the only thing which works right now. > > > > How about you take a step back and realise that the way you've > > architected your drivers makes little sense? I don't think you have > > tried *that*. >=20 > Both APLIC and IMSIC are separate devices as defined by the AIA spec. >=20 > There are three possible systems: > 1) Systems with only APLIC (i.e. only wired interrupts) > 2) Systems with only IMSIC (i.e. only MSIs) How is that possible? Are you saying that even things like timers are firing as MSIs? > 3) Systems with both APLIC and IMSIC (i.e. both wired interrupts and MSIs) >=20 > To address the above, APLIC and IMSIC are separate drivers. I am okay > with splitting the APLIC driver into two separate drivers . Again, we don't have to follow the split established by the architecture. Instead, we should follow what is *functionally correct* for the kernel. If we were to write Risc-V-OS, that'd be an acceptable solution. But this is Linux, and the constraints are different. My take on this discussion is that we should have: - Direct-mode APLIC + IPI support as a an early irqchip driver - MSI-bridge APLIC + MSI support as platform driver Yes, these will likely share most of their code. But at least the split will be manageable, and will avoid ugly hacks. M. --=20 Without deviation from the norm, progress is not possible.