From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7148FC32771 for ; Mon, 26 Sep 2022 14:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234302AbiIZOZM (ORCPT ); Mon, 26 Sep 2022 10:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234311AbiIZOYs (ORCPT ); Mon, 26 Sep 2022 10:24:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C7C0606B1 for ; Mon, 26 Sep 2022 05:35:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D786F60BEF for ; Mon, 26 Sep 2022 12:35:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DA9AC433C1; Mon, 26 Sep 2022 12:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664195754; bh=+7Dy/qBrAbPQ/VnyDF8M/916yD7tx2rsp8x7Rh1LF+M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iKD/KaoBjASUcVsppCdsYJd+4o9qIfRvb3ipDeI4T+NiM2GCqdOIRvHF7+IGEjfNx n0p3xrZ44QG2ZVsraKgL7+8Gb+prhshE4kKRCL1Q2gmnKtnOvZaJ6VfZQBKJDq6yb+ tD26heVhEBDEcXxf8X0mbcu+fp9vbAmhMelAEsaJdydw/x9JHGAS2CKX66cEyFk1nE FXZtDFdnzaFYhD4otiMGxg7xejbRGCEBAs2eYcOOuYhr80M4yubGYUvoVzT3SHtvY7 6f0W0tEUjdxDi8byhud/ara485LkikwS6FWkBHgk0sywDurW2m5Z4XNGrtXXRMtInl QI4dtPU4HRElg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ocnKx-00CgqY-Tt; Mon, 26 Sep 2022 13:35:52 +0100 Date: Mon, 26 Sep 2022 08:35:51 -0400 Message-ID: <868rm68g9k.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Marek =?UTF-8?B?QmVow7pu?= , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de Subject: Re: [PATCH 03/11] PCI: aardvark: Add support for DLLSC and hotplug interrupt In-Reply-To: References: <20220818135140.5996-1-kabel@kernel.org> <20220818135140.5996-4-kabel@kernel.org> <87r10al6a0.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, kabel@kernel.org, lorenzo.pieralisi@arm.com, helgaas@kernel.org, kw@linux.com, pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 26 Sep 2022 07:49:55 -0400, Lorenzo Pieralisi wrote: >=20 > On Sat, Sep 17, 2022 at 10:05:59AM +0100, Marc Zyngier wrote: > > Hi Lorenzo, > >=20 > > On Fri, 09 Sep 2022 15:57:11 +0100, > > Lorenzo Pieralisi wrote: > > >=20 > > > [+Marc, Thomas - I can't merge this code without them reviewing it, > > > I am not sure at all you can mix the timer/IRQ code the way you do] > > >=20 > > > On Thu, Aug 18, 2022 at 03:51:32PM +0200, Marek Beh=C3=BAn wrote: > > > > From: Pali Roh=C3=A1r > > > >=20 > > > > Add support for Data Link Layer State Change in the emulated slot > > > > registers and hotplug interrupt via the emulated root bridge. > > > >=20 > > > > This is mainly useful for when an error causes link down event. With > > > > this change, drivers can try recovery. > > > >=20 > > > > Link down state change can be implemented because Aardvark supports= Link > > > > Down event interrupt. Use it for signaling that Data Link Layer Lin= k is > > > > not active anymore via Hot-Plug Interrupt on emulated root bridge. > > > >=20 > > > > Link up interrupt is not available on Aardvark, but we check for wh= ether > > > > link is up in the advk_pcie_link_up() function. By triggering Hot-P= lug > > > > Interrupt from this function we achieve Link up event, so long as t= he > > > > function is called (which it is after probe and when rescanning). > > > > Although it is not ideal, it is better than nothing. > > >=20 > > > So before even coming to the code review: this patch does two things. > > >=20 > > > 1) It adds support for handling the Link down state > > > 2) It adds some code to emulate a Link-up event > > >=20 > > > Now, for (2). IIUC you are adding code to make sure that an HP > > > event is triggered if advk_pcie_link_up() is called and it > > > detects a Link-down->Link-up transition, that has to be notified > > > through an HP event. > > >=20 > > > If that's correct, you have to explain to me please what this is > > > actually achieving and a specific scenario where we want this to be > > > implemented, in fine details; then we add it to the commit log. > > >=20 > > > That aside, the interaction of the timer and the IRQ domain code > > > must be reviewed by Marc and Thomas to make sure this is not > > > a gross violation of the respective subsystems usage. > >=20 > > I don't see anything being a "gross violation" here, at least from an > > interrupt subsystem perspective. In a way, this is synthesising an > > interrupt on the back of some other event, and as long as the context > > is somehow appropriate (something that looks like an interrupt when > > pretending there is one), this should be OK. Other subsystems such as > > i2c GPIO expanders do similar things. >=20 > Right, thanks. >=20 > > The one thing I'm dubious about is the frequency of the timer. Asking > > for a poll of the link every jiffy is bound to be expensive, and it > > would be good to relax this as much as possible, specially on low-end > > HW such as this, where every cycle counts. It is always going to be a > > "best effort" thing, and the commit message doesn't say what's the > > actual grace period to handle this (the spec probably has one). >=20 > AFAICS, the code does not poll the link. It sets a timer only if > the link is checked (eg upon PCI bus forced rescan or config access) > the link is up and it was down, to emulate a HP IRQ. I still find the timer frequency pretty high, but surely the authors of the code have worked out that this wasn't a problem. Thanks, M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38926C32771 for ; Mon, 26 Sep 2022 12:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ca/urOjalFy+3yaaQpHt6ljo18iR+3l/jsdLgAUXINs=; b=NYwZbYmV3tgMCP yX4Gc8HChdDlIt+pWP+TwVUrBRtL/k7/YzlOe/TrqG6Bse/GC4eR//pNxfyjlE4g9VX+StglyGr04 jj0dMDbsJzkiaUd5Et99xOh525mF2zERCbD072HXEKSjSWit0BSsOz9Y4qqVrZyix34ZmyRT9kuAP mYu40Wkg0pv8ClIdYIUcnFO746qON8A8qFR1pLSHZFCe0c2pzse0Qe2E+yXMj+lnXQWNNEn1W2LLl uZEpLO4RV5+xegbLb3vNchK+ltG7A13bGrjdCVtbedYXWM6ebuZDesghoh4ND9ebnKb6PCtGGTpd3 ugfj4drUESxg9hMF9jsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocnL5-004pKZ-Kd; Mon, 26 Sep 2022 12:35:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocnL1-004pIb-Bl for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 12:35:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C816560BFE; Mon, 26 Sep 2022 12:35:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DA9AC433C1; Mon, 26 Sep 2022 12:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664195754; bh=+7Dy/qBrAbPQ/VnyDF8M/916yD7tx2rsp8x7Rh1LF+M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iKD/KaoBjASUcVsppCdsYJd+4o9qIfRvb3ipDeI4T+NiM2GCqdOIRvHF7+IGEjfNx n0p3xrZ44QG2ZVsraKgL7+8Gb+prhshE4kKRCL1Q2gmnKtnOvZaJ6VfZQBKJDq6yb+ tD26heVhEBDEcXxf8X0mbcu+fp9vbAmhMelAEsaJdydw/x9JHGAS2CKX66cEyFk1nE FXZtDFdnzaFYhD4otiMGxg7xejbRGCEBAs2eYcOOuYhr80M4yubGYUvoVzT3SHtvY7 6f0W0tEUjdxDi8byhud/ara485LkikwS6FWkBHgk0sywDurW2m5Z4XNGrtXXRMtInl QI4dtPU4HRElg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ocnKx-00CgqY-Tt; Mon, 26 Sep 2022 13:35:52 +0100 Date: Mon, 26 Sep 2022 08:35:51 -0400 Message-ID: <868rm68g9k.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Marek =?UTF-8?B?QmVow7pu?= , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de Subject: Re: [PATCH 03/11] PCI: aardvark: Add support for DLLSC and hotplug interrupt In-Reply-To: References: <20220818135140.5996-1-kabel@kernel.org> <20220818135140.5996-4-kabel@kernel.org> <87r10al6a0.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, kabel@kernel.org, lorenzo.pieralisi@arm.com, helgaas@kernel.org, kw@linux.com, pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_053555_502786_FB20D09E X-CRM114-Status: GOOD ( 46.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNiBTZXAgMjAyMiAwNzo0OTo1NSAtMDQwMCwKTG9yZW56byBQaWVyYWxpc2kgPGxw aWVyYWxpc2lAa2VybmVsLm9yZz4gd3JvdGU6Cj4gCj4gT24gU2F0LCBTZXAgMTcsIDIwMjIgYXQg MTA6MDU6NTlBTSArMDEwMCwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gSGkgTG9yZW56bywKPiA+ IAo+ID4gT24gRnJpLCAwOSBTZXAgMjAyMiAxNTo1NzoxMSArMDEwMCwKPiA+IExvcmVuem8gUGll cmFsaXNpIDxscGllcmFsaXNpQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiAKPiA+ID4gWytNYXJj LCBUaG9tYXMgLSBJIGNhbid0IG1lcmdlIHRoaXMgY29kZSB3aXRob3V0IHRoZW0gcmV2aWV3aW5n IGl0LAo+ID4gPiBJIGFtIG5vdCBzdXJlIGF0IGFsbCB5b3UgY2FuIG1peCB0aGUgdGltZXIvSVJR IGNvZGUgdGhlIHdheSB5b3UgZG9dCj4gPiA+IAo+ID4gPiBPbiBUaHUsIEF1ZyAxOCwgMjAyMiBh dCAwMzo1MTozMlBNICswMjAwLCBNYXJlayBCZWjDum4gd3JvdGU6Cj4gPiA+ID4gRnJvbTogUGFs aSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiA+ID4gPiAKPiA+ID4gPiBBZGQgc3VwcG9ydCBm b3IgRGF0YSBMaW5rIExheWVyIFN0YXRlIENoYW5nZSBpbiB0aGUgZW11bGF0ZWQgc2xvdAo+ID4g PiA+IHJlZ2lzdGVycyBhbmQgaG90cGx1ZyBpbnRlcnJ1cHQgdmlhIHRoZSBlbXVsYXRlZCByb290 IGJyaWRnZS4KPiA+ID4gPiAKPiA+ID4gPiBUaGlzIGlzIG1haW5seSB1c2VmdWwgZm9yIHdoZW4g YW4gZXJyb3IgY2F1c2VzIGxpbmsgZG93biBldmVudC4gV2l0aAo+ID4gPiA+IHRoaXMgY2hhbmdl LCBkcml2ZXJzIGNhbiB0cnkgcmVjb3ZlcnkuCj4gPiA+ID4gCj4gPiA+ID4gTGluayBkb3duIHN0 YXRlIGNoYW5nZSBjYW4gYmUgaW1wbGVtZW50ZWQgYmVjYXVzZSBBYXJkdmFyayBzdXBwb3J0cyBM aW5rCj4gPiA+ID4gRG93biBldmVudCBpbnRlcnJ1cHQuIFVzZSBpdCBmb3Igc2lnbmFsaW5nIHRo YXQgRGF0YSBMaW5rIExheWVyIExpbmsgaXMKPiA+ID4gPiBub3QgYWN0aXZlIGFueW1vcmUgdmlh IEhvdC1QbHVnIEludGVycnVwdCBvbiBlbXVsYXRlZCByb290IGJyaWRnZS4KPiA+ID4gPiAKPiA+ ID4gPiBMaW5rIHVwIGludGVycnVwdCBpcyBub3QgYXZhaWxhYmxlIG9uIEFhcmR2YXJrLCBidXQg d2UgY2hlY2sgZm9yIHdoZXRoZXIKPiA+ID4gPiBsaW5rIGlzIHVwIGluIHRoZSBhZHZrX3BjaWVf bGlua191cCgpIGZ1bmN0aW9uLiBCeSB0cmlnZ2VyaW5nIEhvdC1QbHVnCj4gPiA+ID4gSW50ZXJy dXB0IGZyb20gdGhpcyBmdW5jdGlvbiB3ZSBhY2hpZXZlIExpbmsgdXAgZXZlbnQsIHNvIGxvbmcg YXMgdGhlCj4gPiA+ID4gZnVuY3Rpb24gaXMgY2FsbGVkICh3aGljaCBpdCBpcyBhZnRlciBwcm9i ZSBhbmQgd2hlbiByZXNjYW5uaW5nKS4KPiA+ID4gPiBBbHRob3VnaCBpdCBpcyBub3QgaWRlYWws IGl0IGlzIGJldHRlciB0aGFuIG5vdGhpbmcuCj4gPiA+IAo+ID4gPiBTbyBiZWZvcmUgZXZlbiBj b21pbmcgdG8gdGhlIGNvZGUgcmV2aWV3OiB0aGlzIHBhdGNoIGRvZXMgdHdvIHRoaW5ncy4KPiA+ ID4gCj4gPiA+IDEpIEl0IGFkZHMgc3VwcG9ydCBmb3IgaGFuZGxpbmcgdGhlIExpbmsgZG93biBz dGF0ZQo+ID4gPiAyKSBJdCBhZGRzIHNvbWUgY29kZSB0byBlbXVsYXRlIGEgTGluay11cCBldmVu dAo+ID4gPiAKPiA+ID4gTm93LCBmb3IgKDIpLiBJSVVDIHlvdSBhcmUgYWRkaW5nIGNvZGUgdG8g bWFrZSBzdXJlIHRoYXQgYW4gSFAKPiA+ID4gZXZlbnQgaXMgdHJpZ2dlcmVkIGlmIGFkdmtfcGNp ZV9saW5rX3VwKCkgaXMgY2FsbGVkIGFuZCBpdAo+ID4gPiBkZXRlY3RzIGEgTGluay1kb3duLT5M aW5rLXVwIHRyYW5zaXRpb24sIHRoYXQgaGFzIHRvIGJlIG5vdGlmaWVkCj4gPiA+IHRocm91Z2gg YW4gSFAgZXZlbnQuCj4gPiA+IAo+ID4gPiBJZiB0aGF0J3MgY29ycmVjdCwgeW91IGhhdmUgdG8g ZXhwbGFpbiB0byBtZSBwbGVhc2Ugd2hhdCB0aGlzIGlzCj4gPiA+IGFjdHVhbGx5IGFjaGlldmlu ZyBhbmQgYSBzcGVjaWZpYyBzY2VuYXJpbyB3aGVyZSB3ZSB3YW50IHRoaXMgdG8gYmUKPiA+ID4g aW1wbGVtZW50ZWQsIGluIGZpbmUgZGV0YWlsczsgdGhlbiB3ZSBhZGQgaXQgdG8gdGhlIGNvbW1p dCBsb2cuCj4gPiA+IAo+ID4gPiBUaGF0IGFzaWRlLCB0aGUgaW50ZXJhY3Rpb24gb2YgdGhlIHRp bWVyIGFuZCB0aGUgSVJRIGRvbWFpbiBjb2RlCj4gPiA+IG11c3QgYmUgcmV2aWV3ZWQgYnkgTWFy YyBhbmQgVGhvbWFzIHRvIG1ha2Ugc3VyZSB0aGlzIGlzIG5vdAo+ID4gPiBhIGdyb3NzIHZpb2xh dGlvbiBvZiB0aGUgcmVzcGVjdGl2ZSBzdWJzeXN0ZW1zIHVzYWdlLgo+ID4gCj4gPiBJIGRvbid0 IHNlZSBhbnl0aGluZyBiZWluZyBhICJncm9zcyB2aW9sYXRpb24iIGhlcmUsIGF0IGxlYXN0IGZy b20gYW4KPiA+IGludGVycnVwdCBzdWJzeXN0ZW0gcGVyc3BlY3RpdmUuIEluIGEgd2F5LCB0aGlz IGlzIHN5bnRoZXNpc2luZyBhbgo+ID4gaW50ZXJydXB0IG9uIHRoZSBiYWNrIG9mIHNvbWUgb3Ro ZXIgZXZlbnQsIGFuZCBhcyBsb25nIGFzIHRoZSBjb250ZXh0Cj4gPiBpcyBzb21laG93IGFwcHJv cHJpYXRlIChzb21ldGhpbmcgdGhhdCBsb29rcyBsaWtlIGFuIGludGVycnVwdCB3aGVuCj4gPiBw cmV0ZW5kaW5nIHRoZXJlIGlzIG9uZSksIHRoaXMgc2hvdWxkIGJlIE9LLiBPdGhlciBzdWJzeXN0 ZW1zIHN1Y2ggYXMKPiA+IGkyYyBHUElPIGV4cGFuZGVycyBkbyBzaW1pbGFyIHRoaW5ncy4KPiAK PiBSaWdodCwgdGhhbmtzLgo+IAo+ID4gVGhlIG9uZSB0aGluZyBJJ20gZHViaW91cyBhYm91dCBp cyB0aGUgZnJlcXVlbmN5IG9mIHRoZSB0aW1lci4gQXNraW5nCj4gPiBmb3IgYSBwb2xsIG9mIHRo ZSBsaW5rIGV2ZXJ5IGppZmZ5IGlzIGJvdW5kIHRvIGJlIGV4cGVuc2l2ZSwgYW5kIGl0Cj4gPiB3 b3VsZCBiZSBnb29kIHRvIHJlbGF4IHRoaXMgYXMgbXVjaCBhcyBwb3NzaWJsZSwgc3BlY2lhbGx5 IG9uIGxvdy1lbmQKPiA+IEhXIHN1Y2ggYXMgdGhpcywgd2hlcmUgZXZlcnkgY3ljbGUgY291bnRz LiBJdCBpcyBhbHdheXMgZ29pbmcgdG8gYmUgYQo+ID4gImJlc3QgZWZmb3J0IiB0aGluZywgYW5k IHRoZSBjb21taXQgbWVzc2FnZSBkb2Vzbid0IHNheSB3aGF0J3MgdGhlCj4gPiBhY3R1YWwgZ3Jh Y2UgcGVyaW9kIHRvIGhhbmRsZSB0aGlzICh0aGUgc3BlYyBwcm9iYWJseSBoYXMgb25lKS4KPiAK PiBBRkFJQ1MsIHRoZSBjb2RlIGRvZXMgbm90IHBvbGwgdGhlIGxpbmsuIEl0IHNldHMgYSB0aW1l ciBvbmx5IGlmCj4gdGhlIGxpbmsgaXMgY2hlY2tlZCAoZWcgdXBvbiBQQ0kgYnVzIGZvcmNlZCBy ZXNjYW4gb3IgY29uZmlnIGFjY2VzcykKPiB0aGUgbGluayBpcyB1cCBhbmQgaXQgd2FzIGRvd24s IHRvIGVtdWxhdGUgYSBIUCBJUlEuCgpJIHN0aWxsIGZpbmQgdGhlIHRpbWVyIGZyZXF1ZW5jeSBw cmV0dHkgaGlnaCwgYnV0IHN1cmVseSB0aGUgYXV0aG9ycwpvZiB0aGUgY29kZSBoYXZlIHdvcmtl ZCBvdXQgdGhhdCB0aGlzIHdhc24ndCBhIHByb2JsZW0uCgpUaGFua3MsCgoJTS4KCi0tIApXaXRo b3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==