Re: Two To: headers added to auto-mails from list

[Christian Laursen <xi@borderworlds.dk>]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Martin Koch Andersen <martin@925.dk> writes:

> I have noticed that in emails from the list (confirm-sub, sub-ok etc.)
> I get two To: headers.
>
> In the configuration of my list I have 'Add To: header'. And in
> Delete headers' 'To:' is listed also.

I have just reproduced this.

> Why do I get this extra To: header? Could it be a bug with the
> mentioned configuration above?

The problem is that when addtohdr is true, an extra To: header is
always appended by mlmmj-send even for mails not going to the list
subscribers, e.g. subscribe confirmations and mails to moderators.

I have made a small patch that only sets addtohdr from the control
dir when resending earlier failed mails or sending normal list mail.
I am however not sure that this is the right solution, so I would
welcome any input.

The patch is attached.

> Using latest version.

I know. :)

-- 
Christian Laursen

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mlmmj-send.c patch --]
[-- Type: text/x-patch, Size: 831 bytes --]

diff -urN mlmmj-1.2.11.orig/src/mlmmj-send.c mlmmj-1.2.11/src/mlmmj-send.c
--- mlmmj-1.2.11.orig/src/mlmmj-send.c	Tue Nov  1 14:23:49 2005
+++ mlmmj-1.2.11/src/mlmmj-send.c	Tue Apr  4 19:43:42 2006
@@ -823,7 +823,6 @@
 		exit(EXIT_FAILURE);
 	}
 
-	addtohdr = statctrl(listdir, "addtohdr");
 	memmailsizestr = ctrlvalue(listdir, "memorymailsize");
 	ctrlarchive = statctrl(listdir, "noarchive");
 	if(memmailsizestr) {
@@ -886,6 +885,7 @@
 		}
 		break;
 	case '3':
+		addtohdr = statctrl(listdir, "addtohdr");
 	case '4': /* sending mails to subfile */
 		if((subfd = open(subfilename, O_RDONLY)) < 0) {
 			log_error(LOG_ARGS, "Could not open '%s':",
@@ -904,6 +904,7 @@
 						archivefilename);
 		break;
 	default: /* normal list mail -- now handled when forking */
+		addtohdr = statctrl(listdir, "addtohdr");
 		break;
 	}