From: Hamza Mahfooz <someguy@effective-light.com>
To: "Filipe Laíns" <lains@riseup.net>
Cc: linux-kernel@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices
Date: Fri, 23 Jul 2021 17:39:44 -0400 [thread overview]
Message-ID: <86WPWQ.ODI6WUKUKD0N3@effective-light.com> (raw)
In-Reply-To: <e3bdfa16584d7ec832414dcb854ee4d2582543b3.camel@riseup.net>
On Fri, Jul 23 2021 at 08:42:32 PM +0100, Filipe Laíns
<lains@riseup.net> wrote:
> That said, I think we should definitely have a comment here nothing
> that, and
> possible have some bounds checks for the reported voltage value
> hinting that
> there may be bug.
Hey Filipe,
Do you have any thoughts on what the bounds ought to be?
3500 mV seems like a rather safe lower bound, however the upper bound
seems much more fuzzy.
next prev parent reply other threads:[~2021-07-23 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 18:57 [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices Hamza Mahfooz
2021-07-23 19:11 ` Bastien Nocera
2021-07-23 19:42 ` Filipe Laíns
2021-07-23 21:39 ` Hamza Mahfooz [this message]
2021-07-31 22:08 ` Filipe Laíns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86WPWQ.ODI6WUKUKD0N3@effective-light.com \
--to=someguy@effective-light.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.