From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76D40C25B75 for ; Wed, 29 May 2024 10:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vgfa/HXEbZFWngM5uJN8TJYCYuyHdet6A1RCwMHT58k=; b=VlQeAxACjEn1Vq 0AvxsXdADjGiQCicMlt5sUjEvcGUNN81EkvTPKAtWGQ0aFmHk+BWGmpmuesu9HPxh25xJyLsvt7xF hg7oHtEeiy6FFT5ZLhT8OTb7jX0N2KbIugeSaceyCxjWEPE0gpyRGOEu1vyrCqhJORx5w2P1V+axB KKQt0NT/xFdpRqJnK+cw2swghKw0wIIoYqHz5T7bQ4JIRZa2/CylSSCwZC2pIW97UKzCbyrohMY1v vMk4g82YHhevUB0l+he0CSh+V1UkAy58liNHsP5nmxkrVinTxn5caUe1OmOXb9fA7mNZ5B+g5ew+w yQlmVWzY8HhJZYLpa1mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCGnr-00000003qiv-2DHI; Wed, 29 May 2024 10:45:07 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCGnn-00000003qgo-2bEp; Wed, 29 May 2024 10:45:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2182462833; Wed, 29 May 2024 10:45:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4C70C2BD10; Wed, 29 May 2024 10:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716979502; bh=DChLerdywJ2VIfY90QcVmGj9zaM+zQADMtga2RWsg0Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GD0/hxXtID9qZ90DSquWe/Fen/Gej2oChC8r3GtEMxqdKZvfQ6AJWzgvAKFGY1cmd 7Bgj5x5WYfBCvTnMDGX7CNpQUQy1WsyjprmxlOgUDyYjslR9pKLe10EFwMoqtXHK/a 8nvEwZw5VNk3Yxrcr7n6Gtn20NUSJYKiAEBs8HPF+2920QjKXmpAza4QonkVLMTFg3 LC268LGiZhqMzrKzwsfrvgrsKUGoE4bFjrCyOuSbu6m+nxeh1JASoZlDzNYjBT3V2e 9NdxbqNunYQ+0jJF3YQOIbTbGDZTBdNTFoeX4LunEbjdlhJn1SIawQx0rzvd4bfj52 elVro26NwU8NA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCGnj-00GaQE-KB; Wed, 29 May 2024 11:45:00 +0100 Date: Wed, 29 May 2024 11:44:58 +0100 Message-ID: <86a5k8nbh1.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> <86bk4pm8j1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_034503_773577_DF3A8F22 X-CRM114-Status: GOOD ( 47.11 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBNYXkgMjAyNCAxMToxNjozMCArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIFdlZCwgTWF5IDI5LCAyMDI0IGF0IDEyOjAz 4oCvUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gV2Vk LCAyOSBNYXkgMjAyNCAwNjoxNTo1MiArMDEwMCwKPiA+IEFudXAgUGF0ZWwgPGFwYXRlbEB2ZW50 YW5hbWljcm8uY29tPiB3cm90ZToKPiA+ID4KPiA+ID4gT24gVHVlLCBNYXkgMjgsIDIwMjQgYXQg MTA6MTHigK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gPgo+ ID4gPiA+IENvbW1pdCBkOTc2YzZmNGIzMmMgKCJvZjogcHJvcGVydHk6IEFkZCBmd19kZXZsaW5r IHN1cHBvcnQgZm9yCj4gPiA+ID4gaW50ZXJydXB0LW1hcCBwcm9wZXJ0eSIpIHRyaWVkIHRvIGRv IHdoYXQgaXQgc2F5cyBvbiB0aGUgdGluLAo+ID4gPiA+IGJ1dCBmYWlsZWQgb24gYSBjb3VwbGUg b2YgcG9pbnRzOgo+ID4gPiA+Cj4gPiA+ID4gLSBpdCBjb25mdXNlcyBieXRlcyBhbmQgY2VsbHMu IE5vdCBhIGh1Z2UgZGVhbCwgZXhjZXB0IHdoZW4gaXQKPiA+ID4gPiAgIGNvbWVzIHRvIHBvaW50 ZXIgYXJpdGhtZXRpYwo+ID4gPiA+Cj4gPiA+ID4gLSBpdCBkb2Vzbid0IHJlYWxseSBoYW5kbGUg YW55dGhpbmcgYnV0IGludGVycnVwdC1tYXBzIHRoYXQgaGF2ZQo+ID4gPiA+ICAgdGhlaXIgcGFy ZW50ICNhZGRyZXNzLWNlbGxzIHNldCB0byAwCj4gPiA+ID4KPiA+ID4gPiBUaGUgY29tYmluYXRp b25zIG9mIHRoZSB0d28gbGVhZHMgdG8gc29tZSBzZXJpb3VzIGZ1biBvbiBteSBNMQo+ID4gPiA+ IGJveCwgd2l0aCBwbGVudHkgb2YgV0FSTi1PTigpIGZpcmluZyBhbGwgb3ZlciB0aGUgc2hvcCwg YW5kCj4gPiA+ID4gYW11c2luZyB2YWx1ZXMgYmVpbmcgZ2VuZXJhdGVkIGZvciBpbnRlcnJ1cHQg c3BlY2lmaWVycy4KPiA+ID4gPgo+ID4gPiA+IEFkZHJlc3MgYm90aCBpc3N1ZXMgc28gdGhhdCBJ IGNhbiBib290IG15IG1hY2hpbmVzIGFnYWluLgo+ID4gPiA+Cj4gPiA+ID4gRml4ZXM6IGQ5NzZj NmY0YjMyYyAoIm9mOiBwcm9wZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IgaW50ZXJy dXB0LW1hcCBwcm9wZXJ0eSIpCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTWFyYyBaeW5naWVyIDxt YXpAa2VybmVsLm9yZz4KPiA+ID4gPiBDYzogQW51cCBQYXRlbCA8YXBhdGVsQHZlbnRhbmFtaWNy by5jb20+Cj4gPiA+ID4gQ2M6IFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2dsZS5jb20+ Cj4gPiA+ID4gQ2M6IFJvYiBIZXJyaW5nIChBcm0pIDxyb2JoQGtlcm5lbC5vcmc+Cj4gPiA+Cj4g PiA+IFRoYW5rcyBmb3IgdGhlIGZpeCBwYXRjaCBidXQgdW5mb3J0dW5hdGVseSBpdCBicmVha3Mg Zm9yIFJJU0MtVi4KPiA+ID4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9vZi9wcm9wZXJ0 eS5jIHwgMTYgKysrKysrKysrKysrKystLQo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL29mL3Byb3BlcnR5LmMgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4gPiBpbmRl eCAxYzgzZTY4ZjgwNWIuLjlhZGViYzYzYmVhOSAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJz L29mL3Byb3BlcnR5LmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4g PiBAQCAtMTMyMiw3ICsxMzIyLDEzIEBAIHN0YXRpYyBzdHJ1Y3QgZGV2aWNlX25vZGUgKnBhcnNl X2ludGVycnVwdF9tYXAoc3RydWN0IGRldmljZV9ub2RlICpucCwKPiA+ID4gPiAgICAgICAgIGFk ZHJjZWxscyA9IG9mX2J1c19uX2FkZHJfY2VsbHMobnApOwo+ID4gPiA+Cj4gPiA+ID4gICAgICAg ICBpbWFwID0gb2ZfZ2V0X3Byb3BlcnR5KG5wLCAiaW50ZXJydXB0LW1hcCIsICZpbWFwbGVuKTsK PiA+ID4gPiAtICAgICAgIGlmICghaW1hcCB8fCBpbWFwbGVuIDw9IChhZGRyY2VsbHMgKyBpbnRj ZWxscykpCj4gPiA+ID4gKyAgICAgICBpbWFwbGVuIC89IHNpemVvZigqaW1hcCk7Cj4gPiA+ID4g Kwo+ID4gPiA+ICsgICAgICAgLyoKPiA+ID4gPiArICAgICAgICAqIENoZWNrIHRoYXQgd2UgaGF2 ZSBlbm91Z2ggcnVud2F5IGZvciB0aGUgY2hpbGQgdW5pdCBpbnRlcnJ1cHQKPiA+ID4gPiArICAg ICAgICAqIHNwZWNpZmllciBhbmQgYSBwaGFuZGxlLiBUaGF0J3MgdGhlIGJhcmUgbWluaW11bSB3 ZSBjYW4gZXhwZWN0Lgo+ID4gPiA+ICsgICAgICAgICovCj4gPiA+ID4gKyAgICAgICBpZiAoIWlt YXAgfHwgaW1hcGxlbiA8PSAoYWRkcmNlbGxzICsgaW50Y2VsbHMgKyAxKSkKPiA+ID4gPiAgICAg ICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gPiA+ID4gICAgICAgICBpbWFwX2VuZCA9IGltYXAg KyBpbWFwbGVuOwo+ID4gPiA+Cj4gPiA+ID4gQEAgLTEzNDYsOCArMTM1MiwxNCBAQCBzdGF0aWMg c3RydWN0IGRldmljZV9ub2RlICpwYXJzZV9pbnRlcnJ1cHRfbWFwKHN0cnVjdCBkZXZpY2Vfbm9k ZSAqbnAsCj4gPiA+ID4gICAgICAgICAgICAgICAgIGlmICghaW5kZXgpCj4gPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgcmV0dXJuIHN1cF9hcmdzLm5wOwo+ID4gPiA+Cj4gPiA+ID4gLSAg ICAgICAgICAgICAgIG9mX25vZGVfcHV0KHN1cF9hcmdzLm5wKTsKPiA+ID4gPiArICAgICAgICAg ICAgICAgLyoKPiA+ID4gPiArICAgICAgICAgICAgICAgICogQWNjb3VudCBmb3IgdGhlIGZ1bGwg cGFyZW50IHVuaXQgaW50ZXJydXB0IHNwZWNpZmllcgo+ID4gPiA+ICsgICAgICAgICAgICAgICAg KiAoYWRkcmVzcyBjZWxscywgaW50ZXJydXB0IGNlbGxzLCBhbmQgcGhhbmRsZSkuCj4gPiA+ID4g KyAgICAgICAgICAgICAgICAqLwo+ID4gPiA+ICsgICAgICAgICAgICAgICBpbWFwICs9IG9mX2J1 c19uX2FkZHJfY2VsbHMoc3VwX2FyZ3MubnApOwo+ID4gPgo+ID4gPiBUaGlzIGJyZWFrcyBmb3Ig UklTQy1WIGJlY2F1c2Ugd2UgZG9uJ3QgaGF2ZSAiI2FkZHJlc3MtY2VsbHMiCj4gPiA+IHByb3Bl cnR5IGluIGludGVycnVwdCBjb250cm9sbGVyIERUIG5vZGUgYW5kIG9mX2J1c19uX2FkZHJfY2Vs bHMoKQo+ID4gPiByZXRyaWV2ZXMgIiNhZGRyZXNzLWNlbGxzIiBmcm9tIHRoZSBwYXJlbnQgb2Yg aW50ZXJydXB0IGNvbnRyb2xsZXIuCj4gPgo+ID4gVGhhdCdzIGEgZmVhdHVyZSwgbm90IGEgYnVn LiAjYWRkcmVzcy1jZWxscywgQUZBSUNULCBhcHBsaWVzIHRvIGFsbAo+ID4gY2hpbGQgbm9kZXMg dW50aWwgeW91IHNldCBpdCBvdGhlcndpc2UuCj4gPgo+ID4gPgo+ID4gPiBUaGUgb2ZfaXJxX3Bh cnNlX3JhdygpIGxvb2tzIGZvciAiI2FkZHJlc3MtY2VsbHMiIHByb3BlcnR5Cj4gPiA+IGluIHRo ZSBpbnRlcnJ1cHQgY29udHJvbGxlciBEVCBub2RlIG9ubHkgc28gd2Ugc2hvdWxkIGRvIGEKPiA+ ID4gc2ltaWxhciB0aGluZyBoZXJlIGFzIHdlbGwuCj4gPgo+ID4gVGhpcyBsb29rcyBtb3JlIGxp a2UgYSBvZl9pcnFfcGFyc2VfcmF3KCkgYnVnIHRoYW4gYW55dGhpbmcgZWxzZS4KPiAKPiBJZiB3 ZSBjaGFuZ2Ugb2ZfaXJxX3BhcnNlX3JhdygpIHRvIHVzZSBvZl9idXNfbl9hZGRyX2NlbGxzKCkK PiB0aGVuIGl0IHdvdWxkIHN0aWxsIGJyZWFrIGZvciBSSVNDLVYuCgpJJ20gbm90IHRyeWluZyB0 byAiZml4IiByaXNjdi4gSSdtIG1lcmVseSBvdXRsaW5pbmcgdGhhdCB5b3UgYXJlCnJlbHlpbmcg b24gYm90aCBicm9rZW4gRFRzIGFuZCBhIGJ1Z2d5IE9TLgoKPiAKPiBVc2luZyBvZl9idXNfbl9h ZGRyX2NlbGxzKCkgb3ZlciBoZXJlIGZvcmNlcyBpbnRlcnJ1cHQgY29udHJvbGxlcgo+IERUIG5v ZGVzIHRvIGhhdmUgYSAiI2FkZHJlc3MtY2VsbHMiIERUIHByb3BlcnR5LiBUaGVyZSBhcmUgbWFu eQo+IGludGVycnVwdCBjb250cm9sbGVyIChlLmcuIFJJU0MtViBQTElDIG9yIFJJU0MtViBBUExJ Qykgd2hlcmUgdGhlCj4gRFQgYmluZGluZ3MgZG9uJ3QgcmVxdWlyZSAiI2FkZHJlc3MtY2VsbHMi IERUIHByb3BlcnR5IGFuZCBleGlzdGluZwo+IERUUyBmaWxlcyB3aXRoIHN1Y2ggaW50ZXJydXB0 IGNvbnRyb2xsZXJzIGRvbid0IGhhdmUgaXQgZWl0aGVyLgoKSXQgZm9yY2VzIHlvdSB0byBzZXQg I2FkZHJlc3MtY2VsbHMgKmlmIHlvdSByZWx5IG9uIGEgZGlmZmVyZW50CnZhbHVlIGluIGEgY2hp bGQgbm9kZSouIEl0J3Mgbm90IGxpa2UgdGhlIHNlbWFudGljcyBhcmUgbmV3LgoKPiAKPiBJbiB0 aGUgUklTQy1WIHdvcmxkLCB0aGVyZSBoYXZlIGJlZW4gcXVpdGUgYSBmZXcgUUVNVSByZWxlYXNl cwo+IHdoZXJlIHRoZSBnZW5lcmF0ZWQgRFQgbm9kZSBvZiB0aGUgaW50ZXJydXB0IGNvbnRyb2xs ZXIgZG9lcyBub3QKPiBoYXZlIHRoZSAiI2FkZHJlc3MtY2VsbHMiIHByb3BlcnR5LiBUaGlzIHBh dGNoIGJyZWFrcyB0aGUga2VybmVsCj4gZm9yIGFsbCBzdWNoIFFFTVUgcmVsZWFzZXMuCgpDb25n cmF0dWxhdGlvbnMsIHlvdSd2ZSBmb3JrZWQgRFQuIE5ld3MgYXQgMTEuCgo+IAo+IEkgdGhpbmsg d2Ugc2hvdWxkIGFsaWduIHRoZSBpbXBsZW1lbnRhdGlvbiBpbiBwYXJzZV9pbnRlcnJ1cHRfbWFw KCkKPiB3aXRoIG9mX2lycV9wYXJzZV9yYXcoKSBhbmQgdXNlIG9mX3Byb3BlcnR5X3JlYWRfdTMy KCkgaW5zdGVhZCBvZgo+IG9mX2J1c19uX2FkZHJfY2VsbHMoKS4KCkkgdGhpbmsgd2Ugc2hvdWxk IGZpeCB0aGUga2VybmVsIGFuZCBxdWlyayByaXNjdiBhcyBicm9rZW4sIGp1c3QgbGlrZQpQUEMg b3Igc3BhcmMuCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9n cmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A969C27C43 for ; Wed, 29 May 2024 10:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jrhf6T15bQZL3Al0Bf49+A1loe4xLhMJP68fr5o1yG4=; b=riNb5VVrzFdXu9 INAIVj15qkpj3cDF1HPG++LcVrKRRV3Krxz+VpFcxR5FL1Pw32skXdqliCyRHjIO/ughvcKhBU2JE 9TBIF+9AjNLRKg6qgRINgetznjFmzv3LVujG5g62+lgIBZB9LAz3ZB8m2LTBhOIb94PQV0JTWlU2/ HPQ8x4FCxrXbnqpxckvCJkdPUJb94JR4IBjUvCReDoarFQClVOIJhikShiep8uhsfSMqpRvQ36mZn 89XuowogSxO5BbKpjy4wLaCliTTMAYMyRUNh7HAZ41/97skuja5nU/bJw/nUIXzFYZajLAOtJR105 3yulJoUrydf/vpUxGYEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCGnq-00000003qi7-2C7c; Wed, 29 May 2024 10:45:06 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCGnn-00000003qgo-2bEp; Wed, 29 May 2024 10:45:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2182462833; Wed, 29 May 2024 10:45:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4C70C2BD10; Wed, 29 May 2024 10:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716979502; bh=DChLerdywJ2VIfY90QcVmGj9zaM+zQADMtga2RWsg0Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GD0/hxXtID9qZ90DSquWe/Fen/Gej2oChC8r3GtEMxqdKZvfQ6AJWzgvAKFGY1cmd 7Bgj5x5WYfBCvTnMDGX7CNpQUQy1WsyjprmxlOgUDyYjslR9pKLe10EFwMoqtXHK/a 8nvEwZw5VNk3Yxrcr7n6Gtn20NUSJYKiAEBs8HPF+2920QjKXmpAza4QonkVLMTFg3 LC268LGiZhqMzrKzwsfrvgrsKUGoE4bFjrCyOuSbu6m+nxeh1JASoZlDzNYjBT3V2e 9NdxbqNunYQ+0jJF3YQOIbTbGDZTBdNTFoeX4LunEbjdlhJn1SIawQx0rzvd4bfj52 elVro26NwU8NA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCGnj-00GaQE-KB; Wed, 29 May 2024 11:45:00 +0100 Date: Wed, 29 May 2024 11:44:58 +0100 Message-ID: <86a5k8nbh1.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> <86bk4pm8j1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_034503_773577_DF3A8F22 X-CRM114-Status: GOOD ( 47.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBNYXkgMjAyNCAxMToxNjozMCArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIFdlZCwgTWF5IDI5LCAyMDI0IGF0IDEyOjAz 4oCvUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gV2Vk LCAyOSBNYXkgMjAyNCAwNjoxNTo1MiArMDEwMCwKPiA+IEFudXAgUGF0ZWwgPGFwYXRlbEB2ZW50 YW5hbWljcm8uY29tPiB3cm90ZToKPiA+ID4KPiA+ID4gT24gVHVlLCBNYXkgMjgsIDIwMjQgYXQg MTA6MTHigK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gPgo+ ID4gPiA+IENvbW1pdCBkOTc2YzZmNGIzMmMgKCJvZjogcHJvcGVydHk6IEFkZCBmd19kZXZsaW5r IHN1cHBvcnQgZm9yCj4gPiA+ID4gaW50ZXJydXB0LW1hcCBwcm9wZXJ0eSIpIHRyaWVkIHRvIGRv IHdoYXQgaXQgc2F5cyBvbiB0aGUgdGluLAo+ID4gPiA+IGJ1dCBmYWlsZWQgb24gYSBjb3VwbGUg b2YgcG9pbnRzOgo+ID4gPiA+Cj4gPiA+ID4gLSBpdCBjb25mdXNlcyBieXRlcyBhbmQgY2VsbHMu IE5vdCBhIGh1Z2UgZGVhbCwgZXhjZXB0IHdoZW4gaXQKPiA+ID4gPiAgIGNvbWVzIHRvIHBvaW50 ZXIgYXJpdGhtZXRpYwo+ID4gPiA+Cj4gPiA+ID4gLSBpdCBkb2Vzbid0IHJlYWxseSBoYW5kbGUg YW55dGhpbmcgYnV0IGludGVycnVwdC1tYXBzIHRoYXQgaGF2ZQo+ID4gPiA+ICAgdGhlaXIgcGFy ZW50ICNhZGRyZXNzLWNlbGxzIHNldCB0byAwCj4gPiA+ID4KPiA+ID4gPiBUaGUgY29tYmluYXRp b25zIG9mIHRoZSB0d28gbGVhZHMgdG8gc29tZSBzZXJpb3VzIGZ1biBvbiBteSBNMQo+ID4gPiA+ IGJveCwgd2l0aCBwbGVudHkgb2YgV0FSTi1PTigpIGZpcmluZyBhbGwgb3ZlciB0aGUgc2hvcCwg YW5kCj4gPiA+ID4gYW11c2luZyB2YWx1ZXMgYmVpbmcgZ2VuZXJhdGVkIGZvciBpbnRlcnJ1cHQg c3BlY2lmaWVycy4KPiA+ID4gPgo+ID4gPiA+IEFkZHJlc3MgYm90aCBpc3N1ZXMgc28gdGhhdCBJ IGNhbiBib290IG15IG1hY2hpbmVzIGFnYWluLgo+ID4gPiA+Cj4gPiA+ID4gRml4ZXM6IGQ5NzZj NmY0YjMyYyAoIm9mOiBwcm9wZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IgaW50ZXJy dXB0LW1hcCBwcm9wZXJ0eSIpCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTWFyYyBaeW5naWVyIDxt YXpAa2VybmVsLm9yZz4KPiA+ID4gPiBDYzogQW51cCBQYXRlbCA8YXBhdGVsQHZlbnRhbmFtaWNy by5jb20+Cj4gPiA+ID4gQ2M6IFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2dsZS5jb20+ Cj4gPiA+ID4gQ2M6IFJvYiBIZXJyaW5nIChBcm0pIDxyb2JoQGtlcm5lbC5vcmc+Cj4gPiA+Cj4g PiA+IFRoYW5rcyBmb3IgdGhlIGZpeCBwYXRjaCBidXQgdW5mb3J0dW5hdGVseSBpdCBicmVha3Mg Zm9yIFJJU0MtVi4KPiA+ID4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9vZi9wcm9wZXJ0 eS5jIHwgMTYgKysrKysrKysrKysrKystLQo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL29mL3Byb3BlcnR5LmMgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4gPiBpbmRl eCAxYzgzZTY4ZjgwNWIuLjlhZGViYzYzYmVhOSAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJz L29mL3Byb3BlcnR5LmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+ID4g PiBAQCAtMTMyMiw3ICsxMzIyLDEzIEBAIHN0YXRpYyBzdHJ1Y3QgZGV2aWNlX25vZGUgKnBhcnNl X2ludGVycnVwdF9tYXAoc3RydWN0IGRldmljZV9ub2RlICpucCwKPiA+ID4gPiAgICAgICAgIGFk ZHJjZWxscyA9IG9mX2J1c19uX2FkZHJfY2VsbHMobnApOwo+ID4gPiA+Cj4gPiA+ID4gICAgICAg ICBpbWFwID0gb2ZfZ2V0X3Byb3BlcnR5KG5wLCAiaW50ZXJydXB0LW1hcCIsICZpbWFwbGVuKTsK PiA+ID4gPiAtICAgICAgIGlmICghaW1hcCB8fCBpbWFwbGVuIDw9IChhZGRyY2VsbHMgKyBpbnRj ZWxscykpCj4gPiA+ID4gKyAgICAgICBpbWFwbGVuIC89IHNpemVvZigqaW1hcCk7Cj4gPiA+ID4g Kwo+ID4gPiA+ICsgICAgICAgLyoKPiA+ID4gPiArICAgICAgICAqIENoZWNrIHRoYXQgd2UgaGF2 ZSBlbm91Z2ggcnVud2F5IGZvciB0aGUgY2hpbGQgdW5pdCBpbnRlcnJ1cHQKPiA+ID4gPiArICAg ICAgICAqIHNwZWNpZmllciBhbmQgYSBwaGFuZGxlLiBUaGF0J3MgdGhlIGJhcmUgbWluaW11bSB3 ZSBjYW4gZXhwZWN0Lgo+ID4gPiA+ICsgICAgICAgICovCj4gPiA+ID4gKyAgICAgICBpZiAoIWlt YXAgfHwgaW1hcGxlbiA8PSAoYWRkcmNlbGxzICsgaW50Y2VsbHMgKyAxKSkKPiA+ID4gPiAgICAg ICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gPiA+ID4gICAgICAgICBpbWFwX2VuZCA9IGltYXAg KyBpbWFwbGVuOwo+ID4gPiA+Cj4gPiA+ID4gQEAgLTEzNDYsOCArMTM1MiwxNCBAQCBzdGF0aWMg c3RydWN0IGRldmljZV9ub2RlICpwYXJzZV9pbnRlcnJ1cHRfbWFwKHN0cnVjdCBkZXZpY2Vfbm9k ZSAqbnAsCj4gPiA+ID4gICAgICAgICAgICAgICAgIGlmICghaW5kZXgpCj4gPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgcmV0dXJuIHN1cF9hcmdzLm5wOwo+ID4gPiA+Cj4gPiA+ID4gLSAg ICAgICAgICAgICAgIG9mX25vZGVfcHV0KHN1cF9hcmdzLm5wKTsKPiA+ID4gPiArICAgICAgICAg ICAgICAgLyoKPiA+ID4gPiArICAgICAgICAgICAgICAgICogQWNjb3VudCBmb3IgdGhlIGZ1bGwg cGFyZW50IHVuaXQgaW50ZXJydXB0IHNwZWNpZmllcgo+ID4gPiA+ICsgICAgICAgICAgICAgICAg KiAoYWRkcmVzcyBjZWxscywgaW50ZXJydXB0IGNlbGxzLCBhbmQgcGhhbmRsZSkuCj4gPiA+ID4g KyAgICAgICAgICAgICAgICAqLwo+ID4gPiA+ICsgICAgICAgICAgICAgICBpbWFwICs9IG9mX2J1 c19uX2FkZHJfY2VsbHMoc3VwX2FyZ3MubnApOwo+ID4gPgo+ID4gPiBUaGlzIGJyZWFrcyBmb3Ig UklTQy1WIGJlY2F1c2Ugd2UgZG9uJ3QgaGF2ZSAiI2FkZHJlc3MtY2VsbHMiCj4gPiA+IHByb3Bl cnR5IGluIGludGVycnVwdCBjb250cm9sbGVyIERUIG5vZGUgYW5kIG9mX2J1c19uX2FkZHJfY2Vs bHMoKQo+ID4gPiByZXRyaWV2ZXMgIiNhZGRyZXNzLWNlbGxzIiBmcm9tIHRoZSBwYXJlbnQgb2Yg aW50ZXJydXB0IGNvbnRyb2xsZXIuCj4gPgo+ID4gVGhhdCdzIGEgZmVhdHVyZSwgbm90IGEgYnVn LiAjYWRkcmVzcy1jZWxscywgQUZBSUNULCBhcHBsaWVzIHRvIGFsbAo+ID4gY2hpbGQgbm9kZXMg dW50aWwgeW91IHNldCBpdCBvdGhlcndpc2UuCj4gPgo+ID4gPgo+ID4gPiBUaGUgb2ZfaXJxX3Bh cnNlX3JhdygpIGxvb2tzIGZvciAiI2FkZHJlc3MtY2VsbHMiIHByb3BlcnR5Cj4gPiA+IGluIHRo ZSBpbnRlcnJ1cHQgY29udHJvbGxlciBEVCBub2RlIG9ubHkgc28gd2Ugc2hvdWxkIGRvIGEKPiA+ ID4gc2ltaWxhciB0aGluZyBoZXJlIGFzIHdlbGwuCj4gPgo+ID4gVGhpcyBsb29rcyBtb3JlIGxp a2UgYSBvZl9pcnFfcGFyc2VfcmF3KCkgYnVnIHRoYW4gYW55dGhpbmcgZWxzZS4KPiAKPiBJZiB3 ZSBjaGFuZ2Ugb2ZfaXJxX3BhcnNlX3JhdygpIHRvIHVzZSBvZl9idXNfbl9hZGRyX2NlbGxzKCkK PiB0aGVuIGl0IHdvdWxkIHN0aWxsIGJyZWFrIGZvciBSSVNDLVYuCgpJJ20gbm90IHRyeWluZyB0 byAiZml4IiByaXNjdi4gSSdtIG1lcmVseSBvdXRsaW5pbmcgdGhhdCB5b3UgYXJlCnJlbHlpbmcg b24gYm90aCBicm9rZW4gRFRzIGFuZCBhIGJ1Z2d5IE9TLgoKPiAKPiBVc2luZyBvZl9idXNfbl9h ZGRyX2NlbGxzKCkgb3ZlciBoZXJlIGZvcmNlcyBpbnRlcnJ1cHQgY29udHJvbGxlcgo+IERUIG5v ZGVzIHRvIGhhdmUgYSAiI2FkZHJlc3MtY2VsbHMiIERUIHByb3BlcnR5LiBUaGVyZSBhcmUgbWFu eQo+IGludGVycnVwdCBjb250cm9sbGVyIChlLmcuIFJJU0MtViBQTElDIG9yIFJJU0MtViBBUExJ Qykgd2hlcmUgdGhlCj4gRFQgYmluZGluZ3MgZG9uJ3QgcmVxdWlyZSAiI2FkZHJlc3MtY2VsbHMi IERUIHByb3BlcnR5IGFuZCBleGlzdGluZwo+IERUUyBmaWxlcyB3aXRoIHN1Y2ggaW50ZXJydXB0 IGNvbnRyb2xsZXJzIGRvbid0IGhhdmUgaXQgZWl0aGVyLgoKSXQgZm9yY2VzIHlvdSB0byBzZXQg I2FkZHJlc3MtY2VsbHMgKmlmIHlvdSByZWx5IG9uIGEgZGlmZmVyZW50CnZhbHVlIGluIGEgY2hp bGQgbm9kZSouIEl0J3Mgbm90IGxpa2UgdGhlIHNlbWFudGljcyBhcmUgbmV3LgoKPiAKPiBJbiB0 aGUgUklTQy1WIHdvcmxkLCB0aGVyZSBoYXZlIGJlZW4gcXVpdGUgYSBmZXcgUUVNVSByZWxlYXNl cwo+IHdoZXJlIHRoZSBnZW5lcmF0ZWQgRFQgbm9kZSBvZiB0aGUgaW50ZXJydXB0IGNvbnRyb2xs ZXIgZG9lcyBub3QKPiBoYXZlIHRoZSAiI2FkZHJlc3MtY2VsbHMiIHByb3BlcnR5LiBUaGlzIHBh dGNoIGJyZWFrcyB0aGUga2VybmVsCj4gZm9yIGFsbCBzdWNoIFFFTVUgcmVsZWFzZXMuCgpDb25n cmF0dWxhdGlvbnMsIHlvdSd2ZSBmb3JrZWQgRFQuIE5ld3MgYXQgMTEuCgo+IAo+IEkgdGhpbmsg d2Ugc2hvdWxkIGFsaWduIHRoZSBpbXBsZW1lbnRhdGlvbiBpbiBwYXJzZV9pbnRlcnJ1cHRfbWFw KCkKPiB3aXRoIG9mX2lycV9wYXJzZV9yYXcoKSBhbmQgdXNlIG9mX3Byb3BlcnR5X3JlYWRfdTMy KCkgaW5zdGVhZCBvZgo+IG9mX2J1c19uX2FkZHJfY2VsbHMoKS4KCkkgdGhpbmsgd2Ugc2hvdWxk IGZpeCB0aGUga2VybmVsIGFuZCBxdWlyayByaXNjdiBhcyBicm9rZW4sIGp1c3QgbGlrZQpQUEMg b3Igc3BhcmMuCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9n cmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26E901804F; Wed, 29 May 2024 10:45:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716979503; cv=none; b=Latp6u6XSB5h/5+WlHdIjeWLiUyqq4Eq7UrqWMWkysQqbhXcrwEUY0QyHX/yRIjTQXd2jN7e7atw6SWPn5Us83lsN2qF+2mNdmwDJJUEbvvpHofm3XxIiS9wW+d5/b7wqgWroj5qomTE/6jKEV6+popsMJDoDBOqzmKguhW7XRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716979503; c=relaxed/simple; bh=DChLerdywJ2VIfY90QcVmGj9zaM+zQADMtga2RWsg0Q=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=GMQsN9/j2gTZ59avEfdxNlWStP3tKhOhegVNwhRrV+F7vSmEScPUCm5iPFcIocSNR7UsnFW5uSNShK0fROcgOz72DJo2NlqkAPx2FaDWLUkHkvY/ZKd1MVc1HM8j5fogz5JlZwkzrgLU7SjBu+C1LdZRX1vM+A70cT/1Ex5L0kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GD0/hxXt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GD0/hxXt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4C70C2BD10; Wed, 29 May 2024 10:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716979502; bh=DChLerdywJ2VIfY90QcVmGj9zaM+zQADMtga2RWsg0Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GD0/hxXtID9qZ90DSquWe/Fen/Gej2oChC8r3GtEMxqdKZvfQ6AJWzgvAKFGY1cmd 7Bgj5x5WYfBCvTnMDGX7CNpQUQy1WsyjprmxlOgUDyYjslR9pKLe10EFwMoqtXHK/a 8nvEwZw5VNk3Yxrcr7n6Gtn20NUSJYKiAEBs8HPF+2920QjKXmpAza4QonkVLMTFg3 LC268LGiZhqMzrKzwsfrvgrsKUGoE4bFjrCyOuSbu6m+nxeh1JASoZlDzNYjBT3V2e 9NdxbqNunYQ+0jJF3YQOIbTbGDZTBdNTFoeX4LunEbjdlhJn1SIawQx0rzvd4bfj52 elVro26NwU8NA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCGnj-00GaQE-KB; Wed, 29 May 2024 11:45:00 +0100 Date: Wed, 29 May 2024 11:44:58 +0100 Message-ID: <86a5k8nbh1.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> <86bk4pm8j1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 29 May 2024 11:16:30 +0100, Anup Patel wrote: >=20 > On Wed, May 29, 2024 at 12:03=E2=80=AFPM Marc Zyngier wr= ote: > > > > On Wed, 29 May 2024 06:15:52 +0100, > > Anup Patel wrote: > > > > > > On Tue, May 28, 2024 at 10:11=E2=80=AFPM Marc Zyngier wrote: > > > > > > > > Commit d976c6f4b32c ("of: property: Add fw_devlink support for > > > > interrupt-map property") tried to do what it says on the tin, > > > > but failed on a couple of points: > > > > > > > > - it confuses bytes and cells. Not a huge deal, except when it > > > > comes to pointer arithmetic > > > > > > > > - it doesn't really handle anything but interrupt-maps that have > > > > their parent #address-cells set to 0 > > > > > > > > The combinations of the two leads to some serious fun on my M1 > > > > box, with plenty of WARN-ON() firing all over the shop, and > > > > amusing values being generated for interrupt specifiers. > > > > > > > > Address both issues so that I can boot my machines again. > > > > > > > > Fixes: d976c6f4b32c ("of: property: Add fw_devlink support for inte= rrupt-map property") > > > > Signed-off-by: Marc Zyngier > > > > Cc: Anup Patel > > > > Cc: Saravana Kannan > > > > Cc: Rob Herring (Arm) > > > > > > Thanks for the fix patch but unfortunately it breaks for RISC-V. > > > > > > > --- > > > > drivers/of/property.c | 16 ++++++++++++++-- > > > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > > index 1c83e68f805b..9adebc63bea9 100644 > > > > --- a/drivers/of/property.c > > > > +++ b/drivers/of/property.c > > > > @@ -1322,7 +1322,13 @@ static struct device_node *parse_interrupt_m= ap(struct device_node *np, > > > > addrcells =3D of_bus_n_addr_cells(np); > > > > > > > > imap =3D of_get_property(np, "interrupt-map", &imaplen); > > > > - if (!imap || imaplen <=3D (addrcells + intcells)) > > > > + imaplen /=3D sizeof(*imap); > > > > + > > > > + /* > > > > + * Check that we have enough runway for the child unit inte= rrupt > > > > + * specifier and a phandle. That's the bare minimum we can = expect. > > > > + */ > > > > + if (!imap || imaplen <=3D (addrcells + intcells + 1)) > > > > return NULL; > > > > imap_end =3D imap + imaplen; > > > > > > > > @@ -1346,8 +1352,14 @@ static struct device_node *parse_interrupt_m= ap(struct device_node *np, > > > > if (!index) > > > > return sup_args.np; > > > > > > > > - of_node_put(sup_args.np); > > > > + /* > > > > + * Account for the full parent unit interrupt speci= fier > > > > + * (address cells, interrupt cells, and phandle). > > > > + */ > > > > + imap +=3D of_bus_n_addr_cells(sup_args.np); > > > > > > This breaks for RISC-V because we don't have "#address-cells" > > > property in interrupt controller DT node and of_bus_n_addr_cells() > > > retrieves "#address-cells" from the parent of interrupt controller. > > > > That's a feature, not a bug. #address-cells, AFAICT, applies to all > > child nodes until you set it otherwise. > > > > > > > > The of_irq_parse_raw() looks for "#address-cells" property > > > in the interrupt controller DT node only so we should do a > > > similar thing here as well. > > > > This looks more like a of_irq_parse_raw() bug than anything else. >=20 > If we change of_irq_parse_raw() to use of_bus_n_addr_cells() > then it would still break for RISC-V. I'm not trying to "fix" riscv. I'm merely outlining that you are relying on both broken DTs and a buggy OS. >=20 > Using of_bus_n_addr_cells() over here forces interrupt controller > DT nodes to have a "#address-cells" DT property. There are many > interrupt controller (e.g. RISC-V PLIC or RISC-V APLIC) where the > DT bindings don't require "#address-cells" DT property and existing > DTS files with such interrupt controllers don't have it either. It forces you to set #address-cells *if you rely on a different value in a child node*. It's not like the semantics are new. >=20 > In the RISC-V world, there have been quite a few QEMU releases > where the generated DT node of the interrupt controller does not > have the "#address-cells" property. This patch breaks the kernel > for all such QEMU releases. Congratulations, you've forked DT. News at 11. >=20 > I think we should align the implementation in parse_interrupt_map() > with of_irq_parse_raw() and use of_property_read_u32() instead of > of_bus_n_addr_cells(). I think we should fix the kernel and quirk riscv as broken, just like PPC or sparc. M. --=20 Without deviation from the norm, progress is not possible.