From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor) Date: Sat, 27 Dec 2014 09:18:45 -0800 Message-ID: <86a929ypsa.fsf@hiro.keithp.com> References: <544F885B.9030206@gmail.com> <1418940218.6596.49.camel@gmail.com> <1419552090.3950.3.camel@gmail.com> <549CB954.9060602@daenzer.net> <1419563434.3950.9.camel@gmail.com> <549CD359.1020608@daenzer.net> <1419594203.1679.1.camel@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2134625650==" Return-path: In-Reply-To: <1419594203.1679.1.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xorg-devel-bounces-go0+a7rfsptAfugRpC6u6w@public.gmane.org Sender: "xorg-devel" To: Kertesz Laszlo , Michel =?utf-8?Q?D=C3=A4nze?= =?utf-8?Q?r?= Cc: "List, X.Org" , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============2134625650== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Kertesz Laszlo writes: > Ok, rebuilt the xserver package with debugging symbols (seems that > checkinstall strips stuff by default). I got a bigger gdb.txt. See if it > helps. I found a bug -- glamor_xv_put_image was mis-computing the number of lines of changed video when the client drew only a subset of the image. I think the client is drawing at src_y=1, src_h=239 for some weird reason (I suspect a bug in the client). Try this patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-glamor-Fix-nlines-in-glamor_xv_put_image-when-src_y-.patch Content-Transfer-Encoding: quoted-printable From=20eaa4225413b31314070f9a52d9290649e79a3b0f Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Sat, 27 Dec 2014 09:11:33 -0800 Subject: [PATCH] glamor: Fix nlines in glamor_xv_put_image when src_y is odd The number of lines of video to update in the texture needs to be computed from the height of the updated source, not the full height of the source. Signed-off-by: Keith Packard =2D-- glamor/glamor_xv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_xv.c b/glamor/glamor_xv.c index 1c877da..83e24ad 100644 =2D-- a/glamor/glamor_xv.c +++ b/glamor/glamor_xv.c @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv, } =20 top =3D (src_y) & ~1; =2D nlines =3D (src_y + height) - top; + nlines =3D (src_y + src_h) - top; =20 switch (id) { case FOURCC_YV12: =2D-=20 2.1.4 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 keith.packard-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUBVJ7p+NsiGmkAAAARAQgRABAAjoaO47iUypRzqOYnY/48KRsgT7QI9XBy U92ZY5QvnhDiRUEHJjWZVrGNKP6h6BGAM0RrEvPgLGWUaAeqwUd88jcQaOQO2c5m 0I39qwLkjVg2zIrVc/NzeERU0Uk8VTxQ2ugFmiUwy8gLFHK+GXdiYzA+x0zIZEFl xbKq2hcJGTlJdoZWpWXTw4Cj69K9E6B1BG8iAtpq0BfyEkh5wWIkGZ2zF3yHC9c3 gpUs3w4pIFqRygEwoTw5HB0Lu22OAEpZ2xaHhFSN5XZuybkNWjTxRSceMAJ6k0xe 91z8CPX6AzZ7/xO8KhtW/sOj7EI7bu/qn/W+smRKTUNIJqxToCfk1+iJHkU+CXsw AwYp3sn4t7p1gl/UjESNxJNjNeq6LOoeJR7gaFQVE1QonP630NrL5/R+1yu40tgf wMKjaPn9SaKHFV3qYfkhGCViKMk47d8tACoD6UhVxGQZQxWlYHlwtN29r8xU628L owcFaILxFYQ3n+7wDzahE9FbBR04dbRa1Q5N8W0oS75boXXBp162DaJwB/fcdbb5 lQHA+3/AtRcwaSeCX541VQanWFuGp1hmVNz2E5l1KKBS+ZvLxf+LNmQpwevGINaR zVFAVe7sHO0oYoBQ8LWXF5S9V24LUj4riEakDmE9XQyOpCq62yJF5IIu11foed/z A247N+exkBo= =4B+0 -----END PGP SIGNATURE----- --==-=-=-- --===============2134625650== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KeG9yZy1kZXZl bEBsaXN0cy54Lm9yZzogWC5PcmcgZGV2ZWxvcG1lbnQKQXJjaGl2ZXM6IGh0dHA6Ly9saXN0cy54 Lm9yZy9hcmNoaXZlcy94b3JnLWRldmVsCkluZm86IGh0dHA6Ly9saXN0cy54Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hvcmctZGV2ZWw= --===============2134625650==--