All of lore.kernel.org
 help / color / mirror / Atom feed
From: merlyn@stonehenge.com (Randal L. Schwartz)
To: Robert Schiele <rschiele@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] change Perl syntax to support Perl 5.6
Date: Sun, 31 Aug 2008 06:35:42 -0700	[thread overview]
Message-ID: <86abetnw7l.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <20080830173947.GF7185@schiele.dyndns.org> (Robert Schiele's message of "Sat, 30 Aug 2008 19:39:47 +0200")

>>>>> "Robert" == Robert Schiele <rschiele@gmail.com> writes:
Robert> -		open($fh, '-|', @_) or die;
Robert> +		open($fh, '-|', join(' ', @_)) or die;

No.  This is dangerous.

If you want 5.6 equivalent code, you'll have to use something
that deals with the explicit fork() of open($fh, '-|').

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc.
See http://methodsandmessages.vox.com/ for Smalltalk and Seaside discussion

  parent reply	other threads:[~2008-08-31 14:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30 17:39 [PATCH] change Perl syntax to support Perl 5.6 Robert Schiele
2008-08-30 18:00 ` Jeff King
2008-08-30 18:06   ` Junio C Hamano
2008-08-30 18:13     ` Jeff King
2008-08-30 18:34     ` Robert Schiele
2008-08-30 18:39       ` Jeff King
2008-08-30 20:37         ` Jakub Narebski
2008-08-30 21:21           ` Robert Schiele
2008-08-31  5:35           ` Avery Pennarun
2008-08-31 13:37             ` Randal L. Schwartz
2008-08-31 16:27               ` Junio C Hamano
2008-08-31 18:29                 ` Avery Pennarun
2008-08-31 20:23                   ` Jakub Narebski
2008-08-31 20:34                     ` Petr Baudis
2008-09-01  3:57                       ` H. Peter Anvin
2008-09-01  4:22                         ` Robert Schiele
2008-09-01 13:06                           ` Tom G. Christensen
2008-09-04 17:28                             ` Brandon Casey
2008-09-05  6:34                               ` Tom G. Christensen
2008-08-31 20:55                     ` Jakub Narebski
2008-09-01  1:52             ` Jay Soffian
2008-09-01 21:42             ` Alex Riesen
2008-09-02  0:23               ` Avery Pennarun
2008-09-02 17:50                 ` Avery Pennarun
2008-08-30 20:20       ` Junio C Hamano
2008-08-31 13:35 ` Randal L. Schwartz [this message]
2008-08-31 19:54 ` Ask Bjørn Hansen
2008-09-01  1:22   ` Junio C Hamano
2008-09-01  1:48     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86abetnw7l.fsf@blue.stonehenge.com \
    --to=merlyn@stonehenge.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rschiele@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.