From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB6C753A7 for ; Thu, 6 Mar 2025 00:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741220796; cv=none; b=anqxMa9fDQs1Cfy+6CtT733FGflpq+TTp13lqySwcrbuddEEEGQAK3tszc6BX8nMm0FsvDOQAEWlP9k2qehjPRaurqyKPuuc6gnnaZVRD/MLc1gMc9wE3CaJFyvlIyl6w2qRjVIRyPYkng+xyJOkJXCnI+5GuSM6HnTV+BqH62s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741220796; c=relaxed/simple; bh=qUQ8Z5zspdkcANQize0hQv++Pfmq9uXbjBmYzq4i1Oo=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=drPaE/ybxWm5SJXhgtIK0twZaeawPAk59gWjMlePhrTZ4tUPu7nZcq8xDxlqbJDLfSCgpAaY5tvp1SmIT9dkR99ztjj2ffTVjm701auqsaSK09dYErTTfqB/G4qPnCee84V5oRc9TbeQXT2F7tDlf+JPX6wUnUiudvIWNbGCbDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ndYw2dpN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ndYw2dpN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55165C4CED1; Thu, 6 Mar 2025 00:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741220796; bh=qUQ8Z5zspdkcANQize0hQv++Pfmq9uXbjBmYzq4i1Oo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ndYw2dpNBROjqXQJsJ9dPrsoPaBpQD0aaTBl5jZq9AOSGL/QD1h4rU0J6w5OCed8g sRv6d8s3gfKMLyxS69CP4TuHkJxLicUDkckwJV8FXAbwRJwnR4CdyUwvU7bq/u2Niu TDabXYYS+glOX46bOin3yb7bM+uTJaz/t4WnjKMBnX8Hibg1ys4e0u/IdZ40k8FhR4 FOrmqC+c2L+2NZaBWW4u7Zlt8APiWDFVOd9YN4Mclwq3RyPp5Wc8X52mNU72tGTTCo dwVU9JivaOnSBh7Ovy/RjGs8l9UiONtGZxUgwpgLw87Er1sADI8KnM/S7RrPyaISsd thdFRzRB6qR/A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tpz4M-00ArOr-5v; Thu, 06 Mar 2025 00:26:34 +0000 Date: Thu, 06 Mar 2025 00:26:33 +0000 Message-ID: <86bjufovgm.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Sebastian Ott Subject: Re: [PATCH 0/3] KVM: arm64: Fixes for 'writable' ID registers in protected mode In-Reply-To: <20250305230825.484091-1-oliver.upton@linux.dev> References: <20250305230825.484091-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, sebott@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 05 Mar 2025 23:08:22 +0000, Oliver Upton wrote: > > Address a few issues with ID register handling in protected mode: > > - CTR_EL0 isn't trapped on FEAT_EVT systems if userspace changed the > guest value > > - VPIDR_EL2 is set to 0 if userspace enabled writable 'implementation > ID' registers > > - Fix in capability documentation > > Oliver Upton (3): > KVM: arm64: Copy guest CTR_EL0 into hyp VM > KVM: arm64: Copy MIDR_EL1 into hyp VM when it is writable > KVM: arm64: Fix documentation for KVM_CAP_ARM_WRITABLE_IMP_ID_REGS > > Documentation/virt/kvm/api.rst | 2 +- > arch/arm64/kvm/hyp/nvhe/pkvm.c | 7 ++++++- > 2 files changed, 7 insertions(+), 2 deletions(-) Irrespective of the comments for the first two patches: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.