From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51B04C25B75 for ; Wed, 29 May 2024 06:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t0WLFLLabdO64qOsNbFsieCL3PbYoqfOiFPDkgLtZQc=; b=3L565+OI7gsopU zHDq88kFUvzjXfaxa7omvR0GRdaSkmEITDHHUe8Vzme3mMxF+I03QvlkaDyJJ7VgqGiqx+m+8/P4D jhs3XNrapY3iWVg7tTd7nz7ShabBej0ezim0H87UZLNbhRagJX6iw6ZMO1utTfo0j/sPTdN3SXLdE IO2jdyEfKsg9IRKXEO+Xt0jpJIV87jZg8Lxflf7nVazkJF9vuw6HRHIhHPcIpbm8hRI/VfrvXPnYm rQf/4M561hY0xXyPhw5qqoM1P2fLf2zkDD89l/I1szoLGXgbB/SVI77G6gLWcaTOyS+mMj7uzivjJ vUqszYOkau2qT90+g2KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCCsx-000000031Sw-0gxQ; Wed, 29 May 2024 06:34:07 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCCsr-000000031SK-4A3i; Wed, 29 May 2024 06:34:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8E717CE1312; Wed, 29 May 2024 06:33:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C598EC2BD10; Wed, 29 May 2024 06:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716964436; bh=fxXSALfm/c/HrxXm8QMdN0iSEYCmwD7QCKfdmRnr0XQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tVpSvj/OVQ62qQPEyMQsW3zn89J5ul/51rrXGCGOJHaEr/csM+IwYCN5+qhCh+ThC DvtCSVC03Xz1TK4K8ExhZ3hXQQ5G2I13SeNE8ZYDBzQV/W+EL/zfsISpOIVk77bDqo Ak/WIGBHNqxLxkah0IDOtbVUVV9uR/vmnR4RbcKWWlwXGbHXOWMUhwqlbKigHNAfVd U5jMbbmQeKA5z0a2uIvD6IGD+upkjilFHUWGxyvIdKRw1hpmnouhmZlwh1vYhBLXH8 BpczrsRIz2rFv1Kj8W0iqu8p0RPjNkY0USjjIG9PJHzwzwc1vE+ahJCQ4bcn2Frjjt CF8bgdn/dHGTg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCCsk-00GVxc-Hn; Wed, 29 May 2024 07:33:54 +0100 Date: Wed, 29 May 2024 07:33:54 +0100 Message-ID: <86bk4pm8j1.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_233402_402532_64C520BF X-CRM114-Status: GOOD ( 38.37 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBNYXkgMjAyNCAwNjoxNTo1MiArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIFR1ZSwgTWF5IDI4LCAyMDI0IGF0IDEwOjEx 4oCvUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gQ29tbWl0 IGQ5NzZjNmY0YjMyYyAoIm9mOiBwcm9wZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IK PiA+IGludGVycnVwdC1tYXAgcHJvcGVydHkiKSB0cmllZCB0byBkbyB3aGF0IGl0IHNheXMgb24g dGhlIHRpbiwKPiA+IGJ1dCBmYWlsZWQgb24gYSBjb3VwbGUgb2YgcG9pbnRzOgo+ID4KPiA+IC0g aXQgY29uZnVzZXMgYnl0ZXMgYW5kIGNlbGxzLiBOb3QgYSBodWdlIGRlYWwsIGV4Y2VwdCB3aGVu IGl0Cj4gPiAgIGNvbWVzIHRvIHBvaW50ZXIgYXJpdGhtZXRpYwo+ID4KPiA+IC0gaXQgZG9lc24n dCByZWFsbHkgaGFuZGxlIGFueXRoaW5nIGJ1dCBpbnRlcnJ1cHQtbWFwcyB0aGF0IGhhdmUKPiA+ ICAgdGhlaXIgcGFyZW50ICNhZGRyZXNzLWNlbGxzIHNldCB0byAwCj4gPgo+ID4gVGhlIGNvbWJp bmF0aW9ucyBvZiB0aGUgdHdvIGxlYWRzIHRvIHNvbWUgc2VyaW91cyBmdW4gb24gbXkgTTEKPiA+ IGJveCwgd2l0aCBwbGVudHkgb2YgV0FSTi1PTigpIGZpcmluZyBhbGwgb3ZlciB0aGUgc2hvcCwg YW5kCj4gPiBhbXVzaW5nIHZhbHVlcyBiZWluZyBnZW5lcmF0ZWQgZm9yIGludGVycnVwdCBzcGVj aWZpZXJzLgo+ID4KPiA+IEFkZHJlc3MgYm90aCBpc3N1ZXMgc28gdGhhdCBJIGNhbiBib290IG15 IG1hY2hpbmVzIGFnYWluLgo+ID4KPiA+IEZpeGVzOiBkOTc2YzZmNGIzMmMgKCJvZjogcHJvcGVy dHk6IEFkZCBmd19kZXZsaW5rIHN1cHBvcnQgZm9yIGludGVycnVwdC1tYXAgcHJvcGVydHkiKQo+ ID4gU2lnbmVkLW9mZi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPiA+IENjOiBB bnVwIFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4KPiA+IENjOiBTYXJhdmFuYSBLYW5u YW4gPHNhcmF2YW5ha0Bnb29nbGUuY29tPgo+ID4gQ2M6IFJvYiBIZXJyaW5nIChBcm0pIDxyb2Jo QGtlcm5lbC5vcmc+Cj4gCj4gVGhhbmtzIGZvciB0aGUgZml4IHBhdGNoIGJ1dCB1bmZvcnR1bmF0 ZWx5IGl0IGJyZWFrcyBmb3IgUklTQy1WLgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9vZi9wcm9w ZXJ0eS5jIHwgMTYgKysrKysrKysrKysrKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29m L3Byb3BlcnR5LmMgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+IGluZGV4IDFjODNlNjhmODA1 Yi4uOWFkZWJjNjNiZWE5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9vZi9wcm9wZXJ0eS5jCj4g PiArKysgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+IEBAIC0xMzIyLDcgKzEzMjIsMTMgQEAg c3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqcGFyc2VfaW50ZXJydXB0X21hcChzdHJ1Y3QgZGV2 aWNlX25vZGUgKm5wLAo+ID4gICAgICAgICBhZGRyY2VsbHMgPSBvZl9idXNfbl9hZGRyX2NlbGxz KG5wKTsKPiA+Cj4gPiAgICAgICAgIGltYXAgPSBvZl9nZXRfcHJvcGVydHkobnAsICJpbnRlcnJ1 cHQtbWFwIiwgJmltYXBsZW4pOwo+ID4gLSAgICAgICBpZiAoIWltYXAgfHwgaW1hcGxlbiA8PSAo YWRkcmNlbGxzICsgaW50Y2VsbHMpKQo+ID4gKyAgICAgICBpbWFwbGVuIC89IHNpemVvZigqaW1h cCk7Cj4gPiArCj4gPiArICAgICAgIC8qCj4gPiArICAgICAgICAqIENoZWNrIHRoYXQgd2UgaGF2 ZSBlbm91Z2ggcnVud2F5IGZvciB0aGUgY2hpbGQgdW5pdCBpbnRlcnJ1cHQKPiA+ICsgICAgICAg ICogc3BlY2lmaWVyIGFuZCBhIHBoYW5kbGUuIFRoYXQncyB0aGUgYmFyZSBtaW5pbXVtIHdlIGNh biBleHBlY3QuCj4gPiArICAgICAgICAqLwo+ID4gKyAgICAgICBpZiAoIWltYXAgfHwgaW1hcGxl biA8PSAoYWRkcmNlbGxzICsgaW50Y2VsbHMgKyAxKSkKPiA+ICAgICAgICAgICAgICAgICByZXR1 cm4gTlVMTDsKPiA+ICAgICAgICAgaW1hcF9lbmQgPSBpbWFwICsgaW1hcGxlbjsKPiA+Cj4gPiBA QCAtMTM0Niw4ICsxMzUyLDE0IEBAIHN0YXRpYyBzdHJ1Y3QgZGV2aWNlX25vZGUgKnBhcnNlX2lu dGVycnVwdF9tYXAoc3RydWN0IGRldmljZV9ub2RlICpucCwKPiA+ICAgICAgICAgICAgICAgICBp ZiAoIWluZGV4KQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHN1cF9hcmdzLm5w Owo+ID4KPiA+IC0gICAgICAgICAgICAgICBvZl9ub2RlX3B1dChzdXBfYXJncy5ucCk7Cj4gPiAr ICAgICAgICAgICAgICAgLyoKPiA+ICsgICAgICAgICAgICAgICAgKiBBY2NvdW50IGZvciB0aGUg ZnVsbCBwYXJlbnQgdW5pdCBpbnRlcnJ1cHQgc3BlY2lmaWVyCj4gPiArICAgICAgICAgICAgICAg ICogKGFkZHJlc3MgY2VsbHMsIGludGVycnVwdCBjZWxscywgYW5kIHBoYW5kbGUpLgo+ID4gKyAg ICAgICAgICAgICAgICAqLwo+ID4gKyAgICAgICAgICAgICAgIGltYXAgKz0gb2ZfYnVzX25fYWRk cl9jZWxscyhzdXBfYXJncy5ucCk7Cj4gCj4gVGhpcyBicmVha3MgZm9yIFJJU0MtViBiZWNhdXNl IHdlIGRvbid0IGhhdmUgIiNhZGRyZXNzLWNlbGxzIgo+IHByb3BlcnR5IGluIGludGVycnVwdCBj b250cm9sbGVyIERUIG5vZGUgYW5kIG9mX2J1c19uX2FkZHJfY2VsbHMoKQo+IHJldHJpZXZlcyAi I2FkZHJlc3MtY2VsbHMiIGZyb20gdGhlIHBhcmVudCBvZiBpbnRlcnJ1cHQgY29udHJvbGxlci4K ClRoYXQncyBhIGZlYXR1cmUsIG5vdCBhIGJ1Zy4gI2FkZHJlc3MtY2VsbHMsIEFGQUlDVCwgYXBw bGllcyB0byBhbGwKY2hpbGQgbm9kZXMgdW50aWwgeW91IHNldCBpdCBvdGhlcndpc2UuCgo+IAo+ IFRoZSBvZl9pcnFfcGFyc2VfcmF3KCkgbG9va3MgZm9yICIjYWRkcmVzcy1jZWxscyIgcHJvcGVy dHkKPiBpbiB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgRFQgbm9kZSBvbmx5IHNvIHdlIHNob3Vs ZCBkbyBhCj4gc2ltaWxhciB0aGluZyBoZXJlIGFzIHdlbGwuCgpUaGlzIGxvb2tzIG1vcmUgbGlr ZSBhIG9mX2lycV9wYXJzZV9yYXcoKSBidWcgdGhhbiBhbnl0aGluZyBlbHNlLgoKPiAKPiBUaGUg YmVsb3cgY2hhbmdlIG9uIHRvcCBvZiB0aGlzIHBhdGNoIHdvcmtlZCBmb3IgbWUuCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvb2YvcHJvcGVydHkuYyBiL2RyaXZlcnMvb2YvcHJvcGVydHkuYwo+ IGluZGV4IDlhZGViYzYzYmVhOS4uZjU0ZGEyOTg5ZWE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv b2YvcHJvcGVydHkuYwo+ICsrKyBiL2RyaXZlcnMvb2YvcHJvcGVydHkuYwo+IEBAIC0xMzA4LDcg KzEzMDgsNyBAQCBzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlCj4gKnBhcnNlX2ludGVycnVwdF9t YXAoc3RydWN0IGRldmljZV9ub2RlICpucCwKPiAgewo+ICAgICAgY29uc3QgX19iZTMyICppbWFw LCAqaW1hcF9lbmQsICphZGRyOwo+ICAgICAgc3RydWN0IG9mX3BoYW5kbGVfYXJncyBzdXBfYXJn czsKPiAtICAgIHUzMiBhZGRyY2VsbHMsIGludGNlbGxzOwo+ICsgICAgdTMyIGFkZHJjZWxscywg aW50Y2VsbHMsIHBhZGRyY2VsbHM7Cj4gICAgICBpbnQgaSwgaW1hcGxlbjsKPiAKPiAgICAgIGlm ICghSVNfRU5BQkxFRChDT05GSUdfT0ZfSVJRKSkKPiBAQCAtMTM1Niw3ICsxMzU2LDggQEAgc3Rh dGljIHN0cnVjdCBkZXZpY2Vfbm9kZQo+ICpwYXJzZV9pbnRlcnJ1cHRfbWFwKHN0cnVjdCBkZXZp Y2Vfbm9kZSAqbnAsCj4gICAgICAgICAgICogQWNjb3VudCBmb3IgdGhlIGZ1bGwgcGFyZW50IHVu aXQgaW50ZXJydXB0IHNwZWNpZmllcgo+ICAgICAgICAgICAqIChhZGRyZXNzIGNlbGxzLCBpbnRl cnJ1cHQgY2VsbHMsIGFuZCBwaGFuZGxlKS4KPiAgICAgICAgICAgKi8KPiAtICAgICAgICBpbWFw ICs9IG9mX2J1c19uX2FkZHJfY2VsbHMoc3VwX2FyZ3MubnApOwo+ICsgICAgICAgIGlmICghb2Zf cHJvcGVydHlfcmVhZF91MzIoc3VwX2FyZ3MubnAsICIjYWRkcmVzcy1jZWxscyIsICZwYWRkcmNl bGxzKSkKPiArICAgICAgICAgICAgaW1hcCArPSBwYWRkcmNlbGxzOwoKVGhpcyBsb29rcyB3cm9u ZyB0byBtZSBmb3IgdGhlIHJlYXNvbiBJIG91dGxpbmVkIGFib3ZlOiB5b3UgbmVlZCB0bwpsb29r IGZvciBhIHZhbGlkICNhZGRyZXNzLWNlbGxzIGFsbCBhbG9uZyB0aGUgcGFyZW50IGNoYWluLCBu b3QganVzdAppbiB0aGUgaW50ZXJydXB0LWNvbnRyb2xsZXIgbm9kZS4KCglNLgoKLS0gCldpdGhv dXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2 IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86D7CC25B75 for ; Wed, 29 May 2024 06:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aqHq8bPfPWszFm31BUqzXKVVIAmAgXgtGgn6Bg82+HU=; b=C5FlFp9G5B1ohG KTWtUsILlQwEPi0/4CaVLbWbPfMKCe3S99ySxZTB77LQY8Hnm44y7oaA69R08Vh+EcP4qWtucZTh3 k7dnz+9tPOc4AD4BxFo95cO/3YA0a4+exWzmrwrLYEVRy5bPJiATHaKvPQCwxxAA5T5VqZFiLbnWz 8r+nPRCofDCTW04HScgpWpDSl5lzFKJlk5iyrcKZZMY189/YHPDZtYshgNdnLon3hpohOukXEKj3x 91w+jztZoDBqA47j5Eijexru02ndJV6RI3miUE5nAUeMQHb/wDM2Amm6/RqapLkqW8XRFhNXuKh9v zRjnu3IBeCkfBZrS2Khg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCCsw-000000031Sp-2HUE; Wed, 29 May 2024 06:34:06 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCCsr-000000031SK-4A3i; Wed, 29 May 2024 06:34:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8E717CE1312; Wed, 29 May 2024 06:33:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C598EC2BD10; Wed, 29 May 2024 06:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716964436; bh=fxXSALfm/c/HrxXm8QMdN0iSEYCmwD7QCKfdmRnr0XQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tVpSvj/OVQ62qQPEyMQsW3zn89J5ul/51rrXGCGOJHaEr/csM+IwYCN5+qhCh+ThC DvtCSVC03Xz1TK4K8ExhZ3hXQQ5G2I13SeNE8ZYDBzQV/W+EL/zfsISpOIVk77bDqo Ak/WIGBHNqxLxkah0IDOtbVUVV9uR/vmnR4RbcKWWlwXGbHXOWMUhwqlbKigHNAfVd U5jMbbmQeKA5z0a2uIvD6IGD+upkjilFHUWGxyvIdKRw1hpmnouhmZlwh1vYhBLXH8 BpczrsRIz2rFv1Kj8W0iqu8p0RPjNkY0USjjIG9PJHzwzwc1vE+ahJCQ4bcn2Frjjt CF8bgdn/dHGTg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCCsk-00GVxc-Hn; Wed, 29 May 2024 07:33:54 +0100 Date: Wed, 29 May 2024 07:33:54 +0100 Message-ID: <86bk4pm8j1.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_233402_402532_64C520BF X-CRM114-Status: GOOD ( 38.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBNYXkgMjAyNCAwNjoxNTo1MiArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIFR1ZSwgTWF5IDI4LCAyMDI0IGF0IDEwOjEx 4oCvUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gQ29tbWl0 IGQ5NzZjNmY0YjMyYyAoIm9mOiBwcm9wZXJ0eTogQWRkIGZ3X2Rldmxpbmsgc3VwcG9ydCBmb3IK PiA+IGludGVycnVwdC1tYXAgcHJvcGVydHkiKSB0cmllZCB0byBkbyB3aGF0IGl0IHNheXMgb24g dGhlIHRpbiwKPiA+IGJ1dCBmYWlsZWQgb24gYSBjb3VwbGUgb2YgcG9pbnRzOgo+ID4KPiA+IC0g aXQgY29uZnVzZXMgYnl0ZXMgYW5kIGNlbGxzLiBOb3QgYSBodWdlIGRlYWwsIGV4Y2VwdCB3aGVu IGl0Cj4gPiAgIGNvbWVzIHRvIHBvaW50ZXIgYXJpdGhtZXRpYwo+ID4KPiA+IC0gaXQgZG9lc24n dCByZWFsbHkgaGFuZGxlIGFueXRoaW5nIGJ1dCBpbnRlcnJ1cHQtbWFwcyB0aGF0IGhhdmUKPiA+ ICAgdGhlaXIgcGFyZW50ICNhZGRyZXNzLWNlbGxzIHNldCB0byAwCj4gPgo+ID4gVGhlIGNvbWJp bmF0aW9ucyBvZiB0aGUgdHdvIGxlYWRzIHRvIHNvbWUgc2VyaW91cyBmdW4gb24gbXkgTTEKPiA+ IGJveCwgd2l0aCBwbGVudHkgb2YgV0FSTi1PTigpIGZpcmluZyBhbGwgb3ZlciB0aGUgc2hvcCwg YW5kCj4gPiBhbXVzaW5nIHZhbHVlcyBiZWluZyBnZW5lcmF0ZWQgZm9yIGludGVycnVwdCBzcGVj aWZpZXJzLgo+ID4KPiA+IEFkZHJlc3MgYm90aCBpc3N1ZXMgc28gdGhhdCBJIGNhbiBib290IG15 IG1hY2hpbmVzIGFnYWluLgo+ID4KPiA+IEZpeGVzOiBkOTc2YzZmNGIzMmMgKCJvZjogcHJvcGVy dHk6IEFkZCBmd19kZXZsaW5rIHN1cHBvcnQgZm9yIGludGVycnVwdC1tYXAgcHJvcGVydHkiKQo+ ID4gU2lnbmVkLW9mZi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPiA+IENjOiBB bnVwIFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4KPiA+IENjOiBTYXJhdmFuYSBLYW5u YW4gPHNhcmF2YW5ha0Bnb29nbGUuY29tPgo+ID4gQ2M6IFJvYiBIZXJyaW5nIChBcm0pIDxyb2Jo QGtlcm5lbC5vcmc+Cj4gCj4gVGhhbmtzIGZvciB0aGUgZml4IHBhdGNoIGJ1dCB1bmZvcnR1bmF0 ZWx5IGl0IGJyZWFrcyBmb3IgUklTQy1WLgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9vZi9wcm9w ZXJ0eS5jIHwgMTYgKysrKysrKysrKysrKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29m L3Byb3BlcnR5LmMgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+IGluZGV4IDFjODNlNjhmODA1 Yi4uOWFkZWJjNjNiZWE5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9vZi9wcm9wZXJ0eS5jCj4g PiArKysgYi9kcml2ZXJzL29mL3Byb3BlcnR5LmMKPiA+IEBAIC0xMzIyLDcgKzEzMjIsMTMgQEAg c3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqcGFyc2VfaW50ZXJydXB0X21hcChzdHJ1Y3QgZGV2 aWNlX25vZGUgKm5wLAo+ID4gICAgICAgICBhZGRyY2VsbHMgPSBvZl9idXNfbl9hZGRyX2NlbGxz KG5wKTsKPiA+Cj4gPiAgICAgICAgIGltYXAgPSBvZl9nZXRfcHJvcGVydHkobnAsICJpbnRlcnJ1 cHQtbWFwIiwgJmltYXBsZW4pOwo+ID4gLSAgICAgICBpZiAoIWltYXAgfHwgaW1hcGxlbiA8PSAo YWRkcmNlbGxzICsgaW50Y2VsbHMpKQo+ID4gKyAgICAgICBpbWFwbGVuIC89IHNpemVvZigqaW1h cCk7Cj4gPiArCj4gPiArICAgICAgIC8qCj4gPiArICAgICAgICAqIENoZWNrIHRoYXQgd2UgaGF2 ZSBlbm91Z2ggcnVud2F5IGZvciB0aGUgY2hpbGQgdW5pdCBpbnRlcnJ1cHQKPiA+ICsgICAgICAg ICogc3BlY2lmaWVyIGFuZCBhIHBoYW5kbGUuIFRoYXQncyB0aGUgYmFyZSBtaW5pbXVtIHdlIGNh biBleHBlY3QuCj4gPiArICAgICAgICAqLwo+ID4gKyAgICAgICBpZiAoIWltYXAgfHwgaW1hcGxl biA8PSAoYWRkcmNlbGxzICsgaW50Y2VsbHMgKyAxKSkKPiA+ICAgICAgICAgICAgICAgICByZXR1 cm4gTlVMTDsKPiA+ICAgICAgICAgaW1hcF9lbmQgPSBpbWFwICsgaW1hcGxlbjsKPiA+Cj4gPiBA QCAtMTM0Niw4ICsxMzUyLDE0IEBAIHN0YXRpYyBzdHJ1Y3QgZGV2aWNlX25vZGUgKnBhcnNlX2lu dGVycnVwdF9tYXAoc3RydWN0IGRldmljZV9ub2RlICpucCwKPiA+ICAgICAgICAgICAgICAgICBp ZiAoIWluZGV4KQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHN1cF9hcmdzLm5w Owo+ID4KPiA+IC0gICAgICAgICAgICAgICBvZl9ub2RlX3B1dChzdXBfYXJncy5ucCk7Cj4gPiAr ICAgICAgICAgICAgICAgLyoKPiA+ICsgICAgICAgICAgICAgICAgKiBBY2NvdW50IGZvciB0aGUg ZnVsbCBwYXJlbnQgdW5pdCBpbnRlcnJ1cHQgc3BlY2lmaWVyCj4gPiArICAgICAgICAgICAgICAg ICogKGFkZHJlc3MgY2VsbHMsIGludGVycnVwdCBjZWxscywgYW5kIHBoYW5kbGUpLgo+ID4gKyAg ICAgICAgICAgICAgICAqLwo+ID4gKyAgICAgICAgICAgICAgIGltYXAgKz0gb2ZfYnVzX25fYWRk cl9jZWxscyhzdXBfYXJncy5ucCk7Cj4gCj4gVGhpcyBicmVha3MgZm9yIFJJU0MtViBiZWNhdXNl IHdlIGRvbid0IGhhdmUgIiNhZGRyZXNzLWNlbGxzIgo+IHByb3BlcnR5IGluIGludGVycnVwdCBj b250cm9sbGVyIERUIG5vZGUgYW5kIG9mX2J1c19uX2FkZHJfY2VsbHMoKQo+IHJldHJpZXZlcyAi I2FkZHJlc3MtY2VsbHMiIGZyb20gdGhlIHBhcmVudCBvZiBpbnRlcnJ1cHQgY29udHJvbGxlci4K ClRoYXQncyBhIGZlYXR1cmUsIG5vdCBhIGJ1Zy4gI2FkZHJlc3MtY2VsbHMsIEFGQUlDVCwgYXBw bGllcyB0byBhbGwKY2hpbGQgbm9kZXMgdW50aWwgeW91IHNldCBpdCBvdGhlcndpc2UuCgo+IAo+ IFRoZSBvZl9pcnFfcGFyc2VfcmF3KCkgbG9va3MgZm9yICIjYWRkcmVzcy1jZWxscyIgcHJvcGVy dHkKPiBpbiB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgRFQgbm9kZSBvbmx5IHNvIHdlIHNob3Vs ZCBkbyBhCj4gc2ltaWxhciB0aGluZyBoZXJlIGFzIHdlbGwuCgpUaGlzIGxvb2tzIG1vcmUgbGlr ZSBhIG9mX2lycV9wYXJzZV9yYXcoKSBidWcgdGhhbiBhbnl0aGluZyBlbHNlLgoKPiAKPiBUaGUg YmVsb3cgY2hhbmdlIG9uIHRvcCBvZiB0aGlzIHBhdGNoIHdvcmtlZCBmb3IgbWUuCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvb2YvcHJvcGVydHkuYyBiL2RyaXZlcnMvb2YvcHJvcGVydHkuYwo+ IGluZGV4IDlhZGViYzYzYmVhOS4uZjU0ZGEyOTg5ZWE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv b2YvcHJvcGVydHkuYwo+ICsrKyBiL2RyaXZlcnMvb2YvcHJvcGVydHkuYwo+IEBAIC0xMzA4LDcg KzEzMDgsNyBAQCBzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlCj4gKnBhcnNlX2ludGVycnVwdF9t YXAoc3RydWN0IGRldmljZV9ub2RlICpucCwKPiAgewo+ICAgICAgY29uc3QgX19iZTMyICppbWFw LCAqaW1hcF9lbmQsICphZGRyOwo+ICAgICAgc3RydWN0IG9mX3BoYW5kbGVfYXJncyBzdXBfYXJn czsKPiAtICAgIHUzMiBhZGRyY2VsbHMsIGludGNlbGxzOwo+ICsgICAgdTMyIGFkZHJjZWxscywg aW50Y2VsbHMsIHBhZGRyY2VsbHM7Cj4gICAgICBpbnQgaSwgaW1hcGxlbjsKPiAKPiAgICAgIGlm ICghSVNfRU5BQkxFRChDT05GSUdfT0ZfSVJRKSkKPiBAQCAtMTM1Niw3ICsxMzU2LDggQEAgc3Rh dGljIHN0cnVjdCBkZXZpY2Vfbm9kZQo+ICpwYXJzZV9pbnRlcnJ1cHRfbWFwKHN0cnVjdCBkZXZp Y2Vfbm9kZSAqbnAsCj4gICAgICAgICAgICogQWNjb3VudCBmb3IgdGhlIGZ1bGwgcGFyZW50IHVu aXQgaW50ZXJydXB0IHNwZWNpZmllcgo+ICAgICAgICAgICAqIChhZGRyZXNzIGNlbGxzLCBpbnRl cnJ1cHQgY2VsbHMsIGFuZCBwaGFuZGxlKS4KPiAgICAgICAgICAgKi8KPiAtICAgICAgICBpbWFw ICs9IG9mX2J1c19uX2FkZHJfY2VsbHMoc3VwX2FyZ3MubnApOwo+ICsgICAgICAgIGlmICghb2Zf cHJvcGVydHlfcmVhZF91MzIoc3VwX2FyZ3MubnAsICIjYWRkcmVzcy1jZWxscyIsICZwYWRkcmNl bGxzKSkKPiArICAgICAgICAgICAgaW1hcCArPSBwYWRkcmNlbGxzOwoKVGhpcyBsb29rcyB3cm9u ZyB0byBtZSBmb3IgdGhlIHJlYXNvbiBJIG91dGxpbmVkIGFib3ZlOiB5b3UgbmVlZCB0bwpsb29r IGZvciBhIHZhbGlkICNhZGRyZXNzLWNlbGxzIGFsbCBhbG9uZyB0aGUgcGFyZW50IGNoYWluLCBu b3QganVzdAppbiB0aGUgaW50ZXJydXB0LWNvbnRyb2xsZXIgbm9kZS4KCglNLgoKLS0gCldpdGhv dXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 530FE46453; Wed, 29 May 2024 06:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716964437; cv=none; b=VLQorfdTKSOl2M2MWeaEFHqiERRYoEb9YkrmcCopfcZevSgbtwxsjfQYm+bmXlDUHWjpWZiMDqcwml3Z72L5jhsDkex/v3LPsli6fIP/2rVwG7HPW1VvIQJbtTCwSXxa4NfTSBtYMNsSFVfWp4YaIm9zlMavtB/OoZ/CaeTAptM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716964437; c=relaxed/simple; bh=fxXSALfm/c/HrxXm8QMdN0iSEYCmwD7QCKfdmRnr0XQ=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=faWqiJMtfVSTMoMFzjcMOWP/UMqNatacGRWEPGx7/S4sHu+TVgBwtgxuD4FlA9jptE9wVvY5eCHugmQplHXGUEUJbxTmwb/tVYkFluAFV1JykWxKEirkvL/KhAO4cO9fusSaZz+eUedzYFotSYZdvUrL4ToFfrQRREN6zMzCx7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tVpSvj/O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tVpSvj/O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C598EC2BD10; Wed, 29 May 2024 06:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716964436; bh=fxXSALfm/c/HrxXm8QMdN0iSEYCmwD7QCKfdmRnr0XQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tVpSvj/OVQ62qQPEyMQsW3zn89J5ul/51rrXGCGOJHaEr/csM+IwYCN5+qhCh+ThC DvtCSVC03Xz1TK4K8ExhZ3hXQQ5G2I13SeNE8ZYDBzQV/W+EL/zfsISpOIVk77bDqo Ak/WIGBHNqxLxkah0IDOtbVUVV9uR/vmnR4RbcKWWlwXGbHXOWMUhwqlbKigHNAfVd U5jMbbmQeKA5z0a2uIvD6IGD+upkjilFHUWGxyvIdKRw1hpmnouhmZlwh1vYhBLXH8 BpczrsRIz2rFv1Kj8W0iqu8p0RPjNkY0USjjIG9PJHzwzwc1vE+ahJCQ4bcn2Frjjt CF8bgdn/dHGTg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCCsk-00GVxc-Hn; Wed, 29 May 2024 07:33:54 +0100 Date: Wed, 29 May 2024 07:33:54 +0100 Message-ID: <86bk4pm8j1.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan , Rob Herring Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com, robh@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 29 May 2024 06:15:52 +0100, Anup Patel wrote: >=20 > On Tue, May 28, 2024 at 10:11=E2=80=AFPM Marc Zyngier wr= ote: > > > > Commit d976c6f4b32c ("of: property: Add fw_devlink support for > > interrupt-map property") tried to do what it says on the tin, > > but failed on a couple of points: > > > > - it confuses bytes and cells. Not a huge deal, except when it > > comes to pointer arithmetic > > > > - it doesn't really handle anything but interrupt-maps that have > > their parent #address-cells set to 0 > > > > The combinations of the two leads to some serious fun on my M1 > > box, with plenty of WARN-ON() firing all over the shop, and > > amusing values being generated for interrupt specifiers. > > > > Address both issues so that I can boot my machines again. > > > > Fixes: d976c6f4b32c ("of: property: Add fw_devlink support for interrup= t-map property") > > Signed-off-by: Marc Zyngier > > Cc: Anup Patel > > Cc: Saravana Kannan > > Cc: Rob Herring (Arm) >=20 > Thanks for the fix patch but unfortunately it breaks for RISC-V. >=20 > > --- > > drivers/of/property.c | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index 1c83e68f805b..9adebc63bea9 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -1322,7 +1322,13 @@ static struct device_node *parse_interrupt_map(s= truct device_node *np, > > addrcells =3D of_bus_n_addr_cells(np); > > > > imap =3D of_get_property(np, "interrupt-map", &imaplen); > > - if (!imap || imaplen <=3D (addrcells + intcells)) > > + imaplen /=3D sizeof(*imap); > > + > > + /* > > + * Check that we have enough runway for the child unit interrupt > > + * specifier and a phandle. That's the bare minimum we can expe= ct. > > + */ > > + if (!imap || imaplen <=3D (addrcells + intcells + 1)) > > return NULL; > > imap_end =3D imap + imaplen; > > > > @@ -1346,8 +1352,14 @@ static struct device_node *parse_interrupt_map(s= truct device_node *np, > > if (!index) > > return sup_args.np; > > > > - of_node_put(sup_args.np); > > + /* > > + * Account for the full parent unit interrupt specifier > > + * (address cells, interrupt cells, and phandle). > > + */ > > + imap +=3D of_bus_n_addr_cells(sup_args.np); >=20 > This breaks for RISC-V because we don't have "#address-cells" > property in interrupt controller DT node and of_bus_n_addr_cells() > retrieves "#address-cells" from the parent of interrupt controller. That's a feature, not a bug. #address-cells, AFAICT, applies to all child nodes until you set it otherwise. >=20 > The of_irq_parse_raw() looks for "#address-cells" property > in the interrupt controller DT node only so we should do a > similar thing here as well. This looks more like a of_irq_parse_raw() bug than anything else. >=20 > The below change on top of this patch worked for me. >=20 > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 9adebc63bea9..f54da2989ea9 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1308,7 +1308,7 @@ static struct device_node > *parse_interrupt_map(struct device_node *np, > { > const __be32 *imap, *imap_end, *addr; > struct of_phandle_args sup_args; > - u32 addrcells, intcells; > + u32 addrcells, intcells, paddrcells; > int i, imaplen; >=20 > if (!IS_ENABLED(CONFIG_OF_IRQ)) > @@ -1356,7 +1356,8 @@ static struct device_node > *parse_interrupt_map(struct device_node *np, > * Account for the full parent unit interrupt specifier > * (address cells, interrupt cells, and phandle). > */ > - imap +=3D of_bus_n_addr_cells(sup_args.np); > + if (!of_property_read_u32(sup_args.np, "#address-cells", &paddrc= ells)) > + imap +=3D paddrcells; This looks wrong to me for the reason I outlined above: you need to look for a valid #address-cells all along the parent chain, not just in the interrupt-controller node. M. --=20 Without deviation from the norm, progress is not possible.