From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58F861B947; Sun, 17 Mar 2024 11:42:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710675769; cv=none; b=tUjrUGR8b9x9NraWwj48DQEKx9z6x57p5k4p4YPnCGBcY3Y4vNElXStZSJlQJqBQuIa/qSak/FsWDYoxhkH8+xVL6FqG4bZmX9jZydVs9UXVVufkzp6xP2txlXhe+vXvvd5L4MG7eU+TMSruMN1dfpqqu57QAHuXUogaoS8e5GA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710675769; c=relaxed/simple; bh=yIs6FmWfE+g2CBU9z0E91nMt7P9sDGyQXWi8VWIJaV4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=fKmP5fTe/z3jPpz0n8FgNvEAQ4iMc4lr+glso4Hx0TU1o6NWWh69PQ3c4JkLXV5LvHc/jPIP1k/aqGEdh/YK2fp9jxPTobhazQDHn8E/Kx5uLICL7+mwHgbEzDkJLluhzzyYKEOhz3IjWn2AKDIrrzrCw99r8dYD4k4XnWDXmpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hqbwkovl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hqbwkovl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D25E9C433F1; Sun, 17 Mar 2024 11:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710675768; bh=yIs6FmWfE+g2CBU9z0E91nMt7P9sDGyQXWi8VWIJaV4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hqbwkovlvfUoXlY5ydcjEvUyjUsyhjG29LkaktzOCa5mdJsmPTJOdiRAcxGrXOPoN Fo8lOmhBOanUnDA6D4IvYcURviaTQpTT9afwL1ZSLgX+wbKRj/1/uutdjprNW5aZLn Oo9rA53m5P2vXKSr2TVNtBE0r1GIw3It+f2Sl6Hc0z+AS3bDAFeBWffWAyHzqKj20g hb101omTBtdaUhaENDy6Ci7TwgbmtNrHdjCW9zJbLL3pqv35DWpQEHPnlWoFk2+SKZ /HYfENlc7nY+DjMtYc+hIwm94Q+QwlN0f2dPnBX7AOk2n8pD17EZMB04WZb5y4Dgqd yRJWWyIpEy3QA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rlouc-00D1X5-H0; Sun, 17 Mar 2024 11:42:46 +0000 Date: Sun, 17 Mar 2024 11:42:44 +0000 Message-ID: <86bk7d13uz.wl-maz@kernel.org> From: Marc Zyngier To: =?UTF-8?B?UGllcnJlLUNsw6ltZW50?= Tosi Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH 05/10] KVM: arm64: nVHE: Add EL2 sync exception handler In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ptosi@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 14 Mar 2024 20:24:31 +0000, Pierre-Cl=C3=A9ment Tosi wrote: >=20 > Introduce handlers for EL2{t,h} synchronous exceptions distinct from > handlers for other "invalid" exceptions when running with the nVHE host > vector. This will allow a future patch to handle CFI (synchronous) > errors without affecting other classes of exceptions. >=20 > Remove superfluous SP overflow check from the non-synchronous > handlers. Why are they superfluous? Because we are panic'ing? Detecting a stack overflow is pretty valuable in any circumstances. >=20 > Signed-off-by: Pierre-Cl=C3=A9ment Tosi > --- > arch/arm64/kvm/hyp/nvhe/host.S | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/arm64/kvm/hyp/nvhe/host.S b/arch/arm64/kvm/hyp/nvhe/hos= t.S > index 27c989c4976d..1b9111c2b480 100644 > --- a/arch/arm64/kvm/hyp/nvhe/host.S > +++ b/arch/arm64/kvm/hyp/nvhe/host.S > @@ -183,7 +183,7 @@ SYM_FUNC_END(__host_hvc) > .endif > .endm > =20 > -.macro invalid_host_el2_vect > +.macro host_el2_sync_vect > .align 7 > =20 > /* > @@ -221,6 +221,11 @@ SYM_FUNC_END(__host_hvc) > b __hyp_do_panic > .endm > =20 > +.macro invalid_host_el2_vect > + .align 7 > + b __hyp_panic > +.endm > + > /* > * The host vector does not use an ESB instruction in order to avoid con= suming > * SErrors that should only be consumed by the host. Guest entry is defe= rred by > @@ -233,12 +238,12 @@ SYM_FUNC_END(__host_hvc) > */ > .align 11 > SYM_CODE_START(__kvm_hyp_host_vector) > - invalid_host_el2_vect // Synchronous EL2t > + host_el2_sync_vect // Synchronous EL2t The real question is: under which circumstances would running with SP_EL0 be valid? I cannot see good reason for it. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2516C54E67 for ; Sun, 17 Mar 2024 11:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0/7EZwsH1IWXmg+JdCrmqyR1jJVqY1Ol5+FJTXT1FIE=; b=s9dsFdl9+FdDyC OS5U3Ml4yqNZCxeZTL9ks+Xx/zOzlGeUYpYXYqILQ5KgfY79q80RKX82UHjvQYqswpfLjkSCLpMKa J3qPgngD8vmP6Utyd+yvD5+wNhlsT/U9qsRhPkE5VczMyCFi5vy1VnKdgLlrVaSCiuP3wtR3pUk9I pXQJiGisnh+xVeaazTgvQgkLR16mPq0ShgjypGJVg1bUc5U86t7IK2t+w1TVSh/UcXOolpVssU7GA JbxhC+eg+3FhPSyhOExlLO9z0q9HGLAM1cTmcXPqGyVk3sBsJH8RFDvuCtcz3HRN4G1Uasb4P/oMd JkyZj97m5kHAZXROlO+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlous-000000053kA-2hoH; Sun, 17 Mar 2024 11:43:02 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlouo-000000053i8-39gO for linux-arm-kernel@lists.infradead.org; Sun, 17 Mar 2024 11:43:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CC00DCE068D; Sun, 17 Mar 2024 11:42:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D25E9C433F1; Sun, 17 Mar 2024 11:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710675768; bh=yIs6FmWfE+g2CBU9z0E91nMt7P9sDGyQXWi8VWIJaV4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hqbwkovlvfUoXlY5ydcjEvUyjUsyhjG29LkaktzOCa5mdJsmPTJOdiRAcxGrXOPoN Fo8lOmhBOanUnDA6D4IvYcURviaTQpTT9afwL1ZSLgX+wbKRj/1/uutdjprNW5aZLn Oo9rA53m5P2vXKSr2TVNtBE0r1GIw3It+f2Sl6Hc0z+AS3bDAFeBWffWAyHzqKj20g hb101omTBtdaUhaENDy6Ci7TwgbmtNrHdjCW9zJbLL3pqv35DWpQEHPnlWoFk2+SKZ /HYfENlc7nY+DjMtYc+hIwm94Q+QwlN0f2dPnBX7AOk2n8pD17EZMB04WZb5y4Dgqd yRJWWyIpEy3QA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rlouc-00D1X5-H0; Sun, 17 Mar 2024 11:42:46 +0000 Date: Sun, 17 Mar 2024 11:42:44 +0000 Message-ID: <86bk7d13uz.wl-maz@kernel.org> From: Marc Zyngier To: =?UTF-8?B?UGllcnJlLUNsw6ltZW50?= Tosi Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH 05/10] KVM: arm64: nVHE: Add EL2 sync exception handler In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ptosi@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240317_044259_184623_6A914A52 X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxNCBNYXIgMjAyNCAyMDoyNDozMSArMDAwMCwKUGllcnJlLUNsw6ltZW50IFRvc2kg PHB0b3NpQGdvb2dsZS5jb20+IHdyb3RlOgo+IAo+IEludHJvZHVjZSBoYW5kbGVycyBmb3IgRUwy e3QsaH0gc3luY2hyb25vdXMgZXhjZXB0aW9ucyBkaXN0aW5jdCBmcm9tCj4gaGFuZGxlcnMgZm9y IG90aGVyICJpbnZhbGlkIiBleGNlcHRpb25zIHdoZW4gcnVubmluZyB3aXRoIHRoZSBuVkhFIGhv c3QKPiB2ZWN0b3IuIFRoaXMgd2lsbCBhbGxvdyBhIGZ1dHVyZSBwYXRjaCB0byBoYW5kbGUgQ0ZJ IChzeW5jaHJvbm91cykKPiBlcnJvcnMgd2l0aG91dCBhZmZlY3Rpbmcgb3RoZXIgY2xhc3NlcyBv ZiBleGNlcHRpb25zLgo+IAo+IFJlbW92ZSBzdXBlcmZsdW91cyBTUCBvdmVyZmxvdyBjaGVjayBm cm9tIHRoZSBub24tc3luY2hyb25vdXMKPiBoYW5kbGVycy4KCldoeSBhcmUgdGhleSBzdXBlcmZs dW91cz8gQmVjYXVzZSB3ZSBhcmUgcGFuaWMnaW5nPyBEZXRlY3RpbmcgYSBzdGFjawpvdmVyZmxv dyBpcyBwcmV0dHkgdmFsdWFibGUgaW4gYW55IGNpcmN1bXN0YW5jZXMuCgo+IAo+IFNpZ25lZC1v ZmYtYnk6IFBpZXJyZS1DbMOpbWVudCBUb3NpIDxwdG9zaUBnb29nbGUuY29tPgo+IC0tLQo+ICBh cmNoL2FybTY0L2t2bS9oeXAvbnZoZS9ob3N0LlMgfCAxMSArKysrKysrKy0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9hcmNoL2FybTY0L2t2bS9oeXAvbnZoZS9ob3N0LlMgYi9hcmNoL2FybTY0L2t2bS9oeXAvbnZo ZS9ob3N0LlMKPiBpbmRleCAyN2M5ODljNDk3NmQuLjFiOTExMWMyYjQ4MCAxMDA2NDQKPiAtLS0g YS9hcmNoL2FybTY0L2t2bS9oeXAvbnZoZS9ob3N0LlMKPiArKysgYi9hcmNoL2FybTY0L2t2bS9o eXAvbnZoZS9ob3N0LlMKPiBAQCAtMTgzLDcgKzE4Myw3IEBAIFNZTV9GVU5DX0VORChfX2hvc3Rf aHZjKQo+ICAuZW5kaWYKPiAgLmVuZG0KPiAgCj4gLS5tYWNybyBpbnZhbGlkX2hvc3RfZWwyX3Zl Y3QKPiArLm1hY3JvIGhvc3RfZWwyX3N5bmNfdmVjdAo+ICAJLmFsaWduIDcKPiAgCj4gIAkvKgo+ IEBAIC0yMjEsNiArMjIxLDExIEBAIFNZTV9GVU5DX0VORChfX2hvc3RfaHZjKQo+ICAJYglfX2h5 cF9kb19wYW5pYwo+ICAuZW5kbQo+ICAKPiArLm1hY3JvIGludmFsaWRfaG9zdF9lbDJfdmVjdAo+ ICsJLmFsaWduIDcKPiArCWIJX19oeXBfcGFuaWMKPiArLmVuZG0KPiArCj4gIC8qCj4gICAqIFRo ZSBob3N0IHZlY3RvciBkb2VzIG5vdCB1c2UgYW4gRVNCIGluc3RydWN0aW9uIGluIG9yZGVyIHRv IGF2b2lkIGNvbnN1bWluZwo+ICAgKiBTRXJyb3JzIHRoYXQgc2hvdWxkIG9ubHkgYmUgY29uc3Vt ZWQgYnkgdGhlIGhvc3QuIEd1ZXN0IGVudHJ5IGlzIGRlZmVycmVkIGJ5Cj4gQEAgLTIzMywxMiAr MjM4LDEyIEBAIFNZTV9GVU5DX0VORChfX2hvc3RfaHZjKQo+ICAgKi8KPiAgCS5hbGlnbiAxMQo+ ICBTWU1fQ09ERV9TVEFSVChfX2t2bV9oeXBfaG9zdF92ZWN0b3IpCj4gLQlpbnZhbGlkX2hvc3Rf ZWwyX3ZlY3QJCQkvLyBTeW5jaHJvbm91cyBFTDJ0Cj4gKwlob3N0X2VsMl9zeW5jX3ZlY3QJCQkv LyBTeW5jaHJvbm91cyBFTDJ0CgpUaGUgcmVhbCBxdWVzdGlvbiBpczogdW5kZXIgd2hpY2ggY2ly Y3Vtc3RhbmNlcyB3b3VsZCBydW5uaW5nIHdpdGgKU1BfRUwwIGJlIHZhbGlkPyBJIGNhbm5vdCBz ZWUgZ29vZCByZWFzb24gZm9yIGl0LgoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0 aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=