From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCDE78C08 for ; Thu, 30 Mar 2023 17:51:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B59BC433D2; Thu, 30 Mar 2023 17:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680198696; bh=70+PlCWjV343Ls+davRfCuZxkHPlYecXz6oBJbIZ8Ik=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gAA7rJeIvewn3tU5KYVlhrfDaOZtMUzcmgCePhsqu+bJKHeyyvUIJWwq2L+4m761w GKouNSzPc4KB1e2v55B64WnEWLXGR8uD8z9BiB8Yi9yIx7/2ik0rRynBf0lu/unsMs xR0wt0CE+s5vg9Ej5fbhlIwG8DEMGWWUT33Irh2bX5CsMgvAAubL4RTXRa6D4HxT96 GDs57jQzljPU1/Af9rBpAbDfgmUsNSYIKn7Nm8wdeLTRGWOGU2mJ4C4G9pGwTfvFgH SokEP8Ng2iZKEuuOYeFegyvsNWR6A+bwtojzNZDJYIa1LwhCfZrshW+9uYGFcxeRxQ 4oym8nHruD+/A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1phwQw-004Rxz-L7; Thu, 30 Mar 2023 18:51:34 +0100 Date: Thu, 30 Mar 2023 18:51:34 +0100 Message-ID: <86bkkaw2jd.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, oupton@google.com, will@kernel.org, pbonzini@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, reijiw@google.com, ricarkol@google.com, rananta@google.com, jingzhangos@google.com Subject: Re: [PATCH v2] KVM: arm64: Advertise ID_AA64PFR0_EL1.CSV2/3 to protected VMs In-Reply-To: <20230330101738.698181-1-tabba@google.com> References: <20230330101738.698181-1-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, oupton@google.com, will@kernel.org, pbonzini@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, reijiw@google.com, ricarkol@google.com, rananta@google.com, jingzhangos@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 30 Mar 2023 11:17:38 +0100, Fuad Tabba wrote: > > The existing pKVM code attempts to do that using a value > initialized to 0 but never set. To advertise csv2/3 to a > protected guest, pass their values to hyp when initializing hyp's > view of guests' ID_AA64PFR0_EL1. > > Similar to non-protected KVM, these are system-wide, rather than > per cpu, for simplicity. > > Fixes: 6c30bfb18d0b ("KVM: arm64: Add handlers for protected VM System Registers") > Signed-off-by: Fuad Tabba Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.