From: David Wragg <david@weave.works>
To: Tom Herbert <tom@herbertland.com>
Cc: Jesse Gross <jesse@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
ovs dev <dev@openvswitch.org>, David Miller <davem@davemloft.net>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Thomas Graf <tgraf@suug.ch>,
Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net v2 2/3] geneve: Relax MTU constraints
Date: Thu, 18 Feb 2016 16:54:14 +0000 [thread overview]
Message-ID: <86bn7e2c3t.fsf@weave.works> (raw)
In-Reply-To: <CALx6S37OgkxTLv6XEjFN4T=W8ZdZV_kx4wtPqtVwMizoUXbpVw@mail.gmail.com> (Tom Herbert's message of "Tue, 16 Feb 2016 08:44:02 -0800")
Tom Herbert <tom@herbertland.com> writes:
> Please implement like in ip_tunnel_change_mtu (or better yet call it),
> that is the precedent for tunnels.
I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2.
If it were to call it instead, are you suggesting just passing in
t_hlen? Or restructuring geneve.c to re-use the whole ip_tunnel
infrastructure?
Also, I'm not sure where the 0xFFF8 comes from in
__ip_tunnel_change_mtu. Any ideas why 0xFFF8 rather than 0xffff? It
goes all the way back to the inital import of the kernel into git.
David
next prev parent reply other threads:[~2016-02-18 16:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 16:47 [PATCH net v2 0/3] Set a large MTU on ovs-created tunnel devices David Wragg
2016-02-09 16:47 ` [PATCH net v2 1/3] vxlan: Relax the MTU constraints David Wragg
[not found] ` <1455036424-6403-1-git-send-email-david-1SEAoVOfG6VEzL6FDj/jAg@public.gmane.org>
2016-02-09 16:47 ` [PATCH net v2 2/3] geneve: Relax " David Wragg
2016-02-09 18:18 ` Sergei Shtylyov
[not found] ` <56BA2D6D.6090408-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-02-09 18:22 ` David Wragg
2016-02-10 7:40 ` Tom Herbert
2016-02-10 11:41 ` David Wragg
2016-02-10 11:59 ` Jesse Gross
2016-02-10 14:21 ` Tom Herbert
[not found] ` <CALx6S36kvXJUZM8_vEmF8L3bxnRiBh98Rs0wAd-HGBJ9Yyde_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-10 14:52 ` Jesse Gross
2016-02-16 12:33 ` David Wragg
2016-02-16 16:44 ` Tom Herbert
2016-02-18 16:54 ` David Wragg [this message]
2016-02-18 20:07 ` David Miller
[not found] ` <86bn7e2c3t.fsf-1SEAoVOfG6VEzL6FDj/jAg@public.gmane.org>
2016-02-19 2:11 ` Tom Herbert
2016-02-09 16:47 ` [PATCH net v2 3/3] vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices David Wragg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bn7e2c3t.fsf@weave.works \
--to=david@weave.works \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=hannes@stressinduktion.org \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.