From: Keith Packard <keithp@keithp.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org, hcb@chaoticmind.net
Subject: Re: [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too
Date: Sat, 17 Mar 2012 12:01:17 -0700 [thread overview]
Message-ID: <86bonvcarm.fsf@sumi.keithp.com> (raw)
In-Reply-To: <s5hzkbfhd37.wl%tiwai@suse.de>
<#part sign=pgpmime>
On Sat, 17 Mar 2012 08:59:56 +0100, Takashi Iwai <tiwai@suse.de> wrote:
> Well, the LVDS reg data isn't in lvds_dvo_timing but in lvds_fp_timing,
> thus you need to look at a different entry in anyway.
Right, a parallel function which returns the lvds_fp_timing structure
instead of pulling the data out of it. Just makes the code look more
like the existing stuff. And, if we need more data from the
lvds_fp_timing in the future, we'll have it available directly.
> I skipped it to simplify the code, but that'd be safer, indeed.
Reducing the chances for regressions is my primary concern here; most
people boot their machines with the lid open, so if we avoid the new
code in that case, we'll be more likely to not break things.
--
keith.packard@intel.com
next prev parent reply other threads:[~2012-03-17 19:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 21:41 [PATCH 0/2 v4] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-16 21:41 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-16 23:18 ` Keith Packard
2012-03-17 7:59 ` Takashi Iwai
2012-03-17 19:01 ` Keith Packard [this message]
2012-03-18 20:28 ` Takashi Iwai
2012-03-16 21:41 ` [PATCH 2/2] drm/i915: Add lvds_channel module option Takashi Iwai
2012-03-17 1:51 ` Eugeni Dodonov
2012-03-17 8:00 ` Takashi Iwai
2012-03-19 14:21 ` [PATCH 0/2 v4] drm/i915: LVDS channel mode fixes Adam Jackson
-- strict thread matches above, loose matches on Subject: below --
2012-03-19 11:07 [PATCH 0/2 v5] " Takashi Iwai
2012-03-19 11:07 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-20 10:01 ` Daniel Vetter
2012-03-20 12:04 ` Takashi Iwai
2012-03-20 14:57 ` Keith Packard
2012-03-20 18:35 ` Rodrigo Vivi
2012-03-20 12:07 [PATCH 0/2 v6] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-20 12:07 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-21 22:31 ` Daniel Vetter
2012-03-22 20:57 ` Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bonvcarm.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=hcb@chaoticmind.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.