From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Date: Sat, 17 Mar 2012 12:01:17 -0700 Message-ID: <86bonvcarm.fsf@sumi.keithp.com> References: <1331934073-24463-1-git-send-email-tiwai@suse.de> <1331934073-24463-2-git-send-email-tiwai@suse.de> <861uosdtjo.fsf@sumi.keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id A98739E7AF for ; Sat, 17 Mar 2012 12:01:21 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Takashi Iwai Cc: intel-gfx@lists.freedesktop.org, hcb@chaoticmind.net List-Id: intel-gfx@lists.freedesktop.org <#part sign=pgpmime> On Sat, 17 Mar 2012 08:59:56 +0100, Takashi Iwai wrote: > Well, the LVDS reg data isn't in lvds_dvo_timing but in lvds_fp_timing, > thus you need to look at a different entry in anyway. Right, a parallel function which returns the lvds_fp_timing structure instead of pulling the data out of it. Just makes the code look more like the existing stuff. And, if we need more data from the lvds_fp_timing in the future, we'll have it available directly. > I skipped it to simplify the code, but that'd be safer, indeed. Reducing the chances for regressions is my primary concern here; most people boot their machines with the lid open, so if we avoid the new code in that case, we'll be more likely to not break things. -- keith.packard@intel.com