From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Serialize GTT/Aperture accesses on BXT Date: Thu, 25 May 2017 11:54:03 +0100 Message-ID: <86cbcb6f-034a-dd62-2f84-dbf477cd481e@linux.intel.com> References: <1495641251-30022-1-git-send-email-jon.bloomfield@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7DCB6E963 for ; Thu, 25 May 2017 10:54:11 +0000 (UTC) In-Reply-To: <1495641251-30022-1-git-send-email-jon.bloomfield@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jon Bloomfield , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI0LzA1LzIwMTcgMTY6NTQsIEpvbiBCbG9vbWZpZWxkIHdyb3RlOgo+IEJYVCBoYXMgYSBI L1cgaXNzdWUgd2l0aCBJT01NVSB3aGljaCBjYW4gbGVhZCB0byBzeXN0ZW0gaGFuZ3Mgd2hlbgo+ IEFwZXJ0dXJlIGFjY2Vzc2VzIGFyZSBxdWV1ZWQgd2l0aGluIHRoZSBHQU0gYmVoaW5kIEdUVCBB Y2Nlc3Nlcy4KPgo+IFRoaXMgcGF0Y2ggYXZvaWRzIHRoZSBjb25kaXRpb24gYnkgd3JhcHBpbmcg YWxsIEdUVCB1cGRhdGVzIGluIHN0b3BfbWFjaGluZQo+IGFuZCB1c2luZyBhIGZsdXNoaW5nIHJl YWQgcHJpb3IgdG8gcmVzdGFydGluZyB0aGUgbWFjaGluZS4KPgo+IFRoZSBzdG9wX21hY2hpbmUg Z3VhcmFudGVlcyBubyBuZXcgQXBlcnR1cmUgYWNjZXNzZXMgY2FuIGJlZ2luIHdoaWxlCj4gdGhl IFBURSB3cml0ZXMgYXJlIGJlaW5nIGVtbWl0dGVkLiBUaGUgZmx1c2hpbmcgcmVhZCBlbnN1cmVz IHRoYXQKPiBhbnkgZm9sbG93aW5nIEFwZXJ0dXJlIGFjY2Vzc2VzIGNhbm5vdCBiZWdpbiB1bnRp bCB0aGUgUFRFIHdyaXRlcwo+IGhhdmUgYmVlbiBjbGVhcmVkIG91dCBvZiB0aGUgR0FNJ3MgZmlm by4KPgo+IE9ubHkgRk9MTE9XSU5HIEFwZXJ0dXJlIGFjY2Vzc2VzIG5lZWQgdG8gYmUgc2VwYXJh dGVkIGZyb20gaW4gZmxpZ2h0Cj4gUFRFIHVwZGF0ZXMuIFBURSBXcml0ZXMgbWF5IGZvbGxvdyB0 aWdodGx5IGJlaGluZCBhbHJlYWR5IGluIGZsaWdodAo+IEFwZXJ0dXJlIGFjY2Vzc2VzLCBzbyBu byBmbHVzaGluZyByZWFkIGlzIHJlcXVpcmVkIGF0IHRoZSBzdGFydCBvZgo+IGEgUFRFIHVwZGF0 ZSBzZXF1ZW5jZS4KPgo+IFRoaXMgaXNzdWUgd2FzIHJlcHJvZHVjZWQgYnkgcnVubmluZwo+IAlp Z3QvZ2VtX3JlYWR3cml0ZSBhbmQKPiAJaWd0L2dlbV9yZW5kZXJfY29weQo+IHNpbXVsdGFuZW91 c2x5IGZyb20gZGlmZmVyZW50IHByb2Nlc3NlcywgZWFjaCBpbiBhIHRpZ2h0IGxvb3AsCj4gd2l0 aCBJTlRFTF9JT01NVSBlbmFibGVkLgo+Cj4gVGhpcyBwYXRjaCB3YXMgb3JpZ2luYWxseSBwdWJs aXNoZWQgYXM6Cj4gCWRybS9pOTE1OiBTZXJpYWxpemUgR1RUIFVwZGF0ZXMgb24gQlhUCj4KPiB2 MjogTW92ZSBieHQvaW9tbXUgZGV0ZWN0aW9uIGludG8gc3RhdGljIGZ1bmN0aW9uCj4gICAgIFJl bW92ZSAjaWZkZWYgQ09ORklHX0lOVEVMX0lPTU1VIHByb3RlY3Rpb24KPiAgICAgTWFrZSBmdW5j dGlvbiBuYW1lcyBtb3JlIHJlZmxlY3RpdmUgb2YgcHVycG9zZQo+ICAgICBNb3ZlIGZsdXNoaW5n IHJlYWQgaW50byBzdGF0aWMgZnVuY3Rpb24KPgo+IFNpZ25lZC1vZmYtYnk6IEpvbiBCbG9vbWZp ZWxkIDxqb24uYmxvb21maWVsZEBpbnRlbC5jb20+Cj4gQ2M6IEpvaG4gSGFycmlzb24gPGpvaG4u Qy5IYXJyaXNvbkBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4K PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgfCAgIDkgKysrCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgMTE0ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDEyMyBpbnNlcnRpb25zKCspCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCAxNzg4M2E4Li5iMjc4M2IyIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTMwMDYsNiArMzAwNiwxNSBAQCBzdGF0aWMgaW5saW5l IGJvb2wgaW50ZWxfc2Nhbm91dF9uZWVkc192dGRfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICAJcmV0dXJuIGZhbHNlOwo+ICB9Cj4KPiArc3RhdGljIGlubGluZSBib29s IGludGVsX2d0dF91cGRhdGVfbmVlZHNfdnRkX3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiArewo+ICsjaWZkZWYgQ09ORklHX0lOVEVMX0lPTU1VCj4gKwlpZiAoSVNfQlJP WFRPTihkZXZfcHJpdikgJiYgaW50ZWxfaW9tbXVfZ2Z4X21hcHBlZCkKPiArCQlyZXR1cm4gdHJ1 ZTsKPiArI2VuZGlmCj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gIGludCBpbnRlbF9zYW5p dGl6ZV9lbmFibGVfcHBndHQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ CQkJaW50IGVuYWJsZV9wcGd0dCk7Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ IGluZGV4IDdjNzY5ZDcuLmFiOTExNzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fZ3R0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9n dHQuYwo+IEBAIC0yMTkxLDYgKzIxOTEsMTEwIEBAIHN0YXRpYyB2b2lkIGdlbjhfZ2d0dF9jbGVh cl9yYW5nZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiAgCQlnZW44X3NldF9wdGUo Jmd0dF9iYXNlW2ldLCBzY3JhdGNoX3B0ZSk7Cj4gIH0KPgo+ICtzdGF0aWMgdm9pZCBieHRfdnRk X2d0dF93YShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCS8qCj4g KwkgKiBNYWtlIHN1cmUgdGhlIGludGVybmFsIEdBTSBmaWZvIGhhcyBiZWVuIGNsZWFyZWQgb2Yg YWxsIEdUVAo+ICsJICogV3JpdGVzIGJlZm9yZSBleGl0aW5nIHN0b3BfbWFjaGluZSgpLiBUaGlz IGd1YXJhbnRlZXMgdGhhdAo+ICsJICogYW55IEFwZXJ0dXJlIGFjY2Vzc2VzIHdhaXRpbmcgdG8g c3RhcnQgaW4gYW5vdGhlciBwcm9jZXNzCj4gKwkgKiBjYW5ub3QgYmFja3VwIGJlaGluZCB0aGUg R1RUIFdyaXRlcyBjYXVzaW5nIGEgaGFuZy4KPiArCSAqIFRoZSByZWdpc3RlciBjYW4gYmUgYW55 IGFyYml0cmFyeSBHQU0gcmVnaXN0ZXIuCj4gKwkgKi8KPiArCVBPU1RJTkdfUkVBRChHRlhfRkxT SF9DTlRMX0dFTjYpOwo+ICt9Cj4gKwo+ICtzdHJ1Y3QgaW5zZXJ0X3BhZ2Ugewo+ICsJc3RydWN0 IGk5MTVfYWRkcmVzc19zcGFjZSAqdm07Cj4gKwlkbWFfYWRkcl90IGFkZHI7Cj4gKwl1NjQgb2Zm c2V0Owo+ICsJZW51bSBpOTE1X2NhY2hlX2xldmVsIGxldmVsOwo+ICt9Owo+ICsKPiArc3RhdGlj IGludCBieHRfdnRkX2dndHRfaW5zZXJ0X3BhZ2VfX2NiKHZvaWQgKl9hcmcpCj4gK3sKPiArCXN0 cnVjdCBpbnNlcnRfcGFnZSAqYXJnID0gX2FyZzsKPiArCgpJIGRvbid0IHJlbWVtYmVyIHNlZWlu ZyBibGFuayBsaW5lcyBpbiBkZWNsYXJhdGlvbiBibG9ja3MgYW55d2hlcmUgZWxzZSAKc28gSSdk IHJlbW92ZSB0aGlzIChhbmQgYmVsb3cpLgoKQnV0IEZXSVcsIGluIGVzc2VuY2UgdGhlIHBhdGNo IGxvb2tzIGdvb2QgdG8gbWUuIEkgd2FzIGV2ZW4gc3VycHJpc2VkIAp0aGF0IEdDQyB1bmRlcnN0 YW5kcyBub3QgdG8gY29tcGxhaW4gYWJvdXQgZGVmaW5lZCBidXQgdW51c2VkIGZ1bmN0aW9ucyAK d2hlbiBJT01NVSBpcyBjb21waWxlZCBvdXQuIE9uZSBsZWFybnMgc29tZXRoaW5nIG5ldyBldmVy eSBkYXkhIChVbnRpbCAKb25lIGZvcmdldHMgaXQgYWdhaW4hKQoKUmV2aWV3ZWQtYnk6IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgo+ ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gYXJnLT52bS0+aTkxNTsKPiAr Cj4gKwlnZW44X2dndHRfaW5zZXJ0X3BhZ2UoYXJnLT52bSwgYXJnLT5hZGRyLAo+ICsJCQkJYXJn LT5vZmZzZXQsIGFyZy0+bGV2ZWwsIDApOwo+ICsKPiArCWJ4dF92dGRfZ3R0X3dhKGRldl9wcml2 KTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgYnh0X3Z0ZF9nZ3R0 X2luc2VydF9wYWdlX19CS0woc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gKwkJCQkJ ICBkbWFfYWRkcl90IGFkZHIsCj4gKwkJCQkJICB1NjQgb2Zmc2V0LAo+ICsJCQkJCSAgZW51bSBp OTE1X2NhY2hlX2xldmVsIGxldmVsLAo+ICsJCQkJCSAgdTMyIHVudXNlZCkKPiArewo+ICsJc3Ry dWN0IGluc2VydF9wYWdlIGFyZyA9IHsgdm0sIGFkZHIsIG9mZnNldCwgbGV2ZWwgfTsKPiArCj4g KwlzdG9wX21hY2hpbmUoYnh0X3Z0ZF9nZ3R0X2luc2VydF9wYWdlX19jYiwgJmFyZywgTlVMTCk7 Cj4gK30KPiArCj4gKwo+ICtzdHJ1Y3QgaW5zZXJ0X2VudHJpZXMgewo+ICsJc3RydWN0IGk5MTVf YWRkcmVzc19zcGFjZSAqdm07Cj4gKwlzdHJ1Y3Qgc2dfdGFibGUgKnN0Owo+ICsJdTY0IHN0YXJ0 Owo+ICsJZW51bSBpOTE1X2NhY2hlX2xldmVsIGxldmVsOwo+ICt9Owo+ICsKPiArc3RhdGljIGlu dCBieHRfdnRkX2dndHRfaW5zZXJ0X2VudHJpZXNfX2NiKHZvaWQgKl9hcmcpCj4gK3sKPiArCXN0 cnVjdCBpbnNlcnRfZW50cmllcyAqYXJnID0gX2FyZzsKPiArCj4gKwlzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYgPSBhcmctPnZtLT5pOTE1Owo+ICsKPiArCWdlbjhfZ2d0dF9pbnNl cnRfZW50cmllcyhhcmctPnZtLCBhcmctPnN0LAo+ICsJCQkJCWFyZy0+c3RhcnQsIGFyZy0+bGV2 ZWwsIDApOwo+ICsKPiArCWJ4dF92dGRfZ3R0X3dhKGRldl9wcml2KTsKPiArCj4gKwlyZXR1cm4g MDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgYnh0X3Z0ZF9nZ3R0X2luc2VydF9lbnRyaWVzX19C S0woc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gKwkJCQkJICAgICBzdHJ1Y3Qgc2df dGFibGUgKnN0LAo+ICsJCQkJCSAgICAgdTY0IHN0YXJ0LAo+ICsJCQkJCSAgICAgZW51bSBpOTE1 X2NhY2hlX2xldmVsIGxldmVsLAo+ICsJCQkJCSAgICAgdTMyIHVudXNlZCkKPiArewo+ICsJc3Ry dWN0IGluc2VydF9lbnRyaWVzIGFyZyA9IHsgdm0sIHN0LCBzdGFydCwgbGV2ZWwgfTsKPiArCj4g KwlzdG9wX21hY2hpbmUoYnh0X3Z0ZF9nZ3R0X2luc2VydF9lbnRyaWVzX19jYiwgJmFyZywgTlVM TCk7Cj4gK30KPiArCj4gK3N0cnVjdCBjbGVhcl9yYW5nZSB7Cj4gKwlzdHJ1Y3QgaTkxNV9hZGRy ZXNzX3NwYWNlICp2bTsKPiArCXU2NCBzdGFydDsKPiArCXU2NCBsZW5ndGg7Cj4gK307Cj4gKwo+ ICtzdGF0aWMgaW50IGJ4dF92dGRfZ2d0dF9jbGVhcl9yYW5nZV9fY2Iodm9pZCAqX2FyZykKPiAr ewo+ICsJc3RydWN0IGNsZWFyX3JhbmdlICphcmcgPSBfYXJnOwo+ICsKPiArCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGFyZy0+dm0tPmk5MTU7Cj4gKwo+ICsJZ2VuOF9nZ3R0 X2NsZWFyX3JhbmdlKGFyZy0+dm0sIGFyZy0+c3RhcnQsIGFyZy0+bGVuZ3RoKTsKPiArCj4gKwli eHRfdnRkX2d0dF93YShkZXZfcHJpdik7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0 YXRpYyB2b2lkIGJ4dF92dGRfZ2d0dF9jbGVhcl9yYW5nZV9fQktMKHN0cnVjdCBpOTE1X2FkZHJl c3Nfc3BhY2UgKnZtLAo+ICsJCQkJCSAgdTY0IHN0YXJ0LAo+ICsJCQkJCSAgdTY0IGxlbmd0aCkK PiArewo+ICsJc3RydWN0IGNsZWFyX3JhbmdlIGFyZyA9IHsgdm0sIHN0YXJ0LCBsZW5ndGggfTsK PiArCXN0b3BfbWFjaGluZShieHRfdnRkX2dndHRfY2xlYXJfcmFuZ2VfX2NiLCAmYXJnLCBOVUxM KTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgZ2VuNl9nZ3R0X2NsZWFyX3JhbmdlKHN0cnVjdCBp OTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAJCQkJICB1NjQgc3RhcnQsIHU2NCBsZW5ndGgpCj4g IHsKPiBAQCAtMjc4OSw2ICsyODkzLDE2IEBAIHN0YXRpYyBpbnQgZ2VuOF9nbWNoX3Byb2JlKHN0 cnVjdCBpOTE1X2dndHQgKmdndHQpCj4KPiAgCWdndHQtPmJhc2UuaW5zZXJ0X2VudHJpZXMgPSBn ZW44X2dndHRfaW5zZXJ0X2VudHJpZXM7Cj4KPiArCS8qIFNlcmlhbGl6ZSBHVFQgdXBkYXRlcyB3 aXRoIEFwZXJ0dXJlIG9uIEJYVCBpZiBWVC1kIGlzIG9uLiAqLwo+ICsJaWYgKGludGVsX2d0dF91 cGRhdGVfbmVlZHNfdnRkX3dhKGRldl9wcml2KSkgewo+ICsJCWdndHQtPmJhc2UuaW5zZXJ0X2Vu dHJpZXMgPSBieHRfdnRkX2dndHRfaW5zZXJ0X2VudHJpZXNfX0JLTDsKPiArCQlnZ3R0LT5iYXNl Lmluc2VydF9wYWdlICAgID0gYnh0X3Z0ZF9nZ3R0X2luc2VydF9wYWdlX19CS0w7Cj4gKwkJaWYg KCFVU0VTX0ZVTExfUFBHVFQoZGV2X3ByaXYpIHx8Cj4gKwkJICAgIGludGVsX3NjYW5vdXRfbmVl ZHNfdnRkX3dhKGRldl9wcml2KSkgewo+ICsJCQlnZ3R0LT5iYXNlLmNsZWFyX3JhbmdlID0gYnh0 X3Z0ZF9nZ3R0X2NsZWFyX3JhbmdlX19CS0w7Cj4gKwkJfQo+ICsJfQo+ICsKPiAgCWdndHQtPmlu dmFsaWRhdGUgPSBnZW42X2dndHRfaW52YWxpZGF0ZTsKPgo+ICAJcmV0dXJuIGdndHRfcHJvYmVf Y29tbW9uKGdndHQsIHNpemUpOwo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=