From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38A3EEB64DA for ; Fri, 14 Jul 2023 13:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4174nUMHJ6PlNXKXLatKFczHLBLV3WTxMeIo0m9u3yM=; b=xcJ6o1GskwJ/Bw 4mcQln2dgce6yRym2h3kM+pNEqVOlTYLQu4L1DhhYGwP25qSm3+fdZvA7t97vWPvaWNZCTa92szM2 OsrvrtqLaW39MTPveY3IiPPvgxQ9Qgzi00vDPvY8ZAIguL96WkopS7SVdevRc6hswgHv4LLRx3bso hSj5C31I2PZ7ehFUSWp1vqxKltb5CGfU7PPBQCU0++p5WuDc9LlKSBiFGdDJOT6xHgw5QlNdoCrnL lqdCASLs85Vu7Y4VR4+3/bjdmItTjNxti9zOWKmOXtcDlfq9AeYzBCDs0YC3gcDvS6tAZOUycJUcE dEVHy2xQUf6pEdtofLpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKIx5-006I8b-2L; Fri, 14 Jul 2023 13:35:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKIx2-006I83-2i for linux-riscv@lists.infradead.org; Fri, 14 Jul 2023 13:35:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 525EA61D1E; Fri, 14 Jul 2023 13:35:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A81D4C433C7; Fri, 14 Jul 2023 13:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689341715; bh=LmNuxSDhR2xVlR/o8NTwfyzlHy/wLO/mPMqtHawGjwQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Loi/16pfanheWa+qvyOzRQD2Ww3aZH0SazgDvpO4Xu+BEjwUixhWJ87f6gM5vozGQ npReio+qWUrWpngEa4Mb2oGpLVdx6SgmWPQtsobjXEJc7aLylypC6YBGIB+6Ea9RiV FkGD/Jae6rigsdElpq6PbOBaH2qv+qAk1IR5NaurpPYO/50uUGxM7/VE5vf/LuOiFX G21zStG3Bq3+UY/ZFNBbU/ZtMODMUVto1aZSPO+wfcc26YicqYJ1bal61RwrW7m/zL T7yT6KhGIMJffVit3lqc7MZzK9sXAEJUJk4aErNEeA1z5mAuCtCiTn6DTD1lA1LBap kEklyJ90rvVHQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qKIwz-00D7Bz-7Y; Fri, 14 Jul 2023 14:35:13 +0100 Date: Fri, 14 Jul 2023 14:35:12 +0100 Message-ID: <86cz0uvcof.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Subject: Re: [PATCH v5 7/9] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230710094321.1378351-1-apatel@ventanamicro.com> <20230710094321.1378351-8-apatel@ventanamicro.com> <86jzv2vpdb.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, saravanak@google.com, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, atishp@atishpatra.org, ajones@ventanamicro.com, sunilvl@ventanamicro.com, conor@kernel.org, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_063516_970289_AE59203F X-CRM114-Status: GOOD ( 48.28 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Saravana Kannan , Anup Patel , Atish Patra , linux-kernel@vger.kernel.org, Conor Dooley , Rob Herring , Palmer Dabbelt , Krzysztof Kozlowski , Paul Walmsley , Thomas Gleixner , linux-riscv@lists.infradead.org, Andrew Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxNCBKdWwgMjAyMyAxMDozNTozNCArMDEwMCwKQW51cCBQYXRlbCA8YXBhdGVsQHZl bnRhbmFtaWNyby5jb20+IHdyb3RlOgo+IAo+IE9uIEZyaSwgSnVsIDE0LCAyMDIzIGF0IDI6MzHi gK9QTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBBbnVwLAo+ ID4KPiA+IE9uIEZyaSwgMTQgSnVsIDIwMjMgMDA6NTY6MjIgKzAxMDAsCj4gPiBTYXJhdmFuYSBL YW5uYW4gPHNhcmF2YW5ha0Bnb29nbGUuY29tPiB3cm90ZToKPiA+ID4KPiA+ID4gT24gTW9uLCBK dWwgMTAsIDIwMjMgYXQgMjo0NOKAr0FNIEFudXAgUGF0ZWwgPGFwYXRlbEB2ZW50YW5hbWljcm8u Y29tPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IFRoZSBSSVNDLVYgYWR2YW5jZWQgaW50ZXJydXB0 IGFyY2hpdGVjdHVyZSAoQUlBKSBzcGVjaWZpY2F0aW9uIGRlZmluZXMKPiA+ID4gPiBhIG5ldyBp bnRlcnJ1cHQgY29udHJvbGxlciBmb3IgbWFuYWdpbmcgd2lyZWQgaW50ZXJydXB0cyBvbiBhIFJJ U0MtVgo+ID4gPiA+IHBsYXRmb3JtLiBUaGlzIG5ldyBpbnRlcnJ1cHQgY29udHJvbGxlciBpcyBy ZWZlcnJlZCB0byBhcyBhZHZhbmNlZAo+ID4gPiA+IHBsYXRmb3JtLWxldmVsIGludGVycnVwdCBj b250cm9sbGVyIChBUExJQykgd2hpY2ggY2FuIGZvcndhcmQgd2lyZWQKPiA+ID4gPiBpbnRlcnJ1 cHRzIHRvIENQVXMgKG9yIEhBUlRzKSBhcyBsb2NhbCBpbnRlcnJ1cHRzIE9SIGFzIG1lc3NhZ2UK PiA+ID4gPiBzaWduYWxlZCBpbnRlcnJ1cHRzLgo+ID4gPiA+IChGb3IgbW9yZSBkZXRhaWxzIHJl ZmVyIGh0dHBzOi8vZ2l0aHViLmNvbS9yaXNjdi9yaXNjdi1haWEpCj4gPiA+ID4KPiA+ID4gPiBU aGlzIHBhdGNoIGFkZHMgYW4gaXJxY2hpcCBkcml2ZXIgZm9yIFJJU0MtViBBUExJQyBmb3VuZCBv biBSSVNDLVYKPiA+ID4gPiBwbGF0Zm9ybXMuCj4gPiA+ID4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBBbnVwIFBhdGVsIDxhcGF0ZWxAdmVudGFuYW1pY3JvLmNvbT4KPiA+Cj4gPiBbLi4uXQo+ID4K PiA+ID4gPiArc3RhdGljIGludCBfX2luaXQgYXBsaWNfZHRfaW5pdChzdHJ1Y3QgZGV2aWNlX25v ZGUgKm5vZGUsCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3Qg ZGV2aWNlX25vZGUgKnBhcmVudCkKPiA+ID4gPiArewo+ID4gPiA+ICsgICAgICAgLyoKPiA+ID4g PiArICAgICAgICAqIFRoZSBBUExJQyBwbGF0Zm9ybSBkcml2ZXIgbmVlZHMgdG8gYmUgcHJvYmVk IGVhcmx5Cj4gPiA+ID4gKyAgICAgICAgKiBzbyBmb3IgZGV2aWNlIHRyZWU6Cj4gPiA+ID4gKyAg ICAgICAgKgo+ID4gPiA+ICsgICAgICAgICogMSkgU2V0IHRoZSBGV05PREVfRkxBR19CRVNUX0VG Rk9SVCBmbGFnIGluIGZ3bm9kZSB3aGljaAo+ID4gPiA+ICsgICAgICAgICogICAgcHJvdmlkZXMg YSBoaW50IHRvIHRoZSBkZXZpY2UgZHJpdmVyIGNvcmUgdG8gcHJvYmUgdGhlCj4gPiA+ID4gKyAg ICAgICAgKiAgICBwbGF0Zm9ybSBkcml2ZXIgZWFybHkuCj4gPiA+ID4gKyAgICAgICAgKiAyKSBD bGVhciB0aGUgT0ZfUE9QVUxBVEVEIGZsYWcgaW4gZGV2aWNlX25vZGUgYmVjYXVzZQo+ID4gPiA+ ICsgICAgICAgICogICAgb2ZfaXJxX2luaXQoKSBzZXRzIGl0IHdoaWNoIHByZXZlbnRzIGNyZWF0 aW9uIG9mCj4gPiA+ID4gKyAgICAgICAgKiAgICBwbGF0Zm9ybSBkZXZpY2UuCj4gPiA+ID4gKyAg ICAgICAgKi8KPiA+ID4gPiArICAgICAgIG5vZGUtPmZ3bm9kZS5mbGFncyB8PSBGV05PREVfRkxB R19CRVNUX0VGRk9SVDsKPiA+ID4KPiA+ID4gUGxlYXNlIHN0b3Agc3BhbW1pbmcgdXMgd2l0aCBi cm9rZW4gcGF0Y2hlcy4gQWxyZWFkeSB0b2xkIHlvdSB0aGlzIGlzCj4gPiA+IG5vdCBhbiBvcHRp b24uCj4gPiA+Cj4gPiA+IE5hY2suCj4gPgo+ID4gV2hhdCBwdXp6bGVzIG1lIGhlcmUgaXMgdGhh dCAqbm8gb3RoZXIgYXJjaCogcmVxdWlyZXMgdGhpcyBzb3J0IG9mCj4gPiBoYWNrLiBXaGF0IGlz IHNvIHNwZWNpYWwgYWJvdXQgdGhlIEFQTElDIHRoYXQgaXQgcmVxdWlyZXMgaXQ/IEkgc2VlCj4g PiBub3RoaW5nIGluIHRoaXMgcGF0Y2ggdGhhdCBldmVuIGhpbnRzIGF0IGl0LCBkZXNwaXRlIHRo ZSAiZGlzY3Vzc2lvbiIKPiA+IGluIHRoZSBsYXN0IHJvdW5kLgo+ID4KPiA+IFRoZSBydWxlcyBh cmUgc2ltcGxlOgo+ID4KPiA+IC0gZWl0aGVyIHRoZSBBUExJQyBpcyBzbyBmdW5kYW1lbnRhbCB0 byB0aGUgc3lzdGVtIHRoYXQgaXQgaGFzIHRvIGJlCj4gPiAgIGluaXRpYWxpc2VkIHN1cGVyIGVh cmx5LCBtdWNoIGxpa2UgdGhlIEdJQyBvbiBhcm02NCwgYXQgd2hpY2ggcG9pbnQKPiA+ICAgaXQg Y2Fubm90IGJlIGEgcGxhdGZvcm0gZGV2aWNlLCBhbmQgdGhlIHN0b3J5IGlzIHByZXR0eSBzaW1w bGUuCj4gPgo+ID4gLSBvciBpdCBpc24ndCB0aGF0IGZ1bmRhbWVudGFsLCBhbmQgaXQgY2FuIGJl IHByb2JlZCBhcyBhIHBsYXRmb3JtCj4gPiAgIGRldmljZSB1c2luZyB0aGUgZGVwZW5kZW5jeSBp bmZyYXN0cnVjdHVyZSB0aGF0IGlzIGFscmVhZHkgdXNlZCBieQo+ID4gICBtdWx0aXBsZSBvdGhl ciBpbnRlcnJ1cHQgY29udHJvbGxlciBkcml2ZXJzLCB3aXRob3V0IGFueSBuZWVkIHRvCj4gPiAg IG1lc3Mgd2l0aCBpbnRlcm5hbCBmbGFncy4gQWdhaW4sIHRoaXMgc2hvdWxkIGJlIHNpbXBsZSBl bm91Z2guCj4gCj4gQVBMSUMgbWFuYWdlcyBhbGwgd2lyZWQgaW50ZXJydXB0cyB3aGVyZWFzIElN U0lDIG1hbmFnZXMgYWxsCj4gTVNJcy4gQm90aCBBUExJQyBhbmQgSU1TSUMgYXJlIGZ1bmRhbWVu dGFsIGRldmljZXMgd2hpY2ggbmVlZAo+IHRvIGJlIHByb2JlZCBzdXBlciBlYXJseS4KPiAKPiBO b3cgQVBMSUMgaGFzIHR3byBtb2RlcyBvZiBvcGVyYXRpb25zOgo+IDEpIERpcmVjdCBtb2RlIHdo ZXJlIHRoZXJlIGlzIG5vIElNU0lDIGluIHRoZSBzeXN0ZW0gYW5kIEFQTElDCj4gICAgIGRpcmVj dGx5IGluamVjdHMgaW50ZXJydXB0IHRvIENQVXMKPiAyKSBNU0kgbW9kZSB3aGVyZSBJTVNJQyBp cyBwcmVzZW50IGluIHRoZSBzeXN0ZW0gYW5kIEFQTElDCj4gICAgIGNvbnZlcnRzIHdpcmVkIGlu dGVycnVwdHMgaW50byBNU0lzCj4gCj4gVGhlIEFQTElDIGRyaXZlciBhZGRlZCBieSB0aGlzIHBh dGNoIGlzIGEgY29tbW9uIGRyaXZlciBmb3IKPiBib3RoIGFib3ZlIG1vZGVzLgoKV2hpY2ggaXQg ZG9lc24ndCBuZWVkIHRvIGJlLiBZb3UgYXJlIHBvaW50bGVzc2x5IG1ha2luZyBsaWZlIGRpZmZp Y3VsdApmb3IgeW91cnNlbGYsIGFuZCBldmVyeW9uZSBlbHNlLiBUaGUgTVNJIGJyaWRnZSBiZWhh dmlvdXIgaGFzICp6ZXJvKgpyZWFzb24gdG8gYmUgdGhlIHNhbWUgZHJpdmVyIGFzIHRoZSBtYWlu ICJJIG5lZWQgaXQgc3VwZXIgZWFybHkiCmRyaXZlci4gVGhleSBtYXkgYmUgY2FsbGVkIHRoZSBz YW1lLCBidXQgdGhleSAqYXJlKiBkaWZmZXJlbnQgdGhpbmdzCmluIHRoZSBzeXN0ZW0uCgpUaGV5 IGNhbiBzaGFyZSBjb2RlLCBidXQgdGhleSBhcmUgZnVuZGFtZW50YWxseSBhIGRpZmZlcmVudCB0 aGluZyBpbgp0aGUgc3lzdGVtLiBBbmQgSSBndWVzcyB0aGlzIHNpbGx5IGFwcHJvYWNoIGhhcyBv dGhlciByYW1pZmljYXRpb25zOgp0aGUgSU1TSUMgaXMgYWxzbyBzb21lIGVhcmx5IGRyaXZlciB3 aGVuIGl0IHJlYWxseSBkb2Vzbid0IG5lZWQgdG8gYmUuCldobyBuZWVkcyBNU0lzIHRoYXQgZWFy bHkgaW4gdGhlIGxpZmUgb2YgdGhlIHN5c3RlbT8gSSBkb24ndCBidXkgdGhpcwpmb3IgZXZlbiBh IHNlY29uZC4KCkZyYW5rbHksIHRoaXMgd2hvbGUgdGhpbmcgbmVlZHMgdG8gYmUgdGFrZW4gYXBh cnQgYW5kIHJlYnVpbHQgZnJvbSB0aGUKZ3JvdW5kIHVwLgoKPiBGb3IgIzIsIEFQTElDIG5lZWRz IHRvIGJlIGEgcGxhdGZvcm0gZGV2aWNlIHRvIGNyZWF0ZSBhIGRldmljZQo+IE1TSSBkb21haW4g dXNpbmcgcGxhdGZvcm1fbXNpX2NyZWF0ZV9kZXZpY2VfZG9tYWluKCkgd2hpY2gKPiBpcyB3aHkg dGhlIEFQTElDIGRyaXZlciBpcyBhIHBsYXRmb3JtIGRyaXZlci4KCllvdSBjYW4ndCBoYXZlIHlv dXIgY2FrZSBhbmQgZWF0IGl0LiBJZiBuZWVkZWQgc3VwZXIgZWFybHksIGFuZCBpdApjYW5ub3Qg YmUgYSBwbGF0Zm9ybSBkcml2ZXIuIEVuZCBvZiB0aGUgc3RvcnkuCgpBbmQgdG8gbXkgZWFybGll ciBwb2ludDogSU1TSUMgYW5kIEFQTElDLWFzLU1TSS1icmlkZ2UgaGF2ZSBubyBwdXJwb3NlCmJl aW5nIGVhcmx5IGRyaXZlcnMuIFRoZXkgbXVzdCBiZSBwbGF0Zm9ybSBkcml2ZXJzLCBhbmQgb25s eSB0aGF0LgoKPiA+IElmIHRoZXNlIHJ1bGVzIGRvbid0IGFwcGx5IHRvIHlvdXIgc3R1ZmYsIHBs ZWFzZSBleHBsYWluIHdoYXQgaXMgc28KPiA+IGRpZmZlcmVudC4gQW5kIEkgbWVhbiBhY3R1YWxs eSBleHBsYWluIHRoZSBpc3N1ZS4gV2hpY2ggaXNuJ3QgdGVsbGluZwo+ID4gdXMgIml0IGRvZXNu J3Qgd29yayB3aXRob3V0IGl0Ii4gQmVjYXVzZSBhcyB0aGluZ3Mgc3RhbmQsIHRoZXJlIGlzIG5v Cj4gPiB3YXkgSSB3aWxsIGV2ZW4gY29uc2lkZXIgdGFraW5nIHRoaXMgdWdseSBtaXggb2YgcHJv YmluZyBtZXRob2RzLgo+IAo+IFllcywgSSBkb24ndCB3YW50IHRoaXMgdWdseSBGV05PREVfRkxB R19CRVNUX0VGRk9SVCBoYWNrCj4gaW4gdGhpcyBkcml2ZXIuCgpBbmQgeWV0IHlvdSBhcmUgaGFt bWVyaW5nIGl0IGV2ZW4gd2hlbiB0b2xkIHRoaXMgaXMgd3JvbmcuCgo+IEkgdHJpZWQgc2V2ZXJh bCB0aGluZ3MgYnV0IHNldHRpbmcgdGhlIEZXTk9ERV9GTEFHX0JFU1RfRUZGT1JUCj4gZmxhZyBp cyB0aGUgb25seSB0aGluZyB3aGljaCB3b3JrcyByaWdodCBub3cuCgpIb3cgYWJvdXQgeW91IHRh a2UgYSBzdGVwIGJhY2sgYW5kIHJlYWxpc2UgdGhhdCB0aGUgd2F5IHlvdSd2ZQphcmNoaXRlY3Rl ZCB5b3VyIGRyaXZlcnMgbWFrZXMgbGl0dGxlIHNlbnNlPyBJIGRvbid0IHRoaW5rIHlvdSBoYXZl CnRyaWVkICp0aGF0Ki4KClRoYW5rcywKCglNLgoKLS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20g dGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51 eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C312EB64DA for ; Fri, 14 Jul 2023 13:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235675AbjGNNfS (ORCPT ); Fri, 14 Jul 2023 09:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235219AbjGNNfS (ORCPT ); Fri, 14 Jul 2023 09:35:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E072C1991; Fri, 14 Jul 2023 06:35:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5CF5E61D21; Fri, 14 Jul 2023 13:35:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A81D4C433C7; Fri, 14 Jul 2023 13:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689341715; bh=LmNuxSDhR2xVlR/o8NTwfyzlHy/wLO/mPMqtHawGjwQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Loi/16pfanheWa+qvyOzRQD2Ww3aZH0SazgDvpO4Xu+BEjwUixhWJ87f6gM5vozGQ npReio+qWUrWpngEa4Mb2oGpLVdx6SgmWPQtsobjXEJc7aLylypC6YBGIB+6Ea9RiV FkGD/Jae6rigsdElpq6PbOBaH2qv+qAk1IR5NaurpPYO/50uUGxM7/VE5vf/LuOiFX G21zStG3Bq3+UY/ZFNBbU/ZtMODMUVto1aZSPO+wfcc26YicqYJ1bal61RwrW7m/zL T7yT6KhGIMJffVit3lqc7MZzK9sXAEJUJk4aErNEeA1z5mAuCtCiTn6DTD1lA1LBap kEklyJ90rvVHQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qKIwz-00D7Bz-7Y; Fri, 14 Jul 2023 14:35:13 +0100 Date: Fri, 14 Jul 2023 14:35:12 +0100 Message-ID: <86cz0uvcof.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Saravana Kannan , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Atish Patra , Andrew Jones , Sunil V L , Conor Dooley , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 7/9] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230710094321.1378351-1-apatel@ventanamicro.com> <20230710094321.1378351-8-apatel@ventanamicro.com> <86jzv2vpdb.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, saravanak@google.com, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, atishp@atishpatra.org, ajones@ventanamicro.com, sunilvl@ventanamicro.com, conor@kernel.org, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 14 Jul 2023 10:35:34 +0100, Anup Patel wrote: >=20 > On Fri, Jul 14, 2023 at 2:31=E2=80=AFPM Marc Zyngier wro= te: > > > > Anup, > > > > On Fri, 14 Jul 2023 00:56:22 +0100, > > Saravana Kannan wrote: > > > > > > On Mon, Jul 10, 2023 at 2:44=E2=80=AFAM Anup Patel wrote: > > > > > > > > The RISC-V advanced interrupt architecture (AIA) specification defi= nes > > > > a new interrupt controller for managing wired interrupts on a RISC-V > > > > platform. This new interrupt controller is referred to as advanced > > > > platform-level interrupt controller (APLIC) which can forward wired > > > > interrupts to CPUs (or HARTs) as local interrupts OR as message > > > > signaled interrupts. > > > > (For more details refer https://github.com/riscv/riscv-aia) > > > > > > > > This patch adds an irqchip driver for RISC-V APLIC found on RISC-V > > > > platforms. > > > > > > > > Signed-off-by: Anup Patel > > > > [...] > > > > > > +static int __init aplic_dt_init(struct device_node *node, > > > > + struct device_node *parent) > > > > +{ > > > > + /* > > > > + * The APLIC platform driver needs to be probed early > > > > + * so for device tree: > > > > + * > > > > + * 1) Set the FWNODE_FLAG_BEST_EFFORT flag in fwnode which > > > > + * provides a hint to the device driver core to probe the > > > > + * platform driver early. > > > > + * 2) Clear the OF_POPULATED flag in device_node because > > > > + * of_irq_init() sets it which prevents creation of > > > > + * platform device. > > > > + */ > > > > + node->fwnode.flags |=3D FWNODE_FLAG_BEST_EFFORT; > > > > > > Please stop spamming us with broken patches. Already told you this is > > > not an option. > > > > > > Nack. > > > > What puzzles me here is that *no other arch* requires this sort of > > hack. What is so special about the APLIC that it requires it? I see > > nothing in this patch that even hints at it, despite the "discussion" > > in the last round. > > > > The rules are simple: > > > > - either the APLIC is so fundamental to the system that it has to be > > initialised super early, much like the GIC on arm64, at which point > > it cannot be a platform device, and the story is pretty simple. > > > > - or it isn't that fundamental, and it can be probed as a platform > > device using the dependency infrastructure that is already used by > > multiple other interrupt controller drivers, without any need to > > mess with internal flags. Again, this should be simple enough. >=20 > APLIC manages all wired interrupts whereas IMSIC manages all > MSIs. Both APLIC and IMSIC are fundamental devices which need > to be probed super early. >=20 > Now APLIC has two modes of operations: > 1) Direct mode where there is no IMSIC in the system and APLIC > directly injects interrupt to CPUs > 2) MSI mode where IMSIC is present in the system and APLIC > converts wired interrupts into MSIs >=20 > The APLIC driver added by this patch is a common driver for > both above modes. Which it doesn't need to be. You are pointlessly making life difficult for yourself, and everyone else. The MSI bridge behaviour has *zero* reason to be the same driver as the main "I need it super early" driver. They may be called the same, but they *are* different things in the system. They can share code, but they are fundamentally a different thing in the system. And I guess this silly approach has other ramifications: the IMSIC is also some early driver when it really doesn't need to be. Who needs MSIs that early in the life of the system? I don't buy this for even a second. Frankly, this whole thing needs to be taken apart and rebuilt from the ground up. > For #2, APLIC needs to be a platform device to create a device > MSI domain using platform_msi_create_device_domain() which > is why the APLIC driver is a platform driver. You can't have your cake and eat it. If needed super early, and it cannot be a platform driver. End of the story. And to my earlier point: IMSIC and APLIC-as-MSI-bridge have no purpose being early drivers. They must be platform drivers, and only that. > > If these rules don't apply to your stuff, please explain what is so > > different. And I mean actually explain the issue. Which isn't telling > > us "it doesn't work without it". Because as things stand, there is no > > way I will even consider taking this ugly mix of probing methods. >=20 > Yes, I don't want this ugly FWNODE_FLAG_BEST_EFFORT hack > in this driver. And yet you are hammering it even when told this is wrong. > I tried several things but setting the FWNODE_FLAG_BEST_EFFORT > flag is the only thing which works right now. How about you take a step back and realise that the way you've architected your drivers makes little sense? I don't think you have tried *that*. Thanks, M. --=20 Without deviation from the norm, progress is not possible.