All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v1 3/3] KVM: arm64: Use symbolic definition for ISR_EL1.A
Date: Wed, 07 Dec 2022 11:18:10 +0000	[thread overview]
Message-ID: <86cz8vlax9.wl-maz@kernel.org> (raw)
In-Reply-To: <20221206131144.115774-4-broonie@kernel.org>

On Tue, 06 Dec 2022 13:11:44 +0000,
Mark Brown <broonie@kernel.org> wrote:
> 
> Now that we are generating ISR_EL1 we have acquired a constant for
> ISR_EL1.A, use it rather than the magic number we had been using in the KVM
> entry code.
> 
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  arch/arm64/kvm/hyp/entry.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/hyp/entry.S b/arch/arm64/kvm/hyp/entry.S
> index 435346ea1504..f3aa7738b477 100644
> --- a/arch/arm64/kvm/hyp/entry.S
> +++ b/arch/arm64/kvm/hyp/entry.S
> @@ -171,7 +171,7 @@ alternative_else
>  	dsb	sy		// Synchronize against in-flight ld/st
>  	isb			// Prevent an early read of side-effect free ISR
>  	mrs	x2, isr_el1
> -	tbnz	x2, #8, 2f	// ISR_EL1.A
> +	tbnz	x2, #ISR_EL1_A_SHIFT, 2f
>  	ret
>  	nop
>  2:

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v1 3/3] KVM: arm64: Use symbolic definition for ISR_EL1.A
Date: Wed, 07 Dec 2022 11:18:10 +0000	[thread overview]
Message-ID: <86cz8vlax9.wl-maz@kernel.org> (raw)
In-Reply-To: <20221206131144.115774-4-broonie@kernel.org>

On Tue, 06 Dec 2022 13:11:44 +0000,
Mark Brown <broonie@kernel.org> wrote:
> 
> Now that we are generating ISR_EL1 we have acquired a constant for
> ISR_EL1.A, use it rather than the magic number we had been using in the KVM
> entry code.
> 
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  arch/arm64/kvm/hyp/entry.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/hyp/entry.S b/arch/arm64/kvm/hyp/entry.S
> index 435346ea1504..f3aa7738b477 100644
> --- a/arch/arm64/kvm/hyp/entry.S
> +++ b/arch/arm64/kvm/hyp/entry.S
> @@ -171,7 +171,7 @@ alternative_else
>  	dsb	sy		// Synchronize against in-flight ld/st
>  	isb			// Prevent an early read of side-effect free ISR
>  	mrs	x2, isr_el1
> -	tbnz	x2, #8, 2f	// ISR_EL1.A
> +	tbnz	x2, #ISR_EL1_A_SHIFT, 2f
>  	ret
>  	nop
>  2:

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-07 11:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 13:11 [PATCH v1 0/3] arm64/sysreg: ISR register conversions Mark Brown
2022-12-06 13:11 ` Mark Brown
2022-12-06 13:11 ` [PATCH v1 1/3] arm64/sysreg: Add definition for ICC_NMIAR1_EL1 Mark Brown
2022-12-06 13:11   ` Mark Brown
2022-12-07 11:17   ` Marc Zyngier
2022-12-07 11:17     ` Marc Zyngier
2022-12-07 14:39     ` Mark Brown
2022-12-07 14:39       ` Mark Brown
2022-12-07 15:08       ` Marc Zyngier
2022-12-07 15:08         ` Marc Zyngier
2022-12-07 18:16         ` Mark Brown
2022-12-07 18:16           ` Mark Brown
2022-12-07 18:33           ` Marc Zyngier
2022-12-07 18:33             ` Marc Zyngier
2022-12-06 13:11 ` [PATCH v1 2/3] arm64/sysreg: Add definition of ISR_EL1 Mark Brown
2022-12-06 13:11   ` Mark Brown
2022-12-07 11:17   ` Marc Zyngier
2022-12-07 11:17     ` Marc Zyngier
2022-12-06 13:11 ` [PATCH v1 3/3] KVM: arm64: Use symbolic definition for ISR_EL1.A Mark Brown
2022-12-06 13:11   ` Mark Brown
2022-12-07 11:18   ` Marc Zyngier [this message]
2022-12-07 11:18     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cz8vlax9.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.