All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Eric Anholt <eric@anholt.net>,
	xorg-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 03/12] Don't use GetScratchPixmapHeader for shadow pixmaps
Date: Wed, 30 Jul 2014 22:49:42 -0700	[thread overview]
Message-ID: <86d2cmdqmh.fsf@hiro.keithp.com> (raw)
In-Reply-To: <87oaw6e2i4.fsf@eliezer.anholt.net>


[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]

Eric Anholt <eric@anholt.net> writes:

> This change appears to be unrelated, and possibly harmful (if X has
> dropped the last ref to the BO, but it's still the scanout buffer, a new
> allocation would now reuse the BO and scribble on scanout until the next
> modeset happens).

Yeah, it's unrelated. intel_allocate_framebuffer calls disable_reuse, so
there's no need to call it from these two other places. I'll split that
change out into a separate patch with separate comment.

> Unrelated whitespace.

There are a bunch of whitespace fixups; should I pull those into a
separate patch or just leave them scattered in the first patch to change
a file?

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-07-31  5:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 23:18 [PATCH 00/12] Rework intel 2D driver glamor support Keith Packard
2014-07-24 23:18 ` [PATCH 01/12] Stop trying to out-guess mesa for BO allocation Keith Packard
     [not found]   ` <1406243908-1123-2-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31  1:28     ` Eric Anholt
2014-07-31  5:45       ` Keith Packard
2014-08-04 16:58         ` Eric Anholt
2014-08-05  5:01           ` Keith Packard
     [not found] ` <1406243908-1123-1-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-24 23:18   ` [PATCH 02/12] Fix present debug output Keith Packard
2014-07-24 23:18   ` [PATCH 07/12] Add intel_flush to abstract flushing pending acceleration operations Keith Packard
     [not found]     ` <1406243908-1123-8-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31  1:44       ` Eric Anholt
2014-07-24 23:18   ` [PATCH 08/12] Get rid of glamor stubs in intel_glamor.h Keith Packard
     [not found]     ` <1406243908-1123-9-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31  1:47       ` Eric Anholt
2014-07-31  5:53         ` Keith Packard
2014-07-24 23:18   ` [PATCH 10/12] Add glamor back into the driver Keith Packard
     [not found]     ` <1406243908-1123-11-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31  2:28       ` Eric Anholt
     [not found]         ` <8761iedzxh.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2014-07-31  6:23           ` Keith Packard
2014-07-24 23:18   ` [PATCH 11/12] Add "none" acceleration option Keith Packard
2014-07-24 23:18   ` [PATCH 12/12] Delay initial modeset until root window contents are prepared Keith Packard
2014-07-31  2:29   ` [PATCH 00/12] Rework intel 2D driver glamor support Eric Anholt
2014-07-31  6:25     ` Keith Packard
2014-07-31  6:56     ` Keith Packard
2014-07-24 23:18 ` [PATCH 03/12] Don't use GetScratchPixmapHeader for shadow pixmaps Keith Packard
     [not found]   ` <1406243908-1123-4-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31  1:33     ` Eric Anholt
2014-07-31  5:49       ` Keith Packard [this message]
2014-08-04 16:58         ` Eric Anholt
2014-07-24 23:18 ` [PATCH 04/12] Move intel_alloc_framebuffer to intel_memory.c Keith Packard
2014-07-24 23:18 ` [PATCH 05/12] Rename uxa-specific functions and structs Keith Packard
2014-07-24 23:18 ` [PATCH 06/12] Remove glamor support from UXA acceleration Keith Packard
     [not found]   ` <1406243908-1123-7-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31  1:42     ` Eric Anholt
2014-07-31  5:52       ` Keith Packard
2014-07-24 23:18 ` [PATCH 09/12] Do more checks for proposed flip pixmaps Keith Packard
     [not found]   ` <1406243908-1123-10-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31  1:54     ` Eric Anholt
2014-07-31  6:01       ` Keith Packard
2014-07-31 14:43         ` Ville Syrjälä
2014-07-31 15:20           ` Keith Packard
     [not found]             ` <86a97pd07f.fsf-6d7jPg3SX/+z9DMzp4kqnw@public.gmane.org>
2014-07-31 16:06               ` [Intel-gfx] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86d2cmdqmh.fsf@hiro.keithp.com \
    --to=keithp@keithp.com \
    --cc=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=xorg-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.