From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 2/2] drm/i915: properly prefault for pread/pwrite Date: Fri, 18 Nov 2011 09:42:42 -0800 Message-ID: <86d3cpminh.fsf@sumi.keithp.com> References: <1317203844-2930-1-git-send-email-daniel.vetter@ffwll.ch> <1317203844-2930-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0540011846==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id A9E859E85B for ; Fri, 18 Nov 2011 09:43:00 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============0540011846== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= On Fri, 18 Nov 2011 10:12:38 +0100, Daniel Vetter wrote: > We want to prefault the last byte if the pfn of the last prefault > address doesn't match the pfn of the last byte of the userspace > address range. Only happens when userspace hands in badly aligned > address, not every time. I've rechecked and I think the code actually > does what I want it to do. Sorry, I was confused by PAGE_MASK (again); assumed it was 0xfff instead of ~0xfff. > Chris was despised at the lack of beauty of the code and I agree. Due > to the ppgtt trip to Poland I haven't gotten around to do it actually. > Actually I've just noticed that this is might be the old pwrite/pread > series (mail here still sucks). The new one fixes up the prefault > helpers in pagemap.h (instead of reinventing the wheel for i915.ko), > but they have the same issue of profound ugliness. Right, that was in a different mail thread and is still awaiting cleanups it seems. Sounds like you're having adventures in Poland at least. I'll pend this until you've gotten it finished and ready to merge. -- keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTsaZEjYtFsjWk68qAQhCHhAAnuoKSNmrIrIj/xGHJbxda1LGK9ukddPe Jnj/58ESLuMPSswrk4BN5/eOCRGZtJ3A7Wkyct5NeAiVDZhpcKxHK7wDvQc/o+xh ink2s82aBirTHthvgbirmMLlPPNk0NFeumYv1RWCWK6FQWfSH0tYodY9E3aYY3L/ 5lE2GjA/Vr9Zd0A5uHW7Nh9zPIqQd1gZ4kd00CVKkkBPhTAdKE/O5UIPzvnwR9CK XJxHCnXcMvCrjRauAndWEuuBBws+uxmwlr+b1Gthd6vR/Ba665wV8xyzIivwxX4K C2zDOeSW8JJAPplzp4ulKC+P5al48RFXcTwmqRjqxl/k2FNNdh2IEiaGWH8QYrA2 4XBrJcKm/1AjbU5yF1TEiwpFJv8SbpdDs6pm39ZgzO1n/buS6nI2VhqMDGC4R+Lg rkZOds8OBs3we3jntd7j0j4G70ERaxI1dIPM0DdJ0kujZ+q85JpKhDXrkL7tQvyD MXX2UBndcXg4QNvlgUHnji1GQcXYp7l8jObsUpY3nuC1IjvxJ/rmqDu4piAG+qDg CNiVIwr5DILUEb8MBsjWUT62yDPR65yW6vinputedq3DBrUvfBr6VWF/CpRf7j/l qZ5M4fLcgkB8lVPXH1Bg25Djc9XXnqHy5H6ilO5E/RsQyZ9auSbgBhb95f7ff38L r0SR7JY6VxM= =yH7T -----END PGP SIGNATURE----- --=-=-=-- --===============0540011846== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0540011846==--