From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Vadim Fedorenko <vadfed@meta.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
X86 ML <x86@kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 1/2] bpf: add bpf_get_hw_counter kfunc
Date: Thu, 24 Oct 2024 15:34:25 -0700 [thread overview]
Message-ID: <86e152e9008a66a84694cb7f57a3588eeb33cf03.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQKApKc=UBftjUuRVSpB9nb12fxmAM=3RviQvwF1umt21A@mail.gmail.com>
On Thu, 2024-10-24 at 15:28 -0700, Alexei Starovoitov wrote:
[...]
> > call->imm is BTF id, call->off is ID of the BTF itself.
>
> it's actually offset in fd_array
Sure.
> > I asked Vadim to add this check to make sure that imm points to the
> > kernel BTF.
>
> makes sense.
>
> is_fastcall_kfunc_call(&meta) && meta.btf == btf_vmlinux && ..
>
> would have been much more obvious.
Yes, this one looks better.
next prev parent reply other threads:[~2024-10-24 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 20:51 [PATCH bpf-next v2 1/2] bpf: add bpf_get_hw_counter kfunc Vadim Fedorenko
2024-10-24 20:51 ` [PATCH bpf-next v2 2/2] selftests/bpf: add selftest to check rdtsc jit Vadim Fedorenko
2024-10-24 22:14 ` [PATCH bpf-next v2 1/2] bpf: add bpf_get_hw_counter kfunc Alexei Starovoitov
2024-10-24 22:17 ` Eduard Zingerman
2024-10-24 22:28 ` Alexei Starovoitov
2024-10-24 22:34 ` Eduard Zingerman [this message]
2024-10-24 23:17 ` Andrii Nakryiko
2024-10-25 14:01 ` Vadim Fedorenko
2024-10-25 18:31 ` Andrii Nakryiko
2024-10-26 0:32 ` kernel test robot
2024-10-26 1:24 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e152e9008a66a84694cb7f57a3588eeb33cf03.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=tglx@linutronix.de \
--cc=vadfed@meta.com \
--cc=vadim.fedorenko@linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.