From: Marc Zyngier <maz@kernel.org>
To: Fuad Tabba <tabba@google.com>
Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
oliver.upton@linux.dev, will@kernel.org, joey.gouly@arm.com,
suzuki.poulose@arm.com, yuzenghui@huawei.com,
catalin.marinas@arm.com, vdonnefort@google.com,
qperret@google.com, sebastianene@google.com, keirf@google.com,
smostafa@google.com
Subject: Re: [PATCH v2 2/2] arm64: sysreg: Add validation checks to sysreg header generation script
Date: Thu, 14 Aug 2025 08:16:03 +0100 [thread overview]
Message-ID: <86ecte8jbg.wl-maz@kernel.org> (raw)
In-Reply-To: <20250813164506.1203851-3-tabba@google.com>
On Wed, 13 Aug 2025 17:45:06 +0100,
Fuad Tabba <tabba@google.com> wrote:
>
> The gen_sysreg.awk script processes the system register specification in
> the sysreg text file to generate C macro definitions. The current script
> will silently accept certain errors in the specification file, leading
> to incorrect header generation.
>
> For example, a Sysreg or SysregFields can be accidentally duplicated,
> causing its macros to be emitted twice. Or an Enum can contain duplicate
> values for different items, which is architecturally incorrect.
>
> Add checks to catch these errors at build time. The script now tracks
> all seen Sysreg and SysregFields definitions and checks for duplicates.
> It also tracks values within each Enum block to ensure entries are
> unique.
>
> Signed-off-by: Fuad Tabba <tabba@google.com>
Thanks for adding these checks, most useful.
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2025-08-14 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 16:45 [PATCH v2 0/2] arm64: sysreg: Fix sysreg field definitions and generation script Fuad Tabba
2025-08-13 16:45 ` [PATCH v2 1/2] arm64: sysreg: Fix and tidyup sysreg field definitions Fuad Tabba
2025-08-14 7:13 ` Marc Zyngier
2025-08-13 16:45 ` [PATCH v2 2/2] arm64: sysreg: Add validation checks to sysreg header generation script Fuad Tabba
2025-08-14 7:16 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ecte8jbg.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=keirf@google.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oliver.upton@linux.dev \
--cc=qperret@google.com \
--cc=sebastianene@google.com \
--cc=smostafa@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=vdonnefort@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.