Re: [PATCH 0/2] KVM: arm64: Control visibility of S1PIE related sysregs to userspace

[Marc Zyngier <maz@kernel.org>]

On Wed, 21 Aug 2024 14:07:14 +0100,
Mark Brown <broonie@kernel.org> wrote:
> 
> While looking at the KVM system register code I noticed that we do not
> have visibility operations for TCR2 or the S1PIE registers, I may be
> missing some reason why they are not required but in case I'm not I
> figured the most direct way to ask was to propose adding the operations.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> Mark Brown (2):
>       KVM: arm64: Hide TCR2_EL1 from userspace when disabled for guests
>       KVM: arm64: Hide S1PIE registers from userspace when disabled for guests
> 
>  arch/arm64/include/asm/kvm_host.h |  6 ++++++
>  arch/arm64/kvm/sys_regs.c         | 31 ++++++++++++++++++++++++++-----
>  2 files changed, 32 insertions(+), 5 deletions(-)

If you are going to do this, please add it on top of [1], and handle
the corresponding EL2 registers.

Thanks,

	M.

[1] https://lore.kernel.org/20240813144738.2048302-1-maz@kernel.org

-- 
Without deviation from the norm, progress is not possible.