From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6997C2D6 for ; Tue, 4 Jun 2024 13:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717509175; cv=none; b=n3g/MThm1L5P6eq2qkZ6fEJohTRKfltMdLd3bl3oZ0XaXqVadWd8JBDVoaQ4TYlACbervrLpPryf7bgyZRfTnj1YJA1niBfon9lRVJL09scgx936RTbkkaI0acLzYZCWBbiw6UNegv4SfxCf5YSK1COLKq2Anr290JVPwbztqHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717509175; c=relaxed/simple; bh=pIU2QOJ5jPTRecXRSzM/ZjIrphPZ5brAhK9qMXCoL+0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=JrM428mHiwZusdS3fYjW3siIZoQWhPp0oddX1jUeBmw7KevbPC0Acj5+6t5ak//8jf3/I1XjYzuindAZdPxS4SyAoZqWRwJqcKcrVZ0O50OoPVulCy5eGw5trfTI+RMuxYojzbIxTwyIdkg3ZB38OSLGsJ3ioz8xpwzVLvqhjQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ifYDZbC3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ifYDZbC3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59643C32786; Tue, 4 Jun 2024 13:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717509175; bh=pIU2QOJ5jPTRecXRSzM/ZjIrphPZ5brAhK9qMXCoL+0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ifYDZbC36ijow66QiqYoO67kVAS1cZHGnEA1rpdWMOkb0YdpIVUITJdV3HBpZaGby /nH+jnTgAZkfjkekMscvsW8MF4w4yr4I63lFxaG7rh27uyzlG2+ErKias0Iivvg4V5 78NwcPsfwkWx9Dt0A9o3XhuC0HE3G02w4JQfpmuMf1dA50M9Fx28pqw+0b31CDt/x6 le7rk/dmVO80UXArDVbHgHTFdE+jAJmKBRCpH5LQTbXLA6FEMRCfvALlzY/UaAXdFP CUV7/7eE8wUGC7DI3rCVPrYY/eSdKLomuX0BXAlMZwR0whQk495uXVerofHcd4/HDU 5futPVzswtzcw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sEUar-000ax3-5Y; Tue, 04 Jun 2024 14:52:53 +0100 Date: Tue, 04 Jun 2024 14:52:52 +0100 Message-ID: <86ed9clsqz.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Fuad Tabba , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com Subject: Re: [PATCH v4 6/9] KVM: arm64: Eagerly restore host fpsimd/sve state in pKVM In-Reply-To: References: <20240603122852.3923848-1-tabba@google.com> <20240603122852.3923848-7-tabba@google.com> <728c100c-ea38-4802-832d-04521821d169@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 04 Jun 2024 14:13:16 +0100, Mark Brown wrote: >=20 > [1 ] > On Tue, Jun 04, 2024 at 01:03:07PM +0100, Fuad Tabba wrote: > > On Mon, Jun 3, 2024 at 4:52=E2=80=AFPM Mark Brown = wrote: > > > On Mon, Jun 03, 2024 at 01:28:48PM +0100, Fuad Tabba wrote: >=20 > > > > +static void fpsimd_sve_flush(void) > > > > +{ > > > > + *host_data_ptr(fp_owner) =3D FP_STATE_HOST_OWNED; > > > > +} >=20 > > > My previous comments about this being confusing still stand. >=20 > > Sorry, I missed this in my reply to v3. >=20 > > This follows the convention for save/flush in hyp-main.c. Since the > > act of flushing the fpsimd/sve state is lazy, i.e., only takes place > > if the guest were to use fpsimd/sve, then the only thing that we need > > to do to flush is to mark the state as owned by the host. >=20 > I think this needs a comment mentioning what's going on here. >=20 > > You suggested inlining this, but since this is static, I think the > > compiler would do that. Even though it's only one line, it maintains > > symmetry with fpsimd_sve_sync(). >=20 > The reason I was suggesting inlining was that it removes the need to > name the function. You're missing the point. The name is important, and the current name is correct. We use *flush (resp. *sync) for operations that need to happen before (resp. after) the entry into the guest. This is consistent with the rest of the code base for most of the subsystems KVM/arm64 deals with. So the current form of this function, as a standalone function with its current name, stays. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1201C25B78 for ; Tue, 4 Jun 2024 13:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1fcaz7uA4FYN4wRVO6neeHsj7i8wUA8tuae+faaeG+8=; b=PmXxNyS7gETtSc pXmjmp6qLPd8d5HgSYsuHm0l+Rf5ZrvvCJBmdFVRi3CExOiMkvYfoXqRCTxtrl5obojEZkrX1j1Hf 8VvxgtoFRFXr0Cq9sXhMsmbo0Lc8WCuH6ynsLY5EK2D/E71EP4xazuJ6N97HYUx2Y7XIjMzPIIeGv DOW41PseZnZ9wbMN1BwLZe+vjV8dyqun6/NIpPuGyWOaymJJryaAtxC9BtWNpW6b7W23Cvv2duTuK PyE52dwMYVd3FIH1GzqJXvRxs3gJgdMlV+jl+Pv/i82Fc7EGaj7Q6CqhYK9rLYqUn3xeMkLbXr6l3 0dMw23zLaqx/Gou3qRAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEUax-00000002ZuC-0AKF; Tue, 04 Jun 2024 13:52:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEUau-00000002ZtC-2xqW for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 13:52:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AA812612E3; Tue, 4 Jun 2024 13:52:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59643C32786; Tue, 4 Jun 2024 13:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717509175; bh=pIU2QOJ5jPTRecXRSzM/ZjIrphPZ5brAhK9qMXCoL+0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ifYDZbC36ijow66QiqYoO67kVAS1cZHGnEA1rpdWMOkb0YdpIVUITJdV3HBpZaGby /nH+jnTgAZkfjkekMscvsW8MF4w4yr4I63lFxaG7rh27uyzlG2+ErKias0Iivvg4V5 78NwcPsfwkWx9Dt0A9o3XhuC0HE3G02w4JQfpmuMf1dA50M9Fx28pqw+0b31CDt/x6 le7rk/dmVO80UXArDVbHgHTFdE+jAJmKBRCpH5LQTbXLA6FEMRCfvALlzY/UaAXdFP CUV7/7eE8wUGC7DI3rCVPrYY/eSdKLomuX0BXAlMZwR0whQk495uXVerofHcd4/HDU 5futPVzswtzcw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sEUar-000ax3-5Y; Tue, 04 Jun 2024 14:52:53 +0100 Date: Tue, 04 Jun 2024 14:52:52 +0100 Message-ID: <86ed9clsqz.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Fuad Tabba , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com Subject: Re: [PATCH v4 6/9] KVM: arm64: Eagerly restore host fpsimd/sve state in pKVM In-Reply-To: References: <20240603122852.3923848-1-tabba@google.com> <20240603122852.3923848-7-tabba@google.com> <728c100c-ea38-4802-832d-04521821d169@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_065256_905171_91EE8FAC X-CRM114-Status: GOOD ( 25.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwNCBKdW4gMjAyNCAxNDoxMzoxNiArMDEwMCwKTWFyayBCcm93biA8YnJvb25pZUBr ZXJuZWwub3JnPiB3cm90ZToKPiAKPiBbMSAgPHRleHQvcGxhaW47IHV0Zi04IChxdW90ZWQtcHJp bnRhYmxlKT5dCj4gT24gVHVlLCBKdW4gMDQsIDIwMjQgYXQgMDE6MDM6MDdQTSArMDEwMCwgRnVh ZCBUYWJiYSB3cm90ZToKPiA+IE9uIE1vbiwgSnVuIDMsIDIwMjQgYXQgNDo1MuKAr1BNIE1hcmsg QnJvd24gPGJyb29uaWVAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+IE9uIE1vbiwgSnVuIDAzLCAy MDI0IGF0IDAxOjI4OjQ4UE0gKzAxMDAsIEZ1YWQgVGFiYmEgd3JvdGU6Cj4gCj4gPiA+ID4gK3N0 YXRpYyB2b2lkIGZwc2ltZF9zdmVfZmx1c2godm9pZCkKPiA+ID4gPiArewo+ID4gPiA+ICsgICAg ICpob3N0X2RhdGFfcHRyKGZwX293bmVyKSA9IEZQX1NUQVRFX0hPU1RfT1dORUQ7Cj4gPiA+ID4g K30KPiAKPiA+ID4gTXkgcHJldmlvdXMgY29tbWVudHMgYWJvdXQgdGhpcyBiZWluZyBjb25mdXNp bmcgc3RpbGwgc3RhbmQuCj4gCj4gPiBTb3JyeSwgSSBtaXNzZWQgdGhpcyBpbiBteSByZXBseSB0 byB2My4KPiAKPiA+IFRoaXMgZm9sbG93cyB0aGUgY29udmVudGlvbiBmb3Igc2F2ZS9mbHVzaCBp biBoeXAtbWFpbi5jLiBTaW5jZSB0aGUKPiA+IGFjdCBvZiBmbHVzaGluZyB0aGUgZnBzaW1kL3N2 ZSBzdGF0ZSBpcyBsYXp5LCBpLmUuLCBvbmx5IHRha2VzIHBsYWNlCj4gPiBpZiB0aGUgZ3Vlc3Qg d2VyZSB0byB1c2UgZnBzaW1kL3N2ZSwgdGhlbiB0aGUgb25seSB0aGluZyB0aGF0IHdlIG5lZWQK PiA+IHRvIGRvIHRvIGZsdXNoIGlzIHRvIG1hcmsgdGhlIHN0YXRlIGFzIG93bmVkIGJ5IHRoZSBo b3N0Lgo+IAo+IEkgdGhpbmsgdGhpcyBuZWVkcyBhIGNvbW1lbnQgbWVudGlvbmluZyB3aGF0J3Mg Z29pbmcgb24gaGVyZS4KPiAKPiA+IFlvdSBzdWdnZXN0ZWQgaW5saW5pbmcgdGhpcywgYnV0IHNp bmNlIHRoaXMgaXMgc3RhdGljLCBJIHRoaW5rIHRoZQo+ID4gY29tcGlsZXIgd291bGQgZG8gdGhh dC4gRXZlbiB0aG91Z2ggaXQncyBvbmx5IG9uZSBsaW5lLCBpdCBtYWludGFpbnMKPiA+IHN5bW1l dHJ5IHdpdGggZnBzaW1kX3N2ZV9zeW5jKCkuCj4gCj4gVGhlIHJlYXNvbiBJIHdhcyBzdWdnZXN0 aW5nIGlubGluaW5nIHdhcyB0aGF0IGl0IHJlbW92ZXMgdGhlIG5lZWQgdG8KPiBuYW1lIHRoZSBm dW5jdGlvbi4KCllvdSdyZSBtaXNzaW5nIHRoZSBwb2ludC4KClRoZSBuYW1lIGlzIGltcG9ydGFu dCwgYW5kIHRoZSBjdXJyZW50IG5hbWUgaXMgY29ycmVjdC4gV2UgdXNlICpmbHVzaAoocmVzcC4g KnN5bmMpIGZvciBvcGVyYXRpb25zIHRoYXQgbmVlZCB0byBoYXBwZW4gYmVmb3JlIChyZXNwLiBh ZnRlcikKdGhlIGVudHJ5IGludG8gdGhlIGd1ZXN0LiBUaGlzIGlzIGNvbnNpc3RlbnQgd2l0aCB0 aGUgcmVzdCBvZiB0aGUgY29kZQpiYXNlIGZvciBtb3N0IG9mIHRoZSBzdWJzeXN0ZW1zIEtWTS9h cm02NCBkZWFscyB3aXRoLgoKU28gdGhlIGN1cnJlbnQgZm9ybSBvZiB0aGlzIGZ1bmN0aW9uLCBh cyBhIHN0YW5kYWxvbmUgZnVuY3Rpb24gd2l0aAppdHMgY3VycmVudCBuYW1lLCBzdGF5cy4KCglN LgoKLS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBw b3NzaWJsZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK