From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A02C76191 for ; Fri, 26 Jul 2019 12:30:53 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 4530722ADA for ; Fri, 26 Jul 2019 12:30:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4530722ADA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B1B6C4A621; Fri, 26 Jul 2019 08:30:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rqqCo7-BLI5o; Fri, 26 Jul 2019 08:30:51 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 60E714A615; Fri, 26 Jul 2019 08:30:51 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 67BC54A5E5 for ; Fri, 26 Jul 2019 08:30:50 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cj237PaLo7Oe for ; Fri, 26 Jul 2019 08:30:48 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BDBBB4A5E4 for ; Fri, 26 Jul 2019 08:30:48 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 499B7337; Fri, 26 Jul 2019 05:30:48 -0700 (PDT) Received: from big-swifty.misterjones.org (unknown [10.37.13.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C4A13F694; Fri, 26 Jul 2019 05:30:46 -0700 (PDT) Date: Fri, 26 Jul 2019 13:30:44 +0100 Message-ID: <86ef2dnfkb.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Anders Roxell Subject: Re: [PATCH 1/2] arm64: KVM: regmap: Mark expected switch fall-through In-Reply-To: <20190726112705.19000-1-anders.roxell@linaro.org> References: <20190726112705.19000-1-anders.roxell@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgQW5kZXJzLAoKT24gRnJpLCAyNiBKdWwgMjAxOSAxMjoyNzowNSArMDEwMCwKQW5kZXJzIFJv eGVsbCA8YW5kZXJzLnJveGVsbEBsaW5hcm8ub3JnPiB3cm90ZToKPiAKPiBXaGVuIGZhbGwtdGhy b3VnaCB3YXJuaW5ncyB3YXMgZW5hYmxlZCBieSBkZWZhdWx0LCBjb21taXQgZDkzNTEyZWYwZjBl Cj4gKCJNYWtlZmlsZTogR2xvYmFsbHkgZW5hYmxlIGZhbGwtdGhyb3VnaCB3YXJuaW5nIiksIHRo ZSBmb2xsb3dpbmcKPiB3YXJuaW5ncyB3YXMgc3RhcnRpbmcgdG8gc2hvdyB1cDoKPiAKPiBJbiBm aWxlIGluY2x1ZGVkIGZyb20gLi4vYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1fZW11bGF0ZS5o OjE5LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzox MzoKPiAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzogSW4gZnVuY3Rpb24g4oCYdmNwdV93cml0 ZV9zcHNyMzLigJk6Cj4gLi4vYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faHlwLmg6MzE6Mzog d2FybmluZzogdGhpcyBzdGF0ZW1lbnQgbWF5IGZhbGwKPiAgdGhyb3VnaCBbLVdpbXBsaWNpdC1m YWxsdGhyb3VnaD1dCj4gICAgYXNtIHZvbGF0aWxlKEFMVEVSTkFUSVZFKF9fbXNyX3MociMjbnZo LCAiJXgwIiksIFwKPiAgICBefn4KPiAuLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9oeXAu aDo0NjozMTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdyaXRlX3N5c3JlZ19lbHji gJkKPiAgI2RlZmluZSB3cml0ZV9zeXNyZWdfZWwxKHYscikgd3JpdGVfc3lzcmVnX2VseCh2LCBy LCBfRUwxLCBfRUwxMikKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+ fn5+fn5+fgo+IC4uL2FyY2gvYXJtNjQva3ZtL3JlZ21hcC5jOjE4MDozOiBub3RlOiBpbiBleHBh bnNpb24gb2YgbWFjcm8g4oCYd3JpdGVfc3lzcmVnX2VsMeKAmQo+ICAgIHdyaXRlX3N5c3JlZ19l bDEodiwgU1lTX1NQU1IpOwo+ICAgIF5+fn5+fn5+fn5+fn5+fn4KPiAuLi9hcmNoL2FybTY0L2t2 bS9yZWdtYXAuYzoxODE6Mjogbm90ZTogaGVyZQo+ICAgY2FzZSBLVk1fU1BTUl9BQlQ6Cj4gICBe fn5+Cj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4uL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vY3B1 dHlwZS5oOjEzMiwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi4vYXJjaC9hcm02NC9pbmNsdWRl L2FzbS9jYWNoZS5oOjgsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgv Y2FjaGUuaDo2LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L3ByaW50 ay5oOjksCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgva2VybmVsLmg6 MTUsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvYXNtLWdlbmVyaWMvYnVnLmg6 MTgsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vYnVn Lmg6MjYsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgvYnVnLmg6NSwK PiAgICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9tbWRlYnVnLmg6NSwKPiAg ICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9tbS5oOjksCj4gICAgICAgICAg ICAgICAgICBmcm9tIC4uL2FyY2gvYXJtNjQva3ZtL3JlZ21hcC5jOjExOgo+IC4uL2FyY2gvYXJt NjQvaW5jbHVkZS9hc20vc3lzcmVnLmg6ODM3OjI6IHdhcm5pbmc6IHRoaXMgc3RhdGVtZW50IG1h eSBmYWxsCj4gIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+ICAgYXNtIHZvbGF0 aWxlKCJtc3IgIiBfX3N0cmluZ2lmeShyKSAiLCAleDAiICBcCj4gICBefn4KPiAuLi9hcmNoL2Fy bTY0L2t2bS9yZWdtYXAuYzoxODI6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdy aXRlX3N5c3JlZ+KAmQo+ICAgIHdyaXRlX3N5c3JlZyh2LCBzcHNyX2FidCk7Cj4gICAgXn5+fn5+ fn5+fn5+Cj4gLi4vYXJjaC9hcm02NC9rdm0vcmVnbWFwLmM6MTgzOjI6IG5vdGU6IGhlcmUKPiAg IGNhc2UgS1ZNX1NQU1JfVU5EOgo+ICAgXn5+fgo+IAo+IFJld29yayB0byBhZGQgYSAnYnJlYWs7 JyBpbiB0aGUgc3dpY2gtY2FzZSBzaW5jZSBpdCBkaWRuJ3QgaGF2ZSB0aGF0Lgo+IFRoYXQgYWxz byBtYWRlIHRoZSBjb21waWxlciBoYXBweSBhbmQgZGlkbid0IHdhcm4gYWJvdXQgZmFsbC10aHJv dWdoLgo+IAo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnICMgdjMuMTYrCgpFcm0uLi4gQXJl IHlvdSBzdXJlIGFib3V0IHRoYXQ/IEhlcmUncyB3aGF0IEkgaGF2ZToKCiQgZ2l0IGRlc2NyaWJl IC0tY29udGFpbnMgIGE4OTI4MTk1NjBjNAprdm0tYXJtLWZvci12NC4xN340NAokIGdpdCBkZXNj cmliZSAtLWNvbnRhaW5zIC0tbWF0Y2g9J3YqJyBhODkyODE5NTYwYzQKdjQuMTctcmMxfjcyXjJ+ MzZeMn40NAoKCj4gRml4ZXM6IGE4OTI4MTk1NjBjNCAoIktWTTogYXJtNjQ6IFByZXBhcmUgdG8g aGFuZGxlIGRlZmVycmVkIHNhdmUvcmVzdG9yZSBvZiAzMi1iaXQgcmVnaXN0ZXJzIikKPiBTaWdu ZWQtb2ZmLWJ5OiBBbmRlcnMgUm94ZWxsIDxhbmRlcnMucm94ZWxsQGxpbmFyby5vcmc+Cj4gLS0t Cj4gIGFyY2gvYXJtNjQva3ZtL3JlZ21hcC5jIHwgNSArKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwg NSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3JlZ21hcC5j IGIvYXJjaC9hcm02NC9rdm0vcmVnbWFwLmMKPiBpbmRleCAwZDYwZTRmMGFmNjYuLmE5MDAxODFl Mzg2NyAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYwo+ICsrKyBiL2FyY2gv YXJtNjQva3ZtL3JlZ21hcC5jCj4gQEAgLTE3OCwxMyArMTc4LDE4IEBAIHZvaWQgdmNwdV93cml0 ZV9zcHNyMzIoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBsb25nIHYpCj4gIAlzd2l0 Y2ggKHNwc3JfaWR4KSB7Cj4gIAljYXNlIEtWTV9TUFNSX1NWQzoKPiAgCQl3cml0ZV9zeXNyZWdf ZWwxKHYsIFNZU19TUFNSKTsKPiArCQlicmVhazsKPiAgCWNhc2UgS1ZNX1NQU1JfQUJUOgo+ICAJ CXdyaXRlX3N5c3JlZyh2LCBzcHNyX2FidCk7Cj4gKwkJYnJlYWs7Cj4gIAljYXNlIEtWTV9TUFNS X1VORDoKPiAgCQl3cml0ZV9zeXNyZWcodiwgc3Bzcl91bmQpOwo+ICsJCWJyZWFrOwo+ICAJY2Fz ZSBLVk1fU1BTUl9JUlE6Cj4gIAkJd3JpdGVfc3lzcmVnKHYsIHNwc3JfaXJxKTsKPiArCQlicmVh azsKPiAgCWNhc2UgS1ZNX1NQU1JfRklROgo+ICAJCXdyaXRlX3N5c3JlZyh2LCBzcHNyX2ZpcSk7 Cj4gKwkJYnJlYWs7Cj4gIAl9Cj4gIH0KCk90aGVyd2lzZSBsb29rcyBsaWtlIHRoZSByaWdodCBm aXggdG8gbWUuIExldCBtZSBrbm93IHdoYXQgeW91IHRoaW5rCmFib3V0IHRoZSBGaXhlczogdGFn IChubyBuZWVkIHRvIHJlc2VuZCBmb3IgdGhhdCkuCgpUaGFua3MsCgoJTS4KCi0tIApKYXp6IGlz IG5vdCBkZWFkLCBpdCBqdXN0IHNtZWxscyBmdW5ueS4KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMu Y3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlz dGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7677DC7618B for ; Fri, 26 Jul 2019 12:30:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C63722ADA for ; Fri, 26 Jul 2019 12:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Reixg/YL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C63722ADA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X65v1NAjlyS+VJBRhJ1KB+NlRfRGUIDVQZplavYONy0=; b=Reixg/YL87G713 mfnkF4CqTNKSIfkNiMI77VqOlk5D0i0P8DJi2mnHyijKFQIR+O5k8/nF//TtVsKQ6jH6w3KSEHe1t 4wx9XqAQR7f7rCS6j272Fv/kg8UPiRiaaQLUZCiHtK4HnCKMFHsomvsownEVBERQw10hidB99W7So wOQTLqnarq4rpbWtbcrXBORvFQOHd9Hz9Ol6zpmGY9yDboo22aUSNFl8JBwhf3ny+WIk/phYkM8wv sSsRMXiKVFowMInKpitcMAzPPuxwPbZk7et5HHVAEdWOaTpK4MrNObP95VMMEtp0sVaPtl2S4Y5tx GRS5xOIrDDklUMydkyNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqzN5-0005jj-Ns; Fri, 26 Jul 2019 12:30:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqzN2-0005iv-Pf for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 12:30:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 499B7337; Fri, 26 Jul 2019 05:30:48 -0700 (PDT) Received: from big-swifty.misterjones.org (unknown [10.37.13.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C4A13F694; Fri, 26 Jul 2019 05:30:46 -0700 (PDT) Date: Fri, 26 Jul 2019 13:30:44 +0100 Message-ID: <86ef2dnfkb.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Anders Roxell Subject: Re: [PATCH 1/2] arm64: KVM: regmap: Mark expected switch fall-through In-Reply-To: <20190726112705.19000-1-anders.roxell@linaro.org> References: <20190726112705.19000-1-anders.roxell@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_053048_921443_96A89B9D X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQW5kZXJzLAoKT24gRnJpLCAyNiBKdWwgMjAxOSAxMjoyNzowNSArMDEwMCwKQW5kZXJzIFJv eGVsbCA8YW5kZXJzLnJveGVsbEBsaW5hcm8ub3JnPiB3cm90ZToKPiAKPiBXaGVuIGZhbGwtdGhy b3VnaCB3YXJuaW5ncyB3YXMgZW5hYmxlZCBieSBkZWZhdWx0LCBjb21taXQgZDkzNTEyZWYwZjBl Cj4gKCJNYWtlZmlsZTogR2xvYmFsbHkgZW5hYmxlIGZhbGwtdGhyb3VnaCB3YXJuaW5nIiksIHRo ZSBmb2xsb3dpbmcKPiB3YXJuaW5ncyB3YXMgc3RhcnRpbmcgdG8gc2hvdyB1cDoKPiAKPiBJbiBm aWxlIGluY2x1ZGVkIGZyb20gLi4vYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1fZW11bGF0ZS5o OjE5LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzox MzoKPiAuLi9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYzogSW4gZnVuY3Rpb24g4oCYdmNwdV93cml0 ZV9zcHNyMzLigJk6Cj4gLi4vYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faHlwLmg6MzE6Mzog d2FybmluZzogdGhpcyBzdGF0ZW1lbnQgbWF5IGZhbGwKPiAgdGhyb3VnaCBbLVdpbXBsaWNpdC1m YWxsdGhyb3VnaD1dCj4gICAgYXNtIHZvbGF0aWxlKEFMVEVSTkFUSVZFKF9fbXNyX3MociMjbnZo LCAiJXgwIiksIFwKPiAgICBefn4KPiAuLi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9oeXAu aDo0NjozMTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdyaXRlX3N5c3JlZ19lbHji gJkKPiAgI2RlZmluZSB3cml0ZV9zeXNyZWdfZWwxKHYscikgd3JpdGVfc3lzcmVnX2VseCh2LCBy LCBfRUwxLCBfRUwxMikKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+ fn5+fn5+fgo+IC4uL2FyY2gvYXJtNjQva3ZtL3JlZ21hcC5jOjE4MDozOiBub3RlOiBpbiBleHBh bnNpb24gb2YgbWFjcm8g4oCYd3JpdGVfc3lzcmVnX2VsMeKAmQo+ICAgIHdyaXRlX3N5c3JlZ19l bDEodiwgU1lTX1NQU1IpOwo+ICAgIF5+fn5+fn5+fn5+fn5+fn4KPiAuLi9hcmNoL2FybTY0L2t2 bS9yZWdtYXAuYzoxODE6Mjogbm90ZTogaGVyZQo+ICAgY2FzZSBLVk1fU1BTUl9BQlQ6Cj4gICBe fn5+Cj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4uL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vY3B1 dHlwZS5oOjEzMiwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi4vYXJjaC9hcm02NC9pbmNsdWRl L2FzbS9jYWNoZS5oOjgsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgv Y2FjaGUuaDo2LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L3ByaW50 ay5oOjksCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgva2VybmVsLmg6 MTUsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvYXNtLWdlbmVyaWMvYnVnLmg6 MTgsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vYnVn Lmg6MjYsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgvYnVnLmg6NSwK PiAgICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9tbWRlYnVnLmg6NSwKPiAg ICAgICAgICAgICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9tbS5oOjksCj4gICAgICAgICAg ICAgICAgICBmcm9tIC4uL2FyY2gvYXJtNjQva3ZtL3JlZ21hcC5jOjExOgo+IC4uL2FyY2gvYXJt NjQvaW5jbHVkZS9hc20vc3lzcmVnLmg6ODM3OjI6IHdhcm5pbmc6IHRoaXMgc3RhdGVtZW50IG1h eSBmYWxsCj4gIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+ICAgYXNtIHZvbGF0 aWxlKCJtc3IgIiBfX3N0cmluZ2lmeShyKSAiLCAleDAiICBcCj4gICBefn4KPiAuLi9hcmNoL2Fy bTY0L2t2bS9yZWdtYXAuYzoxODI6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHdy aXRlX3N5c3JlZ+KAmQo+ICAgIHdyaXRlX3N5c3JlZyh2LCBzcHNyX2FidCk7Cj4gICAgXn5+fn5+ fn5+fn5+Cj4gLi4vYXJjaC9hcm02NC9rdm0vcmVnbWFwLmM6MTgzOjI6IG5vdGU6IGhlcmUKPiAg IGNhc2UgS1ZNX1NQU1JfVU5EOgo+ICAgXn5+fgo+IAo+IFJld29yayB0byBhZGQgYSAnYnJlYWs7 JyBpbiB0aGUgc3dpY2gtY2FzZSBzaW5jZSBpdCBkaWRuJ3QgaGF2ZSB0aGF0Lgo+IFRoYXQgYWxz byBtYWRlIHRoZSBjb21waWxlciBoYXBweSBhbmQgZGlkbid0IHdhcm4gYWJvdXQgZmFsbC10aHJv dWdoLgo+IAo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnICMgdjMuMTYrCgpFcm0uLi4gQXJl IHlvdSBzdXJlIGFib3V0IHRoYXQ/IEhlcmUncyB3aGF0IEkgaGF2ZToKCiQgZ2l0IGRlc2NyaWJl IC0tY29udGFpbnMgIGE4OTI4MTk1NjBjNAprdm0tYXJtLWZvci12NC4xN340NAokIGdpdCBkZXNj cmliZSAtLWNvbnRhaW5zIC0tbWF0Y2g9J3YqJyBhODkyODE5NTYwYzQKdjQuMTctcmMxfjcyXjJ+ MzZeMn40NAoKCj4gRml4ZXM6IGE4OTI4MTk1NjBjNCAoIktWTTogYXJtNjQ6IFByZXBhcmUgdG8g aGFuZGxlIGRlZmVycmVkIHNhdmUvcmVzdG9yZSBvZiAzMi1iaXQgcmVnaXN0ZXJzIikKPiBTaWdu ZWQtb2ZmLWJ5OiBBbmRlcnMgUm94ZWxsIDxhbmRlcnMucm94ZWxsQGxpbmFyby5vcmc+Cj4gLS0t Cj4gIGFyY2gvYXJtNjQva3ZtL3JlZ21hcC5jIHwgNSArKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwg NSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3JlZ21hcC5j IGIvYXJjaC9hcm02NC9rdm0vcmVnbWFwLmMKPiBpbmRleCAwZDYwZTRmMGFmNjYuLmE5MDAxODFl Mzg2NyAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2t2bS9yZWdtYXAuYwo+ICsrKyBiL2FyY2gv YXJtNjQva3ZtL3JlZ21hcC5jCj4gQEAgLTE3OCwxMyArMTc4LDE4IEBAIHZvaWQgdmNwdV93cml0 ZV9zcHNyMzIoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBsb25nIHYpCj4gIAlzd2l0 Y2ggKHNwc3JfaWR4KSB7Cj4gIAljYXNlIEtWTV9TUFNSX1NWQzoKPiAgCQl3cml0ZV9zeXNyZWdf ZWwxKHYsIFNZU19TUFNSKTsKPiArCQlicmVhazsKPiAgCWNhc2UgS1ZNX1NQU1JfQUJUOgo+ICAJ CXdyaXRlX3N5c3JlZyh2LCBzcHNyX2FidCk7Cj4gKwkJYnJlYWs7Cj4gIAljYXNlIEtWTV9TUFNS X1VORDoKPiAgCQl3cml0ZV9zeXNyZWcodiwgc3Bzcl91bmQpOwo+ICsJCWJyZWFrOwo+ICAJY2Fz ZSBLVk1fU1BTUl9JUlE6Cj4gIAkJd3JpdGVfc3lzcmVnKHYsIHNwc3JfaXJxKTsKPiArCQlicmVh azsKPiAgCWNhc2UgS1ZNX1NQU1JfRklROgo+ICAJCXdyaXRlX3N5c3JlZyh2LCBzcHNyX2ZpcSk7 Cj4gKwkJYnJlYWs7Cj4gIAl9Cj4gIH0KCk90aGVyd2lzZSBsb29rcyBsaWtlIHRoZSByaWdodCBm aXggdG8gbWUuIExldCBtZSBrbm93IHdoYXQgeW91IHRoaW5rCmFib3V0IHRoZSBGaXhlczogdGFn IChubyBuZWVkIHRvIHJlc2VuZCBmb3IgdGhhdCkuCgpUaGFua3MsCgoJTS4KCi0tIApKYXp6IGlz IG5vdCBkZWFkLCBpdCBqdXN0IHNtZWxscyBmdW5ueS4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1731C76191 for ; Fri, 26 Jul 2019 12:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 914BB22ADA for ; Fri, 26 Jul 2019 12:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbfGZMat convert rfc822-to-8bit (ORCPT ); Fri, 26 Jul 2019 08:30:49 -0400 Received: from foss.arm.com ([217.140.110.172]:42518 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726277AbfGZMat (ORCPT ); Fri, 26 Jul 2019 08:30:49 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 499B7337; Fri, 26 Jul 2019 05:30:48 -0700 (PDT) Received: from big-swifty.misterjones.org (unknown [10.37.13.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C4A13F694; Fri, 26 Jul 2019 05:30:46 -0700 (PDT) Date: Fri, 26 Jul 2019 13:30:44 +0100 Message-ID: <86ef2dnfkb.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Anders Roxell Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: KVM: regmap: Mark expected switch fall-through In-Reply-To: <20190726112705.19000-1-anders.roxell@linaro.org> References: <20190726112705.19000-1-anders.roxell@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anders, On Fri, 26 Jul 2019 12:27:05 +0100, Anders Roxell wrote: > > When fall-through warnings was enabled by default, commit d93512ef0f0e > ("Makefile: Globally enable fall-through warning"), the following > warnings was starting to show up: > > In file included from ../arch/arm64/include/asm/kvm_emulate.h:19, > from ../arch/arm64/kvm/regmap.c:13: > ../arch/arm64/kvm/regmap.c: In function ‘vcpu_write_spsr32’: > ../arch/arm64/include/asm/kvm_hyp.h:31:3: warning: this statement may fall > through [-Wimplicit-fallthrough=] > asm volatile(ALTERNATIVE(__msr_s(r##nvh, "%x0"), \ > ^~~ > ../arch/arm64/include/asm/kvm_hyp.h:46:31: note: in expansion of macro ‘write_sysreg_elx’ > #define write_sysreg_el1(v,r) write_sysreg_elx(v, r, _EL1, _EL12) > ^~~~~~~~~~~~~~~~ > ../arch/arm64/kvm/regmap.c:180:3: note: in expansion of macro ‘write_sysreg_el1’ > write_sysreg_el1(v, SYS_SPSR); > ^~~~~~~~~~~~~~~~ > ../arch/arm64/kvm/regmap.c:181:2: note: here > case KVM_SPSR_ABT: > ^~~~ > In file included from ../arch/arm64/include/asm/cputype.h:132, > from ../arch/arm64/include/asm/cache.h:8, > from ../include/linux/cache.h:6, > from ../include/linux/printk.h:9, > from ../include/linux/kernel.h:15, > from ../include/asm-generic/bug.h:18, > from ../arch/arm64/include/asm/bug.h:26, > from ../include/linux/bug.h:5, > from ../include/linux/mmdebug.h:5, > from ../include/linux/mm.h:9, > from ../arch/arm64/kvm/regmap.c:11: > ../arch/arm64/include/asm/sysreg.h:837:2: warning: this statement may fall > through [-Wimplicit-fallthrough=] > asm volatile("msr " __stringify(r) ", %x0" \ > ^~~ > ../arch/arm64/kvm/regmap.c:182:3: note: in expansion of macro ‘write_sysreg’ > write_sysreg(v, spsr_abt); > ^~~~~~~~~~~~ > ../arch/arm64/kvm/regmap.c:183:2: note: here > case KVM_SPSR_UND: > ^~~~ > > Rework to add a 'break;' in the swich-case since it didn't have that. > That also made the compiler happy and didn't warn about fall-through. > > Cc: stable@vger.kernel.org # v3.16+ Erm... Are you sure about that? Here's what I have: $ git describe --contains a892819560c4 kvm-arm-for-v4.17~44 $ git describe --contains --match='v*' a892819560c4 v4.17-rc1~72^2~36^2~44 > Fixes: a892819560c4 ("KVM: arm64: Prepare to handle deferred save/restore of 32-bit registers") > Signed-off-by: Anders Roxell > --- > arch/arm64/kvm/regmap.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/kvm/regmap.c b/arch/arm64/kvm/regmap.c > index 0d60e4f0af66..a900181e3867 100644 > --- a/arch/arm64/kvm/regmap.c > +++ b/arch/arm64/kvm/regmap.c > @@ -178,13 +178,18 @@ void vcpu_write_spsr32(struct kvm_vcpu *vcpu, unsigned long v) > switch (spsr_idx) { > case KVM_SPSR_SVC: > write_sysreg_el1(v, SYS_SPSR); > + break; > case KVM_SPSR_ABT: > write_sysreg(v, spsr_abt); > + break; > case KVM_SPSR_UND: > write_sysreg(v, spsr_und); > + break; > case KVM_SPSR_IRQ: > write_sysreg(v, spsr_irq); > + break; > case KVM_SPSR_FIQ: > write_sysreg(v, spsr_fiq); > + break; > } > } Otherwise looks like the right fix to me. Let me know what you think about the Fixes: tag (no need to resend for that). Thanks, M. -- Jazz is not dead, it just smells funny.