Re: [PATCH 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 03/09/2025 10:17, Matti Vaittinen wrote:
> On 03/09/2025 09:47, Linus Walleij wrote:
>> On Wed, Sep 3, 2025 at 7:23 AM Matti Vaittinen 
>> <mazziesaccount@gmail.com> wrote:
>>
>>> Anyways, fast-forward to this day, I don't see it handling valid_mask. I
>>> think it is a must for this device/driver, where pins can be either
>>> GPIOs or ADC inputs.
>>
>> Why not just add a .init_valid_mask() to
>> struct gpio_regmap_config so it can just pass that
>> down to its gpio_chip?
> 
> Sigh. I suppose that would technically make sense. (So would allowing 
> other IC-specific callbacks... ;) ).
> 
>> OK I don't want to load you with too much extra work for
>> the driver, but it seems such a small thing for a blocker,
>> and Michael who wrote the library is really helpful
>> with extending the code, so consider it!
> 
> I suppose I can see how that works out. I am not a fan of maintaining 
> the extra code. Thanks for the suggestion.

After more thorough look, I don't think the gpio-regmap is flexible 
enough for this IC (either). The BD79112 direction setting requires 
accessing two registers (one for input, other for output), and I don't 
see how this could be done with the current gpio-regmap.

...If only I was able to override the direction setting callback with IC 
specific one, then I could use the regular gpio-regmap for all the rest...

Yours,
	-- Matti