All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: richard.xnu.clark@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, will@kernel.org,
	linux@armlinux.org.uk, mark.rutland@arm.com,
	torvalds@linux-foundation.org
Subject: Re: Question about interrupt prioriyt of ARM GICv3/4
Date: Fri, 13 Dec 2024 14:22:03 +0000	[thread overview]
Message-ID: <86frmrslx0.wl-maz@kernel.org> (raw)
In-Reply-To: <871pydxde2.fsf@bloch.sibelius.xs4all.nl>

On Thu, 12 Dec 2024 13:02:45 +0000,
Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> 
> Based on my experience with OpenBSD, I'm not even sure there is much
> benefit even if you have preemtion.
> 
> And regarding anything wrong happening: there is an interesting bug in
> the RK3399 GIC integration where it gets the priorities wrong:
> 
> https://github.com/openbsd/src/blob/feb3ea439d8f49b3c0e33f54c34631a611b98e21/sys/arch/arm64/dev/agintc.c#L395
> 
> (that comment is my interpretation of what's happening; I might be
> misinterpreting what's really going on)
> 
> As far as I can tell the Linux code doesn't handle that quirk.
> Probably it doesn't matter because Linux only uses the priority
> mechanisms to implement pseudo-NMI functionality and/or doesn't do
> preemption of interrupts.

Ah, beautiful! We actually do preemption with pseudo-NMI, and as it
turns out, I just had a report of 6.11 being broken on that SoC when
pNMIs are enabled.

My "solution" for this is to just disable security at the distributor
level, and let things rip, see [1].

Thanks for the heads up!

	M.

[1] https://lore.kernel.org/r/20241213141037.3995049-1-maz@kernel.org

-- 
Without deviation from the norm, progress is not possible.


  parent reply	other threads:[~2024-12-13 14:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06  8:33 Question about interrupt prioriyt of ARM GICv3/4 richard clark
2024-12-06  9:37 ` Marc Zyngier
2024-12-12  9:18   ` richard clark
2024-12-12 10:12     ` Marc Zyngier
2024-12-12 13:02       ` Mark Kettenis
2024-12-13  9:27         ` Richard Clark
2024-12-13 14:22         ` Marc Zyngier [this message]
2024-12-13  9:13       ` Richard Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86frmrslx0.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.kettenis@xs4all.nl \
    --cc=mark.rutland@arm.com \
    --cc=richard.xnu.clark@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.