Re: [PATCH] KVM: arm64: nv: Use GFP_KERNEL_ACCOUNT for sysreg_masks allocation

[Marc Zyngier <maz@kernel.org>]

On Mon, 17 Jun 2024 19:10:18 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
> 
> Of course, userspace is in the driver's seat for struct kvm and
> associated allocations. Make sure the sysreg_masks allocation
> participates in kmem accounting.
> 
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
> ---
>  arch/arm64/kvm/nested.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
> index 6813c7c7f00a..57e3fb3eb334 100644
> --- a/arch/arm64/kvm/nested.c
> +++ b/arch/arm64/kvm/nested.c
> @@ -196,7 +196,7 @@ int kvm_init_nv_sysregs(struct kvm *kvm)
>  		goto out;
>  
>  	kvm->arch.sysreg_masks = kzalloc(sizeof(*(kvm->arch.sysreg_masks)),
> -					 GFP_KERNEL);
> +					 GFP_KERNEL_ACCOUNT);
>  	if (!kvm->arch.sysreg_masks) {
>  		ret = -ENOMEM;
>  		goto out;
> 
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0

Ah, well spotted.

Reviewed-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.