From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbdGHJpb convert rfc822-to-8bit (ORCPT ); Sat, 8 Jul 2017 05:45:31 -0400 Received: from foss.arm.com ([217.140.101.70]:53828 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbdGHJp3 (ORCPT ); Sat, 8 Jul 2017 05:45:29 -0400 From: Marc Zyngier To: Paul Menzel Cc: Thomas Gleixner , John Garry , Subject: Re: irq: Invalid fwnode type (2) for irqdomain In-Reply-To: <1499498897.1038.2.camel@molgen.mpg.de> (Paul Menzel's message of "Sat, 8 Jul 2017 09:28:17 +0200") Organization: ARM Ltd References: <1499250919.1353.3.camel@molgen.mpg.de> <616db264-ba9f-f729-25a9-ee57ee8c2f10@arm.com> <1499498897.1038.2.camel@molgen.mpg.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Sat, 08 Jul 2017 10:45:25 +0100 Message-ID: <86fue72rey.fsf@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 08 2017 at 9:28:17 am BST, Paul Menzel wrote: Hi Paul, >> I've been reported an issue that is somewhat related to this, Any >> chance you could give this[1] a go? I have no way to test it... > > The commit below indeed made the warning go away. > >> commit 6bf31c05f2a967e5351a3050ef51c18c8c9ee291 >> Author: Marc Zyngier >> Date:   Thu Jul 6 14:51:31 2017 +0100 >> >>     irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers >>      >>     A number of irqchip implementations are (ab)using the irqdomain >>     allocator by passing a fwnode that is neither a FWNODE_OF or >>     a FWNODE_IRQCHIP. >>      >>     This is pretty bad, but it also feels pretty crap to force these >>     drivers to allocate their own irqchip_fwid when they already have >>     a proper fwnode. >>      >>     Instead, let's teach the irqdomain allocator about ACPI device >>     nodes, and add some lovely name generation code... Tested on >>     an arm64 D05 system. >>      >>     Reported-by: John Garry >>     Signed-off-by: Marc Zyngier > > I wonder if a warning/debug messages could and should still be shown, > if a fwnode is neither a FWNODE_OF or a FWNODE_IRQCHIP. With this patch, the code covers FWNODE_OF, FWNODE_IRQCHIP and FWNODE_ACPI (the latter being the case you and John uncovered). Should we get any other fwnode_type value, the irqdomain code will still warn the user that this is not an object type we're ready to accept. Thanks again for the report and the testing. M. -- Jazz is not dead. It just smells funny.